EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Repository coverage

924 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

64security candidates205second-pass queue54AI analyses
55commits · 30 days
108commits · 60 days
454commits · 180 days
924commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

65/100 average clarity
191Strong · 80–100
409Adequate · 60–79
285Thin · 40–59
39Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight3492517063
f321x3712121070
Sander van Grieken98108057
ThomasV7222056
user322062
Roman Zeyde511053
Sasha Zykov411076
Aaron Fiore411068
Ferdinando Ametrano111096
Ilya Artemov200050
Oren200043
Sebastian van Staa100045
Analysis record

Published AI watches

Last scanned 0 minutes ago

Informational 19 AI analysisMessage 96 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

wallet: sign_message: strip whitespaces in GUIs, do not strip in CLI

This commit tidies up how Electrum handles extra spaces around Bitcoin addresses, messages, and signatures when signing or verifying messages. Previously, different parts of the program (desktop GUI, mobile-style GUI, command line) behaved…

Behavior normalization across GUI and CLI interfacesNo cryptographic primitive changedNo privilege boundary crossed
4c3064f5by SomberNight+27−185 files
No security note in commit
Informational 19 AI analysisMessage 96 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

qml: strip whitespace from message before signing, as in qt gui

This commit fixes a minor consistency bug in Electrum's newer QML (mobile-style) user interface. When signing a message, the app now removes accidental spaces at the start or end of the message and address, just like the older desktop Qt i…

Behavioral inconsistency between GUI implementations could cause user confusion or failed verificationNo cryptographic weakness introduced; change is input normalizationNo memory-unsafe code, no privilege changes, no network changes
72507328by Ferdinando Ametrano+3−01 file
No security note in commit
Low 25 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

trezor: drop session after closing it

This commit fixes a bug in Electrum's support for Trezor hardware wallets. After a Trezor session times out or is closed, Electrum now forgets the old session ID. Previously it kept the stale session ID, so the next attempt to sign a trans…

Fixes a stale-session reference that caused InvalidSessionError on re-authenticationEnsures PIN re-prompt after session timeout/closureFailure mode was denial-of-service (transaction signing crash), not unauthorized signing
071b1e24by f321x+8−51 file
No security note in commit
Informational 18 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

qml: update ConfirmTxDialog onValidChanged

This is a small user-interface fix for the Electrum mobile/QML app. When sweeping private keys, the confirmation dialog that shows how much money will be moved initially displayed an amount of 0 because it did not refresh after the transac…

bd776e24by f321x+3−01 file
No security note in commit
Low 42 AI analysisMessage 85 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

wallet.check_sighash: don't assume tx.add_info_from_wallet alrdy ran

This commit fixes a defensive check in the Electrum Bitcoin wallet. Before signing a transaction, Electrum checks whether the transaction uses unusual 'sighash' flags that could allow someone else to move coins unexpectedly. The bug was th…

Sighash sanity check could be bypassed for beyond-gap-limit wallet inputsFix adds defensive deep-copy and wallet-info population inside check_sighashRegression test demonstrates dangerous sighash is now caught even with gap_limit=2
b57327fbby SomberNight+48−02 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

exchange rate: remove CoinDesk provider

This commit simply removes the CoinDesk exchange-rate provider from Electrum because CoinDesk's old API no longer works and its new API requires a paid authorization token. It is a routine cleanup, not a security fix.

6571e479by f321x+0−1972 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

hw_wallet/qt: reuse device message dialog across button requests

This commit is a user-interface performance and polish fix for Electrum's hardware wallet integration. It stops the app from destroying and recreating the same on-screen prompt every time a hardware wallet asks the user to confirm a transa…

898a4c27by Sasha Zykov+15−11 file
No security note in commit
Low 25 AI analysisMessage 88 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

lnmsg: add new primitive type `bip340sig`, add tlv merkle root calculation and schnorr-sign over tlvs, implicit en/decode utf8 fields, schnorr signature verification.

This commit adds new Lightning Network message handling code to Electrum. It introduces a new BIP-340 Schnorr signature field type, computes Merkle roots over TLV (type-length-value) records, signs and verifies those roots, and adds implic…

New cryptographic signing/verification path addedNew BIP-340 tagged-hash Merkle root constructionSignature TLVs excluded from the Merkle root they sign
759ef10dby Sander van Grieken+160−111 file
No security note in commit
Moderate 55 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

lnpeer: on_ping: drain out-socket buffer

This change fixes a potential denial-of-service weakness in Electrum's Lightning network peer handling. Previously, when Electrum replied to a peer's 'ping' message, it would add the reply to the outgoing socket buffer without waiting to c…

memory exhaustion / DoS mitigationunbounded outbound buffer growth preventedbackpressure added to peer ping/pong handling
9b206576by SomberNight+6−12 files
Vendor flagged security relevance
Informational 20 AI analysisMessage 100 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: give more permissions to claude

This commit changes Electrum's automated CI security-review bot so that the Claude AI assistant is allowed to run shell commands and modify files on its own, rather than only answering questions. The change is intentional and runs inside a…

New command-line flag named `--dangerously-skip-permissions` introducedCI script now permits an AI agent to execute commands and modify files without interactive permission checksExecution context changed from root to unprivileged `node` user to satisfy Claude's refusal to run as root
39cdb23eby f321x+4−12 files
No security note in commit
Informational 15 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

tests: regtest: make test_just_in_time less flaky

This commit only changes a test script. It adds a wait helper so a test that opens two Lightning channels in a row does not fail randomly on continuous integration. There is no change to Electrum's actual wallet or Lightning code, so users…

12547f94by f321x+23−01 file
No security note in commit
Informational 24 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Upgrade `trezorlib` to 0.20.1

This commit updates Electrum's Trezor hardware wallet plugin to work with a newer version of the trezorlib library (0.20.1). It rewrites how Electrum opens sessions with Trezor devices, especially when passphrases are used. The change is a…

Dependency upgrade of hardware-wallet communication libraryRefactoring of device session and passphrase handlingChange from init_device() to ping() for liveness check
0f2fa36eby Roman Zeyde+69−464 files
No security note in commit
Informational 15 AI analysisMessage 35 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

qml: additional styling updates

This commit is purely a user-interface styling refresh for Electrum's QML (mobile/desktop) GUI. It swaps some visual components (highlight panes, button containers, padding, colors) and introduces a new shared 'DialogHighlightPane' control…

28f744f7by Sander van Grieken+136−8525 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

qml: styling updates qt6.10

This commit is a routine user-interface refresh for Electrum's mobile/desktop QML app, adjusting colors, spacing, button containers, and placeholder text to match newer Qt 6.10 styling. There is no security-relevant change and no indicatio…

cdb5c0b8by Sander van Grieken+209−17540 files
No security note in commit
Informational 18 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

android: pin hostpython3 PyProjectRecipe versions, pin android and pyjnius recipes Cython version

This commit tightens the Android build process for the Electrum Bitcoin wallet by pinning exact versions of build tools (like Cython, pip, setuptools) and their cryptographic hashes. It also updates the version of python-for-android used. …

Pins build-time dependency versions and cryptographic hashesUpdates python-for-android pinned checkout commitAdds new pinned recipe overrides for android and pyjnius Cython prerequisites
74f3c042by Sander van Grieken+54−34 files
No security note in commit
Low 28 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

android: build pyqt_builder and sip ourselves, hash pin all hostpython_prerequisites

This commit updates the Android build setup for the Electrum Bitcoin wallet. It switches to a newer version of the python-for-android build tool, starts building two PyQt-related packages (pyqt_builder and sip) from source instead of relyi…

Hash-pinning of build-time Python dependencies (setuptools, pip)Source-build of pyqt_builder and sip instead of wheel installationpython-for-android checkout bump to newer commit
c8f5798dby Sander van Grieken+21−56 files
No security note in commit
Low 25 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: add workarounds for issue assigning custom types to QObject properties

This commit changes how the Electrum mobile/desktop QML GUI passes custom data objects between Python and the user interface. It switches many typed properties to the generic QVariant/'var' type and adds runtime type checks (asserts) in Py…

Type system relaxation: custom typed QML/Python properties changed to generic QVariant/varRuntime type enforcement added via assert statements in Python settersNo explicit security framing in commit message or diff
9772a6d5by Sander van Grieken+86−5924 files
No security note in commit
Moderate 62 AI analysisMessage 93 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

verifier.py: fix CVE-2012-2459: reject left-sibling duplicates

This commit fixes a known Bitcoin weakness (CVE-2012-2459) in Electrum's light-client verification. Because Bitcoin's Merkle tree duplicates the last hash when a level has an odd number of items, an attacker can craft a block proof that ma…

Fixes CVE-2012-2459 (Merkle tree duplicate-node weakness)Adds explicit LeftSiblingDuplicate exceptionStrengthens SPV Merkle proof verification
3d390742by SomberNight+106−262 files
Vendor flagged security relevance
Moderate 65 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

daemon: set restrictive permission on RPC-server unix domain socket

Electrum's background daemon runs a local control server using a Unix domain socket. Previously, that socket file was created with permissions 0775, meaning any user in the same group could connect to it and potentially control the wallet.…

permission tightening on local RPC socketacknowledged race condition between socket creation and chmodlocal privilege boundary issue (group-writable socket)
9d204abfby SomberNight+8−11 file
Vendor flagged security relevance
Moderate 62 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

in GUI mode, only start a limited minimal RPC server

This commit reduces the attack surface of Electrum's built-in remote-control server when running in normal GUI mode. Previously, the RPC server exposed many wallet-related commands; now, in GUI mode on mainnet, it only exposes two safe com…

Reduction of RPC attack surface in GUI modeUnencrypted localhost RPC with config-stored passwordWindows localhost TCP exposure of RPC server
d951a3d2by SomberNight+22−102 files
Vendor flagged security relevance
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedtest_lnmsg: add bolt 12 merkle tree test vectorby f321x · 5426f0a1 · Jun 9, 2026 · 2 filesMessage 55 · ThinTriage 17Details
Commit message · f321x

test_lnmsg: add bolt 12 merkle tree test vector

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
Lower-prioritylnmsg: fix parsing of nested complex types where the leaf objectsby Sander van Grieken · 2e89915c · Jun 9, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Sander van Grieken

lnmsg: fix parsing of nested complex types where the leaf objects

were consuming too much from the fd.

Co-Authored-By: f321x <f@f321x.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-prioritylnmsg: validate point primitive fieldby f321x · 9b151a60 · Jun 9, 2026 · 2 filesMessage 78 · AdequateTriage 13Details
Commit message · f321x

lnmsg: validate point primitive field

Validate points to be valid ECPubkeys in lnmsg._read_primitive_field.
There are failing bolt12 test vectors that contain offers with invalid
points.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationfuzzing or regression evidence
Security candidatelnmsg: add new primitive type `bip340sig`, add tlv merkle root calculation and schnorr-sign over tlvs, implicit en/decode utf8 fields, schnorr signature verification.by Sander van Grieken · 759ef10d · Jun 9, 2026 · 1 fileMessage 88 · StrongLow 25Details
Commit message · Sander van Grieken

lnmsg: add new primitive type `bip340sig`, add tlv merkle root calculation and schnorr-sign over tlvs,
implicit en/decode utf8 fields, schnorr signature verification.

Co-Authored-By: f321x <f@f321x.com>

88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validation
AI analysis · Low 25/100

This commit adds new Lightning Network message handling code to Electrum. It introduces a new BIP-340 Schnorr signature field type, computes Merkle roots over TLV (type-length-value) records, signs and verifies those roots, and adds implicit UTF-8 encoding/decoding for text fields. The changes are a feature addition to support BOLT12-style offers/invoices rather than a fix for a known vulnerability. There is no direct evidence in the commit or supplied references that this patch itself creates or fixes a security bug, but any new cryptographic signing code carries implementation risk.

Lower-prioritycommon_qt: move submarine swap support code from qt gui to common_qt as SubmarineSwapMixinby Sander van Grieken · 7c728344 · Jun 8, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · Sander van Grieken

common_qt: move submarine swap support code from qt gui to common_qt as SubmarineSwapMixin

This covers the functionality for swap use during payments (so, change-to-ln and
submarine-payments) present in gui/qt/confirm_tx_dialog, not the 'standalone' swap.

This is in preparation for adding the same functionality to qml.

- move swap support code from TxEditor to SubmarineSwapMixin
- don't require wallet instance at construction, allow late setting of wallet

swaps: add initialize/destroy methods to SwapServerTransport, to simplify consumer side, adds
a done callback so the transport can be used once ready or failure can be handled.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityqt: move wait_for_swap_transport to SwapManagerby Sander van Grieken · 1a1516ac · Jun 8, 2026 · 2 filesMessage 45 · ThinTriage 0Details
Commit message · Sander van Grieken

qt: move wait_for_swap_transport to SwapManager

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityswaps: encapsulate swap transport ongoing_connection_attempt future into transportby Sander van Grieken · 1fae2da5 · Jun 8, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Sander van Grieken

swaps: encapsulate swap transport ongoing_connection_attempt future into transport

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityqt: refactor message for change-to-lightning swap to backend submarine_swaps.pyby Sander van Grieken · ffec9df1 · Jun 8, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Sander van Grieken

qt: refactor message for change-to-lightning swap to backend submarine_swaps.py

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityqt/send_tab: drop redundant invoice_list.update() after broadcastby Sasha Zykov · c8db5c83 · Jun 6, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Sasha Zykov

qt/send_tab: drop redundant invoice_list.update() after broadcast

The full invoice-list rebuild after a successful broadcast is
unnecessary: the set_broadcasting(PR_BROADCAST) call immediately after
fires the invoice_status callback for any touched invoices, and
main_window.on_event_invoice_status updates the affected rows
incrementally via refresh_item / delete_item. Tx ingestion also sets
need_update, which causes update_tabs() to refresh.

On wallets with many invoices this rebuild iterated all unpaid
invoices and called get_invoice_status() per entry on the GUI thread,
contributing to the post-broadcast freeze fixed in the previous commit.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedwallet: cache paid-invoice keys to avoid prevout rescanby Sasha Zykov · d2d4251c · Jun 6, 2026 · 2 filesMessage 85 · StrongTriage 12Details
Commit message · Sasha Zykov

wallet: cache paid-invoice keys to avoid prevout rescan

On wallets with many outgoing invoices that share output scriptpubkeys,
broadcasting a new transaction froze the GUI for several seconds — up
to a minute on bigger wallets. The hot loops in set_broadcasting() and
_update_onchain_invoice_paid_detection() iterate every invoice touched
by the new tx's outputs, which is large when scriptpubkeys are shared
via _invoices_from_scriptpubkey_map. For each touched invoice they call
_is_onchain_invoice_paid(), which scans all of the invoice's output
scripthashes against _prevouts_by_scripthash and does a get_tx_height
per prevout. Both inner dimensions blow up together when invoices share
inputs/outputs across many past payments.

Add _paid_invoice_keys: Set[str], an in-memory cache of outgoing
invoice ids known to be PR_PAID, maintained incrementally:

- populated at wallet load by _prepare_onchain_invoice_paid_detection
- updated in _update_onchain_invoice_paid_detection (discard then
recompute, so reorgs still demote PAID->UNPAID)
- updated in save_invoice, delete_invoice, clear_invoices
- new on_event_invoice_status listener keeps it in sync with
LN-driven transitions from LNWallet.set_invoice_status

get_invoice_status() short-circuits to PR_PAID on cache hit, skipping
the prevout scan. set_broadcasting() skips already-paid invoices
entirely — broadcasting_status has no effect on a paid invoice and the
callback churn is what made the GUI freeze.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queued(trivial) move StorageEncryptionVersion and StorageReadWriteError to stored_dict.pyby ThomasV · 1f4c0fc7 · Jun 6, 2026 · 4 filesMessage 50 · ThinTriage 12Details
Commit message · ThomasV

(trivial) move StorageEncryptionVersion and StorageReadWriteError to stored_dict.py

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedstorage: add get_path methodby ThomasV · 6797e917 · Jun 6, 2026 · 7 filesMessage 35 · OpaqueTriage 12Details
Commit message · ThomasV

storage: add get_path method

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
Lower-prioritylnpeer: add fixme for unsafe zeroconf behaviourby SomberNight · ab7a5656 · Jun 5, 2026 · 1 fileMessage 76 · AdequateTriage 8Details
Commit message · SomberNight

lnpeer: add fixme for unsafe zeroconf behaviour

there is a later check in Channel.update_funded_state
added in https://github.com/spesmilo/electrum/pull/9624
but it only validates the funding_tx once it's already 3 blocks deep

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validation
AI review queuedlnchan: if funding tx is coinbase tx, wait for maturityby SomberNight · 08f39f89 · Jun 5, 2026 · 2 filesMessage 73 · AdequateTriage 12Details
Commit message · SomberNight

lnchan: if funding tx is coinbase tx, wait for maturity

ref https://github.com/lightning/bolts/commit/17ab3f0dfef50ab98c326a56cb4d109e6f733ab8

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Lower-priorityonion_messages: filter correct feature when creating pathsby f321x · b3af267e · Jun 5, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · f321x

onion_messages: filter correct feature when creating paths

Filter channels/peers in `get_blinded_paths_to_me` depending on
the context (onion message or blinded payment path). Raise
according exceptions when no channel/peer is available.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityonion_message: pathfinding: ignore amount contraintsby f321x · 2ebfb992 · Jun 5, 2026 · 3 filesMessage 73 · AdequateTriage 0Details
Commit message · f321x

onion_message: pathfinding: ignore amount contraints

Ignore channel amount constraints when doing pathfinding for an
onion message. Onion messages don't need to move funds so pathfinding
shouldn't penalize channels based on fake payment amounts.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityonion_message: use trampoline nodes for onion messagesby f321x · 56565198 · Jun 5, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · f321x

onion_message: use trampoline nodes for onion messages

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityonion_message: handle missing remote updateby f321x · 1fe9c53e · Jun 5, 2026 · 1 fileMessage 60 · AdequateTriage 0Details
Commit message · f321x

onion_message: handle missing remote update

Handle missing remote channel_update when creating payinfo
for blinded path by skipping the affected channel.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityonion_message: add invoice buffer to payinfo cltv deltaby f321x · 5e54c41b · Jun 5, 2026 · 2 filesMessage 85 · StrongTriage 0Details
Commit message · f321x

onion_message: add invoice buffer to payinfo cltv delta

Add the 3 block invoice cltv delta buffer to the blinded payinfo's
cltv_expiry_delta to prevent issues where the sender sets the expiry
to exactly local_height + cltv_expiry_delta and blocks get mined
during forwarding.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI review queuedModify the 'stored_at' syntax, so that it includes the full pathby ThomasV · 5494e827 · Jun 5, 2026 · 5 filesMessage 85 · StrongTriage 12Details
Commit message · ThomasV

Modify the 'stored_at' syntax, so that it includes the full path

This may prevent collisions. More importantly, it also makes
it possible to cache the subdict of 'registered_names' that
is relevant to a given StoredDict, so that we do not need to
walk the path on every conversion. (performance optimization,
not part of this commit)

This is a backport from the levelDB branch

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Lower-priorityonion_message: factor out payinfo creation from get_blinded_paths_to_meby f321x · b0393baf · Jun 5, 2026 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · f321x

onion_message: factor out payinfo creation from get_blinded_paths_to_me

Separates the payinfo creation from get_blinded_paths_to_me into a separate
function.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityplugin: nwc: regularly re-broadcast info eventby f321x · 60e38814 · Jun 5, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · f321x

plugin: nwc: regularly re-broadcast info event

I noticed with my long running NWC deamon that after a
couple days some clients relying on the info event being
available stopped working. Alby e.g. shows
"Error: no info event (kind 13194) returned from relay".
After restarting the daemon it works again for some days.
It seems that relays drop the info events after some days,
even though they are not ephemeral and don't have an expiry tag.
So rebroadcasting them once a day should make the server more
reliable.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityplugin: nwc: give NWCServer its own taskgroupby f321x · 9b425692 · Jun 5, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · f321x

plugin: nwc: give NWCServer its own taskgroup

It seemed weird to pass the taskgroup of the plugin into
the NWCServer, this looks a bit cleaner. It also allows
to get multiple tasks of the NWCServer cancelled by cancelling
the NWCServers taskgroup.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedsimplify prevby SomberNight · 6a89dd30 · Jun 3, 2026 · 1 fileMessage 18 · OpaqueTriage 12Details
Commit message · SomberNight

simplify prev

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI review queuedtx_from_any: make sanitization optionalby ThomasV · 271f079d · Jun 3, 2026 · 3 filesMessage 58 · ThinTriage 20Details
Commit message · ThomasV

tx_from_any: make sanitization optional

re.sub is expensive (calls re.sub), it is not necessary
to call it when instantiating transactions from the wallet file.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path