BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

557 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

120security candidates80second-pass queue462AI analyses
0commits · 30 days
47commits · 60 days
209commits · 180 days
423commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
37Strong · 80–100
204Adequate · 60–79
275Thin · 40–59
41Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths32663289157
Mike Tolkachev541744153
Daniel Newton902078055
Mihailo Milenkovic878057
roderico633074
Valerio Vaccaro2226056
Jamie C. Driver525053
Gustavo Cateim917078
Austin-Fulbright414060
kkdao211068
quantpoet111072
cmiguelrn111045
Analysis record

Published AI watches

Last scanned 51 minutes ago

Moderate 57 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: whitelist reply message function calls

This commit adds a whitelist of approved functions that can be used when sending reply messages from the Jade hardware wallet to a connected computer or phone. Previously, any function could be passed in, which could allow a bug or malicio…

Function-pointer whitelist added to reply pathMultiple static reply helpers made global to enable whitelist comparisonAssertion tightened to validate callback before use
a59d14c2by Jon Griffiths+53−1513 files
No security note in commit
Low 42 AI analysisMessage 30 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

temporary_stack: whitelist temporary task function calls

This commit adds a whitelist to a special helper that lets certain functions run with extra memory stack space. Previously, any function could be passed to this helper. Now only a small list of approved functions is allowed, except during …

Addition of function-pointer whitelistRemoval of static linkage on internal functions to enable whitelist comparisonConditional bypass of whitelist only for debug/selfcheck builds
6a0fea51by Jon Griffiths+26−54 files
No security note in commit
Informational 15 AI analysisMessage 43 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

consistency: fix typos

This commit is a large typo-fixing cleanup across 40 files. Almost every change corrects spelling mistakes in code comments, variable names, or user-facing text strings. There is no change to program logic, security behavior, or cryptograp…

251f7713by Jon Griffiths+96−9640 files
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: document get_bip85_bip39_entropy

This commit only updates documentation and removes a single comment line. It documents an existing feature that lets a user request encrypted BIP85-based BIP39 entropy from the Jade hardware wallet after on-device confirmation. There is no…

05a578adby Jon Griffiths+52−12 files
No security note in commit
Low 28 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

bip85: expose get_bip85_bip39_entropy over rpc in addition to qr

This commit moves a feature that derives BIP85 BIP39 entropy from being available only in debug builds to being available over the normal RPC interface. BIP85 lets a hardware wallet derive child seed phrases from a master seed. Making this…

Feature moved from debug-only to production RPC surfaceNo accompanying access-control or input-sanitization changes visible in diffBIP85 entropy derivation is a sensitive cryptographic operation
c6c5e860by Jon Griffiths+3−41 file
No security note in commit
Informational 19 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

versioninfo: add JADE_INTERFACE field to show which connection source holds the unlocked wallet

This commit adds a new read-only field, JADE_INTERFACE, to the device's version information reply. It simply tells a connected computer which communication path (USB, Bluetooth, QR mode, etc.) currently has control of the unlocked wallet. …

No authentication or authorization logic changedNo cryptographic or key-management code changedNo input parsing or memory-unsafe code added
2fe9df0bby Daniel Newton+66−56 files
No security note in commit
Low 44 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx/sign_psbt: extra check for BTC inputs

This commit adds overflow protection when adding up the total value of Bitcoin transaction inputs in Blockstream Jade's signing code. Previously, the firmware used a plain addition that could silently wrap around if a specially crafted tra…

Integer overflow hardening in financial-amount accumulationDefensive checked_add_uint64() introduced where plain addition existedTransaction signing path now rejects overflowed input totals
41d7e8b4by Daniel Newton+15−32 files
No security note in commit
Informational 19 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: move NVS cache objects that can pin the DRAM heap to SPIRAM if available

This commit changes how the Jade hardware wallet's firmware uses memory. It moves some internal storage cache objects from the main RAM (DRAM) to external RAM (PSRAM/SPIRAM) when available. This is a memory-optimization change, not a direc…

Memory layout change: moves NVS cache from DRAM to SPIRAMNo direct security fix or vulnerability patch present in diffNo mention of CVE, security researcher, or security advisory in commit
329f73c5by Daniel Newton+7−17 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: migrate pin action tests from test_jade to rpc tests

This commit simply moves existing test cases from one test file to another. It does not change any production code, security behavior, or fix any vulnerability. The tests check that the Jade device correctly rejects invalid parameters for …

be0e6b3dby Mike Tolkachev+42−402 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: add tests for pin actions via debug_set_pin

This commit only adds a new test file that exercises PIN-related features of the Jade hardware wallet using a debug-only RPC command. It does not change any production code, introduce new functionality, or alter security behavior. The test…

dd3d5b22by Mike Tolkachev+334−01 file
No security note in commit
Moderate 62 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: require user to permit get_identity_shared_key RPC

This commit adds a user confirmation step before a hardware wallet will share an identity-derived shared secret. Previously, the get_identity_shared_key RPC could compute and return the shared key without the user pressing approve on the d…

RPC that derives/releases a cryptographic shared secret now requires explicit on-device user approvalInput validation added: identity string must be printable before being shown in a security promptNew dedicated accept/reject button event IDs separate this flow from sign_identity
7ca0d26cby Daniel Newton+70−116 files
No security note in commit
Informational 20 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

auth: add unattended pin selection for rpc tests

This commit adds a debug-only feature that lets automated tests set or change the device's PIN over an internal RPC message. It only compiles when special debug flags are enabled and is not present in normal production firmware. The change…

New RPC endpoint debug_set_pin can set/change the unlock PINPIN-handling code path modified to read from a mutable debug context instead of a fixed constantCode is wrapped in CONFIG_DEBUG_UNATTENDED_CI and CONFIG_DEBUG_MODE preprocessor guards
309ee8bbby Mike Tolkachev+100−205 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

pin: disallow pin update on initialized units in debug mode

This commit removes a special debug-only exception that previously allowed the PIN server's public key to be changed on a Jade hardware wallet that already had a wallet set up. In normal operation, changing this public key on an initialize…

Removal of debug-mode bypass for a security-critical authorization checkProtection against pinserver public key substitution on initialized devicesDefense-in-depth for wallet PIN/server trust binding
a5667efdby Jon Griffiths+1−31 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: fix mnemonic handling following seed changes

This commit only changes test code for the Blockstream Jade hardware wallet. It fixes how tests set and reset the device mnemonic/seed so tests run correctly after earlier seed-handling changes. There is no change to the actual wallet firm…

85e87d4eby Jon Griffiths+32−377 files
No security note in commit
Low 32 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

malloc_ext: fix JADE_CALLOC_DRAM

This commit fixes a macro definition for a memory-allocation helper. The macro was accidentally written to take only one argument ('size') even though the underlying function it calls needs two arguments ('number of items' and 'size of eac…

Memory-allocation wrapper macro arity mismatch fixedPotential for undefined behavior if mismatched macro were usedNo explicit security claim or CVE referenced in commit
828835ccby Daniel Newton+1−11 file
No security note in commit
Low 43 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: fix reply count for exact chunk sizes

This commit fixes a bug in how Blockstream Jade counts the number of message chunks needed to send back a signed Bitcoin transaction (PSBT). When the transaction size was an exact multiple of the chunk size, the device told the host there …

Integer division off-by-one in chunk/message countDevice abort on assertion when host requests non-existent chunkDenial-of-service-like symptom: valid signing flow can crash the device
4f1a1565by kkdao+38−22 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: allow tapping directly on touchscreen elements

This commit adds a new touchscreen mode for some Jade hardware wallets where users can tap on-screen buttons directly instead of only using the three virtual buttons below the screen. To reduce the risk of accidental or malicious confirmat…

New direct-touch input path added to GUI event handlingCritical-action buttons require long-press to mitigate stray or coerced tap confirmationsDestructive operations (reset, delete wallet, delete OTP) converted to critical yes/no prompts
a46aa30aby Bota+206−1111 files
Vendor flagged security relevance
Informational 13 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

urldecode: use plain strlen in self-tests of libjade

This commit only changes the internal test file for a URL-decoding helper. It swaps a custom string-length macro for the standard C strlen() function inside test data. The actual product code that users rely on is not changed, and there is…

b39a7a20by Mike Tolkachev+27−291 file
No security note in commit
Moderate 50 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: support tickers up to 24 characters

This commit updates the Blockstream Jade hardware wallet to support longer asset tickers (up to 24 characters) and adds validation to reject malformed tickers. It also fixes a potential display bug where a ticker longer than 8 characters c…

Buffer size increased from 8 to 25 bytes to match new ticker maximumNew input validation added for asset ticker length and character setsnprintf precision argument cast from size_t to int to avoid undefined behavior on some platforms
cc5859a6by Mike Tolkachev+36−53 files
No security note in commit
Low 29 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve empty ticker support

This commit hardens how the Blockstream Jade hardware wallet handles assets that have no ticker symbol. Previously, if an asset's ticker was missing (NULL), the code could pass a NULL pointer to string-length functions, which can cause cra…

NULL-pointer dereference risk in asset ticker handlingDefensive null-check added before strlen()New test fixture for NULL ticker asset path
9d0d74d0by Mike Tolkachev+30−23 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedbuild: migrate from verde to jade_builderby Jon Griffiths · c758f6dc · Feb 20, 2026 · 23 filesMessage 57 · ThinInformational 15Details
Commit message · Jon Griffiths

build: migrate from verde to jade_builder

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit is a routine build-system housekeeping change. It swaps the Docker image used for automated builds from 'verde' to 'jade_builder', updates the ESP-IDF framework version from 5.4.0 to 5.4.3, adjusts paths to the ESP-IDF installation, and refactors several CI helper scripts. There is no change to the wallet firmware code that handles private keys, transactions, or user data, and no security vulnerability is introduced or fixed in the diff itself.

AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · 61e14f44 · Feb 17, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes one date in the project's CHANGELOG.md file, moving a release date from 2026-02-09 to 2026-02-18. There is no code change, no security fix, and no functional change of any kind.

AI review queuedbuild: update release script directoriesby Jon Griffiths · a9d475b9 · Feb 6, 2026 · 3 filesMessage 57 · ThinInformational 15Details
Commit message · Jon Griffiths

build: update release script directories

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine build-script maintenance change. It updates three release helper scripts so they use different firmware output directory names for two hardware variants (jade2.0 and jade2.0c). There is no user-facing security change, no vulnerability fix, and no change to cryptographic signing logic.

AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · d70930c5 · Feb 5, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates the project's CHANGELOG.md file, adding release notes for version 1.0.39. It does not change any source code, configuration, or executable behavior. The changelog mentions routine items such as faster QR scanning, a library update, and minor fixes, but nothing is disclosed as a security vulnerability, and no code is patched.

AI review queuedutils: add util.c and functions is_potential_green_*_path()by Mihailo Milenkovic · e42b5c26 · Feb 2, 2026 · 4 filesMessage 65 · AdequateInformational 12Details
Commit message · Mihailo Milenkovic

utils: add util.c and functions is_potential_green_*_path()

Co-authored-by: Jon Griffiths <jon_p_griffiths@yahoo.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit adds a new utility file with helper functions that validate whether a Bitcoin key derivation path looks like one used by Blockstream Green wallets. There is no evidence in the commit that this fixes a security bug; it appears to be a new helper for recognizing Green wallet paths.

AI review queuedconsistency: fix comment typoby Jon Griffiths · ea4222a5 · Feb 2, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Jon Griffiths

consistency: fix comment typo

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only corrects a spelling mistake in a code comment ('conenction' to 'connection'). It does not change any program instructions, behavior, or security logic.

AI review queuedbuild: standardize v2 scripts to use HWDIRS as per v1by Jon Griffiths · 810adaf2 · Dec 18, 2025 · 3 filesMessage 62 · AdequateInformational 15Details
Commit message · Jon Griffiths

build: standardize v2 scripts to use HWDIRS as per v1

No functional changes.

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a build-script cleanup for Blockstream Jade firmware release tooling. It rewrites three shell scripts so they loop over a list of hardware directories (currently just 'jade2.0') instead of hard-coding that path, and adds 'set -e' to one script so it exits immediately on any error. The commit message explicitly says 'No functional changes.' There is no change to firmware code, cryptography, device behavior, or user-facing functionality, and no security issue is evident.

AI review queuedconfig: add a comment description to the top of sdkconfig filesby Daniel Newton · 11278425 · Dec 17, 2025 · 24 filesMessage 65 · AdequateInformational 15Details
Commit message · Daniel Newton

config: add a comment description to the top of sdkconfig files

This makes it easier to see which source config file was used when
sdkconfig.defaults was generated.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only adds one-line human-readable comments to the top of 24 configuration files. It does not change any settings, code, or behavior. There is no security relevance.

AI review queuedgui: add missing headerby Jon Griffiths · 72140599 · Dec 17, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

gui: add missing header

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This is a one-line change that adds a missing C header file include (#include "button_events.h") to a source file in the Blockstream Jade hardware wallet firmware. It is a routine build/fix commit with no apparent security relevance.

AI review queuedconsistency: fix spellingby Jon Griffiths · 4239cb6c · Dec 16, 2025 · 8 filesMessage 35 · OpaqueInformational 15Details
Commit message · Jon Griffiths

consistency: fix spelling

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only fixes spelling mistakes in code comments, changing the misspelled word 'implmentation' to 'implementation' across eight files. It does not change any actual program instructions, so it cannot affect security or functionality.

AI review queuedquirc: fix compiler warningby Jon Griffiths · ea03ce7d · Dec 3, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Jon Griffiths

quirc: fix compiler warning

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only swaps the order of two C keywords ('const static' becomes 'static const') and adds a missing newline at the end of a file. It is a cosmetic/compiler-warning fix with no functional or security change.

AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · fb264239 · Nov 18, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates the project's CHANGELOG.md file, adding release notes for version 1.0.37. It does not change any source code, configuration, or executable files. There is no security-relevant change in the diff itself.

AI review queuedUpdate CHANGELOG.mdby Jon Griffiths · 6ad13bff · Nov 12, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

Update CHANGELOG.md

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates the project's CHANGELOG.md file. It documents what was added, changed, and fixed in firmware versions 1.0.36 and 1.0.37, but does not modify any source code, build scripts, or configuration. There is no direct security-relevant code change to review in this commit itself.

AI review queuedusb: simplify handle_ota_reply logicby Jon Griffiths · 1e51b96c · Oct 23, 2025 · 1 fileMessage 35 · OpaqueLow 34Details
Commit message · Jon Griffiths

usb: simplify handle_ota_reply logic

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 34/100

This commit simplifies how a Blockstream Jade hardware wallet handles an over-the-air (OTA) firmware update reply received over USB. Previously, the code checked whether a CBOR boolean 'result' field existed and only updated the success flag if it did. Now it updates the success flag regardless of whether the field is present, and no longer treats a missing 'result' as a failure. This could mean a malformed or unexpected reply leaves the success flag set to its previous value rather than being explicitly cleared, potentially making an unsuccessful update appear successful.

AI review queuedtext fixesby Daniel Newton · 1f9b4b86 · Oct 22, 2025 · 2 filesMessage 0 · OpaqueInformational 15Details
Commit message · Daniel Newton

text fixes

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only fixes a few on-screen text labels and messages. It changes phrases like 'Setup Jade' to 'Set Up Jade', 'temporarily login using' to 'temporarily log in with', and 'Logout' to 'Log Out'. There are no code logic, security, or functional changes.

AI review queuedgui: include semphr.hby Jon Griffiths · 6de067ff · Oct 9, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

gui: include semphr.h

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds a single missing header file include for FreeRTOS semaphore functions in the GUI source file. It is a straightforward build fix with no visible security relevance in the diff or commit message.

AI review queuedbuild: initial re-work of the ci pipelineby Daniel Newton · 3025ce83 · Sep 23, 2025 · 39 filesMessage 100 · StrongInformational 15Details
Commit message · Daniel Newton

build: initial re-work of the ci pipeline

Split up and rename the various build stages to reflect what they do and
disambiguate e.g. building from flashing/testing. Use consistent naming
for jobs/config then leverage it to reduce boilerplate repetition.

Generate the CI build config from the developer build config, then remove
the developer build-only CI step.

Update the v2.0 developer build config to use JTAG so flashing between
it and CI builds doesn't require physically switching to JTAG mode.

Collate the build artifacts into a single download for release, pre-sign
the dev images for release automatically. Ensure sequential access to devices
using flock to prevent flaky failures.

Remove the CI use of ttgo as a substitute v2.0 device.

Co-authored-by: Jon Griffiths <jon_p_griffiths@yahoo.com>

100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit is a housekeeping rework of the project's continuous-integration (CI) build and test pipeline. It renames build stages, splits the GitLab CI configuration into smaller files, generates CI test configurations from developer configs, removes a substitute test device, and adds a release-staging script. There is no change to the wallet firmware's security logic, cryptography, or user-facing behavior.

AI review queuedconsistency: correct comment typosby Jon Griffiths · b0fc7a4c · Sep 9, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Jon Griffiths

consistency: correct comment typos

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only fixes three spelling mistakes in code comments within a single source file. No program logic, variables, or security behavior was changed.

AI review queuedv2jadesign: allow giving the device serial port to sign withby Jon Griffiths · 882311d8 · Sep 4, 2025 · 1 fileMessage 50 · ThinInformational 19Details
Commit message · Jon Griffiths

v2jadesign: allow giving the device serial port to sign with

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit updates a release signing helper script so the operator can optionally specify which serial port a connected Jade hardware device uses. It is a usability/operational change, not a fix for a software vulnerability in the device or wallet itself. There is no indication it addresses a security incident.

AI review queuedjadepy: fix logging nitby Jon Griffiths · fac46b7d · Sep 4, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

jadepy: fix logging nit

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit fixes a trivial typo in a debug log message: a missing space between two words ('length ...and encoding' becomes 'length ... and encoding'). It has no effect on program logic, security, or behavior.

AI review queuedsign_tx: return the error message when additional_info parsing failsby Jon Griffiths · 3a8f6095 · Sep 4, 2025 · 4 filesMessage 50 · ThinInformational 18Details
Commit message · Jon Griffiths

sign_tx: return the error message when additional_info parsing fails

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit fixes a minor user-experience and diagnostic issue in Blockstream Jade's transaction signing code. Previously, when the optional 'additional_info' block for Liquid transactions could not be parsed or validated, the device rejected the request without telling the caller exactly what went wrong. After the patch, the specific error message is passed back to the caller. There is no direct evidence this change fixes an exploitable security vulnerability.

AI review queuedsign_tx: Strengthen liquid commitment checks against the tx being signedby Jon Griffiths · a454d1f4 · Sep 4, 2025 · 6 filesMessage 83 · StrongModerate 59Details
Commit message · Jon Griffiths

sign_tx: Strengthen liquid commitment checks against the tx being signed

This change ensures that the transaction and any commitment values
match, if an asset/value commitment pair are given.

Commitments given as part of tx input data must have these fields, while
they are optional (and should be discouraged) for tx outputs.

We move the validation checking which was spread over several unrelated
areas into the function fetching the commitment data. This ensures that
when fetching it, it is either fully validated from that point on or an
error is returned.

Following this we remove the commitment fields from the commitment_t struct
since they are now redundant for the remainder of sign_tx processing.

From experience debugging tests where the commitments mismatched, the
old error messages were not helpful. Update these to include 'trusted
commitment' in all messages to make it clearer when a mismatch is
detected.

Note This commit is deliberately minimal to make the core logic changes
easier to review.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit hardens how Blockstream Jade validates confidential (blinded) transaction data on Liquid. It moves and strengthens checks so that any asset/value commitment pair supplied by the caller must match the transaction actually being signed, and it removes redundant commitment fields from an internal data structure. The change is defensive: it reduces the chance that a malicious or buggy host could trick the hardware wallet into signing a transaction with mismatched blinding data.

AI review queuedsign_tx: rename get_commitments_data and document itby Jon Griffiths · 7bd2fba9 · Sep 4, 2025 · 3 filesMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_tx: rename get_commitments_data and document it

Moves the proof validation call so we don't need to forward declare it.

No functional changes.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit renames a function from get_commitment_data to params_commitment_data, moves a helper function earlier in the file to remove a forward declaration, and adds documentation comments. The commit message explicitly states there are no functional changes, and the diff shows only renaming, reordering, and comment additions with no logic changes.

AI review queuedsign_tx: remove blind proofs from commitment databy Jon Griffiths · 85de91d5 · Sep 4, 2025 · 2 filesMessage 68 · AdequateLow 25Details
Commit message · Jon Griffiths

sign_tx: remove blind proofs from commitment data

As with the asset and value commitments, these are not required once the
commitment data has been validated.

Re-order the commitment struct members to further lower the memory size
required to hold commitments.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit reorganizes how a hardware wallet stores temporary blinding proofs while validating a confidential transaction. It moves large proof data out of a small 'commitment' structure into a larger extended structure, and only copies the smaller validated data back to the caller. The stated goal is to reduce memory use, not to fix a security bug. There is no direct evidence in the commit that this prevents an exploitable vulnerability, but memory handling changes in security-critical code always warrant careful review.

AI review queuedsign_tx: move sign_liquid_tx.c to sign_utils.cby Jon Griffiths · c6395cca · Sep 4, 2025 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_tx: move sign_liquid_tx.c to sign_utils.c

Note there are no other changes, for easy review.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a pure file rename: the contents of sign_liquid_tx.c were moved unchanged into a new file called sign_utils.c, and the build include list in amalgamated.c was updated accordingly. The diff shows exactly the same 649 lines deleted and added with no functional changes. There is no security-relevant change.