What the developer wrote
Authored by Jon Griffiths
quirc: fix compiler warning
What changed, and why it matters
This commit only swaps the order of two C keywords ('const static' becomes 'static const') and adds a missing newline at the end of a file. It is a cosmetic/compiler-warning fix with no functional or security change.
No security action needed; treat as routine code-quality cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff in components/esp32-quirc/lib/decode.c changes ‘const static struct galois_field gf256’ to ‘static const struct galois_field gf256’, which is semantically identical in C and only silences a style/compiler warning. It also adds a trailing newline. No logic, memory layout, or behavior changes.
Changed components
components/esp32-quirc/lib/decode.cInspect captured patch +2 / −2
diff --git a/components/esp32-quirc/lib/decode.c b/components/esp32-quirc/lib/decode.c
index 053f0df..c49dcf1 100644
--- a/components/esp32-quirc/lib/decode.c
+++ b/components/esp32-quirc/lib/decode.c
@@ -113,7 +113,7 @@ static const uint8_t gf256_log[256] = {
0x4f, 0xae, 0xd5, 0xe9, 0xe6, 0xe7, 0xad, 0xe8,
0x74, 0xd6, 0xf4, 0xea, 0xa8, 0x50, 0x58, 0xaf};
-const static struct galois_field gf256 = {
+static const struct galois_field gf256 = {
.p = 255,
.log = gf256_log,
.exp = gf256_exp};
@@ -970,4 +970,4 @@ quirc_decode_error_t quirc_decode(const struct quirc_code *code,
}
return QUIRC_SUCCESS;
-}
\ No newline at end of file
+}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.