BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

557 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

120security candidates80second-pass queue462AI analyses
0commits · 30 days
47commits · 60 days
209commits · 180 days
423commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
37Strong · 80–100
204Adequate · 60–79
275Thin · 40–59
41Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths32663289157
Mike Tolkachev541744153
Daniel Newton902078055
Mihailo Milenkovic878057
roderico633074
Valerio Vaccaro2226056
Jamie C. Driver525053
Gustavo Cateim917078
Austin-Fulbright414060
kkdao211068
quantpoet111072
cmiguelrn111045
Analysis record

Published AI watches

Last scanned 42 minutes ago

Moderate 57 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: whitelist reply message function calls

This commit adds a whitelist of approved functions that can be used when sending reply messages from the Jade hardware wallet to a connected computer or phone. Previously, any function could be passed in, which could allow a bug or malicio…

Function-pointer whitelist added to reply pathMultiple static reply helpers made global to enable whitelist comparisonAssertion tightened to validate callback before use
a59d14c2by Jon Griffiths+53−1513 files
No security note in commit
Low 42 AI analysisMessage 30 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

temporary_stack: whitelist temporary task function calls

This commit adds a whitelist to a special helper that lets certain functions run with extra memory stack space. Previously, any function could be passed to this helper. Now only a small list of approved functions is allowed, except during …

Addition of function-pointer whitelistRemoval of static linkage on internal functions to enable whitelist comparisonConditional bypass of whitelist only for debug/selfcheck builds
6a0fea51by Jon Griffiths+26−54 files
No security note in commit
Informational 15 AI analysisMessage 43 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

consistency: fix typos

This commit is a large typo-fixing cleanup across 40 files. Almost every change corrects spelling mistakes in code comments, variable names, or user-facing text strings. There is no change to program logic, security behavior, or cryptograp…

251f7713by Jon Griffiths+96−9640 files
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: document get_bip85_bip39_entropy

This commit only updates documentation and removes a single comment line. It documents an existing feature that lets a user request encrypted BIP85-based BIP39 entropy from the Jade hardware wallet after on-device confirmation. There is no…

05a578adby Jon Griffiths+52−12 files
No security note in commit
Low 28 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

bip85: expose get_bip85_bip39_entropy over rpc in addition to qr

This commit moves a feature that derives BIP85 BIP39 entropy from being available only in debug builds to being available over the normal RPC interface. BIP85 lets a hardware wallet derive child seed phrases from a master seed. Making this…

Feature moved from debug-only to production RPC surfaceNo accompanying access-control or input-sanitization changes visible in diffBIP85 entropy derivation is a sensitive cryptographic operation
c6c5e860by Jon Griffiths+3−41 file
No security note in commit
Informational 19 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

versioninfo: add JADE_INTERFACE field to show which connection source holds the unlocked wallet

This commit adds a new read-only field, JADE_INTERFACE, to the device's version information reply. It simply tells a connected computer which communication path (USB, Bluetooth, QR mode, etc.) currently has control of the unlocked wallet. …

No authentication or authorization logic changedNo cryptographic or key-management code changedNo input parsing or memory-unsafe code added
2fe9df0bby Daniel Newton+66−56 files
No security note in commit
Low 44 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx/sign_psbt: extra check for BTC inputs

This commit adds overflow protection when adding up the total value of Bitcoin transaction inputs in Blockstream Jade's signing code. Previously, the firmware used a plain addition that could silently wrap around if a specially crafted tra…

Integer overflow hardening in financial-amount accumulationDefensive checked_add_uint64() introduced where plain addition existedTransaction signing path now rejects overflowed input totals
41d7e8b4by Daniel Newton+15−32 files
No security note in commit
Informational 19 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: move NVS cache objects that can pin the DRAM heap to SPIRAM if available

This commit changes how the Jade hardware wallet's firmware uses memory. It moves some internal storage cache objects from the main RAM (DRAM) to external RAM (PSRAM/SPIRAM) when available. This is a memory-optimization change, not a direc…

Memory layout change: moves NVS cache from DRAM to SPIRAMNo direct security fix or vulnerability patch present in diffNo mention of CVE, security researcher, or security advisory in commit
329f73c5by Daniel Newton+7−17 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: migrate pin action tests from test_jade to rpc tests

This commit simply moves existing test cases from one test file to another. It does not change any production code, security behavior, or fix any vulnerability. The tests check that the Jade device correctly rejects invalid parameters for …

be0e6b3dby Mike Tolkachev+42−402 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: add tests for pin actions via debug_set_pin

This commit only adds a new test file that exercises PIN-related features of the Jade hardware wallet using a debug-only RPC command. It does not change any production code, introduce new functionality, or alter security behavior. The test…

dd3d5b22by Mike Tolkachev+334−01 file
No security note in commit
Moderate 62 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: require user to permit get_identity_shared_key RPC

This commit adds a user confirmation step before a hardware wallet will share an identity-derived shared secret. Previously, the get_identity_shared_key RPC could compute and return the shared key without the user pressing approve on the d…

RPC that derives/releases a cryptographic shared secret now requires explicit on-device user approvalInput validation added: identity string must be printable before being shown in a security promptNew dedicated accept/reject button event IDs separate this flow from sign_identity
7ca0d26cby Daniel Newton+70−116 files
No security note in commit
Informational 20 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

auth: add unattended pin selection for rpc tests

This commit adds a debug-only feature that lets automated tests set or change the device's PIN over an internal RPC message. It only compiles when special debug flags are enabled and is not present in normal production firmware. The change…

New RPC endpoint debug_set_pin can set/change the unlock PINPIN-handling code path modified to read from a mutable debug context instead of a fixed constantCode is wrapped in CONFIG_DEBUG_UNATTENDED_CI and CONFIG_DEBUG_MODE preprocessor guards
309ee8bbby Mike Tolkachev+100−205 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

pin: disallow pin update on initialized units in debug mode

This commit removes a special debug-only exception that previously allowed the PIN server's public key to be changed on a Jade hardware wallet that already had a wallet set up. In normal operation, changing this public key on an initialize…

Removal of debug-mode bypass for a security-critical authorization checkProtection against pinserver public key substitution on initialized devicesDefense-in-depth for wallet PIN/server trust binding
a5667efdby Jon Griffiths+1−31 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: fix mnemonic handling following seed changes

This commit only changes test code for the Blockstream Jade hardware wallet. It fixes how tests set and reset the device mnemonic/seed so tests run correctly after earlier seed-handling changes. There is no change to the actual wallet firm…

85e87d4eby Jon Griffiths+32−377 files
No security note in commit
Low 32 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

malloc_ext: fix JADE_CALLOC_DRAM

This commit fixes a macro definition for a memory-allocation helper. The macro was accidentally written to take only one argument ('size') even though the underlying function it calls needs two arguments ('number of items' and 'size of eac…

Memory-allocation wrapper macro arity mismatch fixedPotential for undefined behavior if mismatched macro were usedNo explicit security claim or CVE referenced in commit
828835ccby Daniel Newton+1−11 file
No security note in commit
Low 43 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: fix reply count for exact chunk sizes

This commit fixes a bug in how Blockstream Jade counts the number of message chunks needed to send back a signed Bitcoin transaction (PSBT). When the transaction size was an exact multiple of the chunk size, the device told the host there …

Integer division off-by-one in chunk/message countDevice abort on assertion when host requests non-existent chunkDenial-of-service-like symptom: valid signing flow can crash the device
4f1a1565by kkdao+38−22 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: allow tapping directly on touchscreen elements

This commit adds a new touchscreen mode for some Jade hardware wallets where users can tap on-screen buttons directly instead of only using the three virtual buttons below the screen. To reduce the risk of accidental or malicious confirmat…

New direct-touch input path added to GUI event handlingCritical-action buttons require long-press to mitigate stray or coerced tap confirmationsDestructive operations (reset, delete wallet, delete OTP) converted to critical yes/no prompts
a46aa30aby Bota+206−1111 files
Vendor flagged security relevance
Informational 13 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

urldecode: use plain strlen in self-tests of libjade

This commit only changes the internal test file for a URL-decoding helper. It swaps a custom string-length macro for the standard C strlen() function inside test data. The actual product code that users rely on is not changed, and there is…

b39a7a20by Mike Tolkachev+27−291 file
No security note in commit
Moderate 50 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: support tickers up to 24 characters

This commit updates the Blockstream Jade hardware wallet to support longer asset tickers (up to 24 characters) and adds validation to reject malformed tickers. It also fixes a potential display bug where a ticker longer than 8 characters c…

Buffer size increased from 8 to 25 bytes to match new ticker maximumNew input validation added for asset ticker length and character setsnprintf precision argument cast from size_t to int to avoid undefined behavior on some platforms
cc5859a6by Mike Tolkachev+36−53 files
No security note in commit
Low 29 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve empty ticker support

This commit hardens how the Blockstream Jade hardware wallet handles assets that have no ticker symbol. Previously, if an asset's ticker was missing (NULL), the code could pass a NULL pointer to string-length functions, which can cause cra…

NULL-pointer dereference risk in asset ticker handlingDefensive null-check added before strlen()New test fixture for NULL ticker asset path
9d0d74d0by Mike Tolkachev+30−23 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityci: fix dev config file referencesby Jon Griffiths · 70664e4c · Oct 23, 2025 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · Jon Griffiths

ci: fix dev config file references

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This is a one-line fix to a GitLab CI configuration file. It changes the path used to copy a default developer build configuration file so the CI pipeline can find the correct file. There is no indication this affects the security of the Jade firmware or user funds.

Lower-priorityusb: refactor the ota data loopby Jon Griffiths · e260f656 · Oct 23, 2025 · 1 fileMessage 68 · AdequateLow 31Details
Commit message · Jon Griffiths

usb: refactor the ota data loop

- Allow parallelism by waiting on the previous data packet not the current one
- Handle scenarios where the ota process stops responding to our messages
- Clean up error handling to simplify the loop logic.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 31/100

This commit refactors the code that handles firmware updates over USB on the Blockstream Jade hardware wallet. The main goal is to make the update process more robust: it now waits for replies from the update process in a more sensible order, adds a timeout so the device doesn't get stuck forever if the update process stops responding, and cleans up error handling. There is no direct evidence in the commit that this fixes a specific security vulnerability, but it does remove risky behaviors like infinite waits and improves reliability during a sensitive operation (firmware updates).

Lower-priorityusb: don't hold the callback mutex during the callbackby Jon Griffiths · 21229c99 · Oct 23, 2025 · 1 fileMessage 73 · AdequateLow 44Details
Commit message · Jon Griffiths

usb: don't hold the callback mutex during the callback

Note that the callback is called via trigger_event() from a single thread
only and so holding the mutex while calling it is pointless. If the callback
triggers code which attempts to unset the callback (for example, during error
handling), then this will deadlock.

Instead, use the mutex only to protect reading and writing the callback and
context variables themselves.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 44/100

This commit fixes a potential deadlock in the Blockstream Jade hardware wallet's USB mass-storage code. Previously, a protective lock was held while calling a user-provided callback function. If that callback tried to unregister itself (for example, during error handling), it would wait forever for the lock that was already held, freezing the USB task. The fix copies the callback details under the lock, releases the lock, and only then invokes the callback. It is a reliability and availability fix, not a direct theft-of-funds bug, but deadlocks in a hardware wallet's USB path can affect device responsiveness and error recovery.

Lower-priorityusb: rename the interface mutex to reflect it is a mutexby Jon Griffiths · 25598dc3 · Oct 23, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Jon Griffiths

usb: rename the interface mutex to reflect it is a mutex

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is purely a rename: a variable called 'interface_semaphore' is renamed to 'interface_mutex' throughout the code because it is actually a mutex, not a semaphore. No behavior changes, no security fix.

Lower-priorityusb: delete impossible-to-reach codeby Jon Griffiths · d550d332 · Oct 23, 2025 · 1 fileMessage 45 · ThinInformational 12Details
Commit message · Jon Griffiths

usb: delete impossible-to-reach code

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 12/100

This commit removes four lines of code from the USB mass-storage handling task. The deleted branch checked for two event flags that the surrounding logic already handles earlier, so it could never actually run. There is no indication this change fixes a security bug; it is a routine cleanup of dead code.

Lower-priorityusb: set event bits atomicallyby Jon Griffiths · 53bc9c8d · Oct 23, 2025 · 1 fileMessage 45 · ThinLow 31Details
Commit message · Jon Griffiths

usb: set event bits atomically

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 31/100

This commit fixes a small race condition in how USB event flags are set. Previously, two related event flags could be set in separate, non-atomic calls, meaning an observer might see only one flag update and miss the other. The patch combines the flags and sets them in a single atomic operation, ensuring consistent state. There is no direct evidence this is exploitable for security harm, but race conditions in event handling can theoretically lead to inconsistent USB host state.

Lower-prioritydescriptor: early-reject descriptors with too many signersby Jon Griffiths · 72cc31db · Oct 23, 2025 · 2 filesMessage 50 · ThinModerate 59Details
Commit message · Jon Griffiths

descriptor: early-reject descriptors with too many signers

Reported-by: DARKNAVY <X@DarkNavyOrg>

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 59/100

This update fixes a boundary check in how Blockstream Jade handles wallet descriptors (the instructions that say how many keys are needed to spend funds). Previously, the device accepted descriptors with one more signer than its internal limit, which could cause memory corruption or unexpected behavior. The fix rejects oversized descriptors earlier and adds tests to confirm the boundary.

AI review queuedtext fixesby Daniel Newton · 1f9b4b86 · Oct 22, 2025 · 2 filesMessage 0 · OpaqueInformational 15Details
Commit message · Daniel Newton

text fixes

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only fixes a few on-screen text labels and messages. It changes phrases like 'Setup Jade' to 'Set Up Jade', 'temporarily login using' to 'temporarily log in with', and 'Logout' to 'Log Out'. There are no code logic, security, or functional changes.

Lower-priorityusb: only set the usb connect activity when it is initially createdby Jon Griffiths · dfcb0fb1 · Oct 21, 2025 · 1 fileMessage 65 · AdequateInformational 16Details
Commit message · Jon Griffiths

usb: only set the usb connect activity when it is initially created

its already re-set for us after help is shown.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 16/100

This is a small user-interface fix in Blockstream Jade's USB storage mode. It moves one line of code so that the 'please plug in USB device' screen is only set as the current screen when it is first created, not repeatedly every time the code checks for events. The change appears to prevent the screen from being reset/redrawn unnecessarily after help text is shown. There is no direct evidence in the commit that this is a security fix.

Lower-priorityUpdate readme to show all dependencies needed to run test_jade.pyby Daniel Newton · 24deb001 · Oct 20, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Daniel Newton

Update readme to show all dependencies needed to run test_jade.py

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates the README.md file to add clearer instructions for installing test dependencies (virtualenv, bluez-tools, and an additional requirements file). It is purely a documentation change with no code modifications.

Lower-priorityusb: increase timeout to detect slower usb storage devicesby Daniel Newton · 1ff0e587 · Oct 15, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Daniel Newton

usb: increase timeout to detect slower usb storage devices

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply waits longer (about 3 seconds instead of 1 second) before showing a 'please insert USB device' prompt when a user plugs in a slow USB storage device. It is a usability fix, not a security fix.

Lower-priorityusb: remove need to unplug usb storage device to finish unloading usb libsby Daniel Newton · e48b0146 · Oct 15, 2025 · 1 fileMessage 50 · ThinInformational 16Details
Commit message · Daniel Newton

usb: remove need to unplug usb storage device to finish unloading usb libs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit fixes a small user-experience bug in how Blockstream Jade's USB storage feature shuts down. Previously, the device had to wait for the user to physically unplug the USB storage device before it could finish turning off its USB libraries. The change now actively cuts power to the connected USB device so the software can detect it as 'unplugged' and complete cleanup automatically. There is no direct security vulnerability here; it is a robustness/usability improvement.

Lower-priorityusb: dont create background task for msc_host_installby Daniel Newton · ea5b2fd7 · Oct 15, 2025 · 1 fileMessage 50 · ThinInformational 20Details
Commit message · Daniel Newton

usb: dont create background task for msc_host_install

Eliminates the "Processing..." freeze.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 20/100

This commit changes how Blockstream Jade handles USB mass-storage events. Previously, a separate background task was created to process USB events, which caused a visible "Processing..." freeze on the device. The fix moves event handling into the existing task and makes it run in smaller, more frequent chunks. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a user-experience and stability improvement.

Lower-priorityusb: add visual logging system to usb storage code for debuggingby Daniel Newton · 9e7f4ba3 · Oct 15, 2025 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Daniel Newton

usb: add visual logging system to usb storage code for debugging

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds extra on-screen logging and debugging messages for the USB storage feature. It does not change how the device protects keys or data, and it does not fix or introduce a security vulnerability. The new logging is disabled by default.

Security candidatebuild: further verify signature digests in signed v2 binariesby Jon Griffiths · 690c8b1c · Oct 14, 2025 · 1 fileMessage 77 · AdequateLow 42Details
Commit message · Jon Griffiths

build: further verify signature digests in signed v2 binaries

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Low 42/100

This change tightens a build-time signing script for Blockstream Jade hardware wallet firmware. It adds checks that the public-key digests recorded inside a signed binary match the digests of the keys that were actually used to sign it, and makes the script stop on any error. The patch is defensive: it reduces the chance that a corrupted or wrongly-signed firmware image is produced during release, but it does not by itself fix a vulnerability in already-shipped devices.

Security candidatebuild: minor error handling tweak for v2 pem signingby Jon Griffiths · 1d797de3 · Oct 12, 2025 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Jon Griffiths

build: minor error handling tweak for v2 pem signing

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This is a tiny build-script change that replaces a silent failure with a clear error message when required signing key files are missing. It does not change what the script does, only what it prints when it fails. There is no security vulnerability here.

AI review queuedgui: include semphr.hby Jon Griffiths · 6de067ff · Oct 9, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Jon Griffiths

gui: include semphr.h

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds a single missing header file include for FreeRTOS semaphore functions in the GUI source file. It is a straightforward build fix with no visible security relevance in the diff or commit message.

Lower-prioritycbor: avoid passing null to memcpy with len 0 in tinycborby Jon Griffiths · 22af7035 · Oct 8, 2025 · 1 fileMessage 50 · ThinLow 31Details
Commit message · Jon Griffiths

cbor: avoid passing null to memcpy with len 0 in tinycbor

Found by asan.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 31/100

This commit fixes a low-level memory-handling issue in Blockstream Jade's CBOR encoding helper. When adding an empty byte string to a data map, the code previously could pass a null pointer to a memory-copy routine. The fix substitutes a dummy non-null pointer when the data length is zero, avoiding undefined behavior detected by AddressSanitizer. It is a defensive hardening change rather than a confirmed exploitable vulnerability.

Security candidateotp: avoid signed left shiftby Jon Griffiths · 7c8fd718 · Oct 8, 2025 · 1 fileMessage 45 · ThinLow 32Details
Commit message · Jon Griffiths

otp: avoid signed left shift

Found by ubsan.

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 32/100

This commit fixes a subtle programming bug in the code that decodes base32 one-time-password (OTP) secrets. The bug involves shifting a signed integer left, which is undefined behavior in C and was caught by an undefined-behavior sanitizer. The fix changes the variable from a signed integer to an unsigned integer so the shift is well-defined. The practical security impact is likely low, but undefined behavior in cryptographic/OTP handling is generally undesirable because compilers may optimize it unpredictably.

Lower-prioritychange QR scan box to use the largest centered square of the camera image (minus a small margin)by Daniel Newton · 719fa40c · Oct 7, 2025 · 3 filesMessage 50 · ThinInformational 13Details
Commit message · Daniel Newton

change QR scan box to use the largest centered square of the camera image (minus a small margin)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 13/100

This commit changes how the QR code scanning box is sized on the Blockstream Jade hardware wallet. Previously, the scan area was based on how much of the camera image was shown on the device's screen plus a small extra margin. Now it uses the largest centered square that fits in the full camera image, minus a small margin. This is a UI/behavior adjustment, not a security fix.

Security candidateUpdate python/pinserver libwally to 1.5.1by Jon Griffiths · 5e5df8c9 · Sep 29, 2025 · 2 filesMessage 45 · ThinLow 25Details
Commit message · Jon Griffiths

Update python/pinserver libwally to 1.5.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 25/100

This commit simply updates a dependency called 'wallycore' used by the Blockstream Jade PIN server from version 1.4.0 to 1.5.1. It changes the version number and the list of cryptographic fingerprints (hashes) that verify the downloaded package. The commit message does not say why the update was made or whether it fixes any security issue. Without knowing what changed between 1.4.0 and 1.5.1, we cannot tell if this is a routine maintenance update or a security fix.

Security candidatepsbt: allow pset signing from usb/qrcodesby Jon Griffiths · 4fc854e9 · Sep 29, 2025 · 3 filesMessage 45 · ThinLow 30Details
Commit message · Jon Griffiths

psbt: allow pset signing from usb/qrcodes

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 30/100

This commit lets a Blockstream Jade hardware wallet automatically detect whether a transaction file is for Bitcoin or the Liquid sidechain (including test networks) when signing via QR codes or USB. Before, the wallet always assumed Bitcoin, which could cause it to fail or behave incorrectly when signing a Liquid transaction through those offline methods. The change itself is a feature fix and does not appear to introduce a security vulnerability.

Lower-priorityqr: Show brightness controls when displaying animated qrcodesby Jon Griffiths · b9cc4c24 · Sep 29, 2025 · 4 filesMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

qr: Show brightness controls when displaying animated qrcodes

Simplify the associated code since we no longer display a help button
outside of the options section.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a straightforward user-interface change for Blockstream Jade hardware wallets. It replaces a 'help' button with a 'brightness' button on QR code display screens and removes the now-unused help button code. There is no security-relevant change visible in the diff.

Lower-priorityqr: display the parent activity help when showing qr display optionsby Jon Griffiths · 7cb95d4a · Sep 29, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Jon Griffiths

qr: display the parent activity help when showing qr display options

Previously this would show help for blkstrm.com/scanjade - which is not
useful when the user is displaying (and not scanning) a qrcode.

Instead, show the help associated with the parent activity where the
options button was selected from.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit fixes a user-interface help link in a QR code display menu. Previously, pressing the help button while viewing options for a displayed QR code would open a help page about scanning QR codes (blkstrm.com/scanjade), which is the opposite of what the user is doing. Now it opens the help page for the screen the user came from. There is no security issue here.

Security candidatebuild: fail if any step of signing v2 firmwares failsby Jon Griffiths · edc17778 · Sep 29, 2025 · 1 fileMessage 62 · AdequateLow 34Details
Commit message · Jon Griffiths

build: fail if any step of signing v2 firmwares fails

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 34/100

This commit hardens the firmware signing script used when releasing Blockstream Jade hardware wallet firmware. It adds `set -e` so the script stops immediately if any command fails, and explicitly checks that the public and private key files exist before proceeding. Without these changes, the script could silently continue past errors (for example, if a key file was missing or a signing command failed), potentially producing or releasing firmware that was not properly signed. Proper signing is important because users rely on firmware signatures to verify that the software running on their device is authentic and has not been tampered with.