qr: display the parent activity help when showing qr display options
What the developer wrote
Authored by Jon Griffiths
qr: display the parent activity help when showing qr display options
Previously this would show help for blkstrm.com/scanjade - which is not
useful when the user is displaying (and not scanning) a qrcode.
Instead, show the help associated with the parent activity where the
options button was selected from.
What changed, and why it matters
This commit fixes a user-interface help link in a QR code display menu. Previously, pressing the help button while viewing options for a displayed QR code would open a help page about scanning QR codes (blkstrm.com/scanjade), which is the opposite of what the user is doing. Now it opens the help page for the screen the user came from. There is no security issue here.
No security action needed. Treat as a normal UI fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change updates handle_qr_options() in main/qrmode.c to accept a help_url parameter and pass it to await_qr_help_activity() instead of the hardcoded ‘blkstrm.com/scanjade’ URL. The call site in display_bcur_qr() now passes the parent activity’s help_url. This is a UI/UX correction with no security-relevant code changes.
Changed components
main/qrmode.cInspect captured patch +3 / −3
diff --git a/main/qrmode.c b/main/qrmode.c
index 2111818..34c3b7f 100644
--- a/main/qrmode.c
+++ b/main/qrmode.c
@@ -826,7 +826,7 @@ static bool verify_address(const address_data_t* const addr_data)
}
// Handle QR Options dialog - ie. QR size and frame-rate
-static bool handle_qr_options(uint32_t* qr_flags)
+static bool handle_qr_options(uint32_t* qr_flags, const char* help_url)
{
JADE_ASSERT(qr_flags);
@@ -886,7 +886,7 @@ static bool handle_qr_options(uint32_t* qr_flags)
}
update_menu_item(framerate_item, "Frame Rate", qr_framerate_desc_from_flags(*qr_flags));
} else if (ev_id == BTN_QR_OPTIONS_HELP) {
- await_qr_help_activity("blkstrm.com/scanjade");
+ await_qr_help_activity(help_url);
} else if (ev_id == BTN_QR_OPTIONS_EXIT) {
// Done
break;
@@ -953,7 +953,7 @@ static void display_bcur_qr(const char* message[], const size_t message_size, co
const int32_t ev_id = gui_activity_wait_button(act, BTN_QR_DISPLAY_EXIT);
if (ev_id == BTN_QR_OPTIONS) {
- if (handle_qr_options(&qr_flags)) {
+ if (handle_qr_options(&qr_flags, help_url)) {
// Options were updated - re-create psbt qr screen
display_processing_message_activity();
act = create_display_bcur_qr_activity(
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.