BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

414 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

93security candidates58second-pass queue155AI analyses
10commits · 30 days
67commits · 60 days
198commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
32Strong · 80–100
147Adequate · 60–79
203Thin · 40–59
32Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths2755292157
Mike Tolkachev311117155
Daniel Newton651525055
Mihailo Milenkovic878057
Jamie C. Driver525053
Gustavo Cateim712079
Austin-Fulbright411060
cmiguelrn111045
quantpoet111072
roderico111045
tokyovyse111063
Valerio Vaccaro200045
Analysis record

Published AI watches

Last scanned 24 minutes ago

Informational 15 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

hardware: add Jade Plus design files

This commit reorganizes existing hardware design files for the original Jade device into a new subfolder and adds the open-source hardware design files for a new product, the Jade Plus. It does not change any software, firmware, or device …

5ad85661by bitcoinhelp+2573−122520 files
No security note in commit
Low 26 AI analysisMessage 100 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

power: release PMU devices before deleting the i2c bus on M5CoreS3

This commit fixes a boot failure on the M5CoreS3 hardware. A recent update to the underlying Espressif SDK (ESP-IDF v5.5) changed the rules for deleting an I2C bus: it now refuses to delete a bus that still has devices attached. The power …

fb3a009aby Gustavo Cateim+3−01 file
No security note in commit
Low 27 AI analysisMessage 86 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

input: release touch handles before deleting the i2c bus

This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR …

Device freeze/DoS-like symptom on affected hardwareMemory leak fixedNo input validation, authentication, or cryptographic weakness visible
36776fecby Gustavo Cateim+3−01 file
No security note in commit
Informational 15 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

jade_cli: add selfcheck command

This commit adds a new command-line command called 'selfcheck' to the Jade CLI tool. It simply calls an existing device function and prints the result. There is no indication of a security fix or vulnerability being patched.

32d3c9a7by Jon Griffiths+10−01 file
No security note in commit
Low 42 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Liquid (taproot): add sign_liquid_tx genesis blockhash support

This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test n…

Adds input validation for caller-supplied genesis blockhashPrevents mainnet genesis hash from being used on Liquid test networksRestricts genesis_hash parameter to Liquid networks only
888eff30by Jon Griffiths+82−264 files
No security note in commit
Low 48 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: annotate functions returning error codes to ensure they are checked

This commit adds compiler annotations (WARN_UNUSED_RESULT) to functions that return success/failure codes, so the compiler will warn if a caller ignores the result. It also fixes a few places where return values were being ignored, replaci…

Functions returning error/success codes annotated with WARN_UNUSED_RESULTCallers now check return values of rpc_get_bip32_path() and rpc_get_boolean()Use of default-value helpers (rpc_get_boolean_or) to ensure predictable behavior on missing fields
517075baby Mike Tolkachev+24−215 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: rename get_uint64_t to get_uint64

This commit simply renames an internal helper function from `rpc_get_uint64_t` to `rpc_get_uint64` and updates every place that calls it. There are no changes to what the function does, how it checks data, or how secure it is. It is a rout…

8e0de45eby Jon Griffiths+11−117 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: rename get_boolean to get_bool

This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and…

f6e946acby Jon Griffiths+24−2518 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: refactor app code to use getters with default values

This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visibl…

b6a07147by Mike Tolkachev+22−348 files
No security note in commit
Moderate 59 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve precision checking

This commit tightens how Blockstream Jade handles the 'precision' value in asset contracts for Liquid assets. Previously, a very large precision value could be accepted and later used to read past the end of an internal lookup table (POW_1…

Out-of-bounds read mitigation: bounds-checking of user-controlled precision before indexing fixed-size POW_10 arrayInteger truncation safety: explicit cast of validated precision to uint8_t after range checkCompile-time invariant enforcement: JADE_STATIC_ASSERT ties array size to ASSET_PRECISION_MAX
fd0f625dby Mike Tolkachev+13−13 files
No security note in commit
Informational 15 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docker: update jade_builder

This commit simply updates the SHA256 digest of the 'blockstream/jade_builder' Docker image used for building and testing Jade in four configuration files. There is no code change, no disclosed security fix, and no evidence in the commit o…

00e7a397by Jon Griffiths+5−54 files
No security note in commit
Low 40 AI analysisMessage 78 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

libjade: add camera/input/nvs support, refactor

This commit is a large feature/refactor patch for Blockstream Jade's libjade (a desktop emulator of the Jade hardware wallet). It adds RPC endpoints that let a host application read the emulated device's screen, push fake button presses, r…

New RPC endpoints allow external read/write of emulated NVS storageNew RPC endpoints allow external screen capture and synthetic input injectionNew RPC endpoints allow external camera frame injection
f7184945by Daniel Newton+1806−75832 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Fix M5StickC Plus 2 PIN navigation

This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry con…

9de1409eby roderico+3−21 file
No security note in commit
Low 36 AI analysisMessage 74 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: annotate functions returning error codes to ensure they are checked

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch futur…

Compiler annotation added to enforce checking of error-returning functionsNo specific vulnerability fixed in the diffNo functional code changes or call-site fixes included
909a89aaby Mike Tolkachev+215−15225 files
No security note in commit
Low 46 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

identity: add identity string validation

This commit adds a safety check to Blockstream Jade's 'sign identity' feature. Before the change, the device would accept any identity string a connected app sent. Now it rejects identities that contain non-printable or unusual characters.…

Input validation added to a signing/identity processNew length-bounded string helper reduces reliance on null-terminationRejection of non-printable characters in user-presented identity string
53752b98by Mike Tolkachev+22−02 files
No security note in commit
Informational 22 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

otp: show error on invalid issuer, share logging strings

This commit tightens error handling when decoding the 'issuer' field of an OTP (one-time password) setup URI. Previously, a malformed issuer string could fail to decode silently; now the device shows an error and cancels the operation inst…

Input validation added for OTP URI issuer fieldSilent failure on malformed URL-decoding replaced with explicit error returnDebug assertion added for label/issuer URL-decoding in UI display path
66c945f2by Mike Tolkachev+9−52 files
No security note in commit
Low 42 AI analysisMessage 28 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: fix path size

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how t…

Buffer-size semantic mismatch in security-critical PSBT parsingUse of sizeof() on uint32_t array where element count is expectedCode path involved in 2of3 multisig recovery key identification
9e0c3747by Mike Tolkachev+2−21 file
No security note in commit
Moderate 57 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign: match sign_tx logic for output commitment checking

This commit fixes a logic gap in how Blockstream Jade checks cryptographic commitments for transaction outputs during signing. Previously, the code treated a missing commitment the same as an invalid one, which could cause the device to re…

Inconsistent commitment validation between signing code pathsPossible transaction signing failure or acceptance of unvalidated output commitmentsLogic alignment with existing sign_tx commitment handling
be05deacby Jon Griffiths+5−21 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

utils: fix params_additional_info return type

This commit changes the declared return type of a transaction-signing helper function from a transaction-type code (TxType_t) to a simple success/fail boolean (bool). The function body already appears to return true/false, so the change fi…

Return-type mismatch between function declaration/definition and headerFunction is in transaction-signing utility code (sign_utils.c/h)Function handles CBOR transaction parameters and writes output transaction metadata
3d6cdbcbby Jon Griffiths+2−22 files
No security note in commit
Moderate 61 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

url: improve bounds checking

This commit tightens bounds checks in URL encoding/decoding functions used in Blockstream Jade, a hardware wallet. The changes fix potential off-by-one/out-of-bounds memory reads and writes when handling percent-encoded characters. Because…

Bounds-check rewrite in URL decoder to prevent out-of-bounds reads before percent-decodingCast to unsigned char moved into isxdigit() to avoid undefined behavior with signed char inputsDestination bounds checks in URL encoder changed from pointer-subtraction form to remaining-space form, mitigating possible underflow/wrap
c045aeacby Mike Tolkachev+5−71 file
Vendor flagged security relevance
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritytests: expect pset failures on non-psram devicesby Jon Griffiths · 1d9d2c9f · Sep 4, 2025 · 1 fileMessage 90 · StrongTriage 0Details
Commit message · Jon Griffiths

tests: expect pset failures on non-psram devices

Because the message stream desyncs when we send too large a message,
skip tests for unsupported config entirely (until a robust workaround is
available for this issue generally).

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Security candidatejadepy: allow additional_info for sign_psbtby Jon Griffiths · 04467ee6 · Sep 4, 2025 · 1 fileMessage 45 · ThinInformational 21Details
Commit message · Jon Griffiths

jadepy: allow additional_info for sign_psbt

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 21/100

This commit updates the Python library that talks to the Blockstream Jade hardware wallet. It lets callers pass an optional extra data dictionary called additional_info when signing a Bitcoin PSBT, matching a feature already available for Liquid transactions. The change itself just forwards the new parameter to the device; it does not appear to fix or introduce a vulnerability on its own.

Lower-priorityjadepy: avoid expensive message formatting for lines that won't be loggedby Jon Griffiths · 52fddaa3 · Sep 4, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

jadepy: avoid expensive message formatting for lines that won't be logged

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritywally: update to latest wally masterby Jon Griffiths · 3d59a7a4 · Sep 4, 2025 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths

wally: update to latest wally master

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritytests: add a singlesig swap testby Jon Griffiths · e876dcfe · Sep 4, 2025 · 1 fileMessage 55 · ThinTriage 0Details
Commit message · Jon Griffiths

tests: add a singlesig swap test

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Security candidatesign_psbt: disable pset parsing on non-psram devicesby Jon Griffiths · 3acf125d · Sep 4, 2025 · 1 fileMessage 50 · ThinLow 40Details
Commit message · Jon Griffiths

sign_psbt: disable pset parsing on non-psram devices

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 40/100

This commit blocks PSET (a privacy-enhanced Bitcoin transaction format) parsing on Blockstream Jade hardware wallets that lack extra RAM (SPIRAM). The change prevents the device from running out of memory while handling complex PSET data. It is a hardening/defensive fix rather than a clear exploit patch, because the commit message and diff do not describe an actual vulnerability—only a known resource limitation.

Security candidatetests: pass through additional_info if provided for psbt/pset signingby Jon Griffiths · dfd55895 · Sep 4, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

tests: pass through additional_info if provided for psbt/pset signing

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only changes test code. It makes the test helper pass an optional 'additional_info' field through to the sign_psbt() function when it is present in test cases. There is no change to the actual signing code or wallet behavior, so it does not create or fix a security vulnerability.

Security candidatesign_tx: split out updating output info from validating itby Jon Griffiths · 3f1b2feb · Sep 4, 2025 · 3 filesMessage 73 · AdequateInformational 11Details
Commit message · Jon Griffiths

sign_tx: split out updating output info from validating it

Removes some confusion from having validation change the data, but
primarily this will allow psbt signing to share the output validation
code without using the commitment update code (since pset commitments
are validated already during parsing and not passed separately like the
sign_tx case).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Informational 11/100

This commit is a code cleanup in the transaction signing logic for Blockstream Jade hardware wallets. It splits one function into two: one that gathers output information and another that validates it. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a refactoring to make the code clearer and to allow future reuse in PSBT signing.

AI review queuedsign_tx: return the error message when additional_info parsing failsby Jon Griffiths · 3a8f6095 · Sep 4, 2025 · 4 filesMessage 50 · ThinInformational 18Details
Commit message · Jon Griffiths

sign_tx: return the error message when additional_info parsing fails

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit fixes a minor user-experience and diagnostic issue in Blockstream Jade's transaction signing code. Previously, when the optional 'additional_info' block for Liquid transactions could not be parsed or validated, the device rejected the request without telling the caller exactly what went wrong. After the patch, the specific error message is passed back to the caller. There is no direct evidence this change fixes an exploitable security vulnerability.

Lower-prioritypset: add liquid singlesig testsby Jon Griffiths · cb0af490 · Sep 4, 2025 · 5 filesMessage 70 · AdequateTriage 0Details
Commit message · Jon Griffiths

pset: add liquid singlesig tests

Covers all supported singlesig input/address types including taproot.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Security candidatesign_psbt: check and provide genesis blockhash for psets per ELIP-0101by Jon Griffiths · 63f175af · Sep 4, 2025 · 1 fileMessage 83 · StrongLow 43Details
Commit message · Jon Griffiths

sign_psbt: check and provide genesis blockhash for psets per ELIP-0101

Per the ELIP, we must verify the network if present, and add it if
missing when signing (note that it is required for taproot signing).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 43/100

This commit adds checks for the Liquid network's 'genesis blockhash' in a Bitcoin hardware wallet signing flow. It ensures the PSBT (Partially Signed Bitcoin Transaction) includes the correct network identifier before signing, and fills it in if missing. Without this, a specially crafted transaction could potentially trick the device into signing for the wrong Liquid network or into producing invalid Taproot signatures. The change is defensive and aligns with the ELIP-0101 specification.

Security candidatesign_psbt: pass elements flag to signature hash generation for liquidby Jon Griffiths · cc2557bb · Sep 4, 2025 · 1 fileMessage 70 · AdequateModerate 57Details
Commit message · Jon Griffiths

sign_psbt: pass elements flag to signature hash generation for liquid

This is required for taproot, as Elements/Liquid use different hashing
and tweaking strategies in this case.

70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 57/100

This commit fixes how Blockstream Jade signs Liquid (Elements) Taproot transactions. Previously, the device used Bitcoin-style signature hashing for all networks, which is incorrect for Liquid Taproot. The fix passes a special 'Elements' flag when signing on Liquid so the signature hash matches Liquid's rules. Without this, signatures produced for Liquid Taproot transactions would be invalid or could potentially be produced using the wrong cryptographic formula, which in hardware wallets can sometimes lead to security issues like key leakage or signature-forgery attacks.

Security candidatesign_psbt: disallow taproot swapsby Jon Griffiths · a4ea7299 · Sep 4, 2025 · 1 fileMessage 35 · OpaqueHigh 72Details
Commit message · Jon Griffiths

sign_psbt: disallow taproot swaps

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet path
AI analysis · High 72/100

This commit blocks a specific kind of Bitcoin/Liquid transaction signing on the Blockstream Jade hardware wallet. It prevents 'swap' transactions from using 'taproot' inputs because the device's signature-calculation code does not yet safely handle that combination. Without the fix, a user might have been able to build a transaction that the wallet would sign incorrectly or in a way that could be exploited, potentially leading to loss or theft of funds in a swap.

Security candidatesign_psbt: add support for additional_info/swap signingby Jon Griffiths · 2ef105cf · Sep 4, 2025 · 4 filesMessage 85 · StrongLow 35Details
Commit message · Jon Griffiths

sign_psbt: add support for additional_info/swap signing

As with the sign_tx case, we require and validate additional info for
swap signing. As this is not available in PSBT QR codes, swap signing is
not currently available by QR.

Also cleans up the error handling to ensure none of the new structures
are leaked on failure.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Low 35/100

This commit adds Liquid swap signing support for PSBTs in the Blockstream Jade hardware wallet firmware. It also restructures cleanup paths so memory is freed correctly when validation fails. The change is a feature addition with defensive cleanup improvements, not a clear-cut security fix, but it touches code that protects user funds during transaction signing.

Lower-prioritytests: don't fail tx extraction if not all inputs are finalizedby Jon Griffiths · 4685e54f · Sep 4, 2025 · 1 fileMessage 83 · StrongTriage 0Details
Commit message · Jon Griffiths

tests: don't fail tx extraction if not all inputs are finalized

We don't expect multisig or partial swap transactions to be completely
finalized: allow this so we can still reconcile the final tx output
(for example, against core output).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Lower-prioritydocs: document that commitment data must match the tx outputby Jon Griffiths · 20d62a6c · Sep 4, 2025 · 1 fileMessage 62 · AdequateTriage 0Details
Commit message · Jon Griffiths

docs: document that commitment data must match the tx output

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI review queuedsign_tx: remove blind proofs from commitment databy Jon Griffiths · 85de91d5 · Sep 4, 2025 · 2 filesMessage 68 · AdequateLow 25Details
Commit message · Jon Griffiths

sign_tx: remove blind proofs from commitment data

As with the asset and value commitments, these are not required once the
commitment data has been validated.

Re-order the commitment struct members to further lower the memory size
required to hold commitments.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit reorganizes how a hardware wallet stores temporary blinding proofs while validating a confidential transaction. It moves large proof data out of a small 'commitment' structure into a larger extended structure, and only copies the smaller validated data back to the caller. The stated goal is to reduce memory use, not to fix a security bug. There is no direct evidence in the commit that this prevents an exploitable vulnerability, but memory handling changes in security-critical code always warrant careful review.

Security candidatesign_psbt: use the signature type of inputs we are signing instead of a boolby Jon Griffiths · fd4c303a · Sep 4, 2025 · 1 fileMessage 55 · ThinLow 31Details
Commit message · Jon Griffiths

sign_psbt: use the signature type of inputs we are signing instead of a bool

Also drive-by fix a log line.

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 31/100

This commit changes how a Bitcoin hardware wallet (Blockstream Jade) tracks which transaction inputs it needs to sign. Previously it stored a simple yes/no flag; now it stores the actual signature type requested by the PSBT (Partially Signed Bitcoin Transaction). The change is mostly a code-quality improvement, but it removes a place where the wrong signature type could silently be assumed. There is no direct evidence in the commit that an actual vulnerability was fixed, and no vendor security disclosure is present.

Security candidatesign_psbt: assert script taprootyness matches our deduced signature typeby Jon Griffiths · 086fa5da · Sep 4, 2025 · 1 fileMessage 55 · ThinModerate 57Details
Commit message · Jon Griffiths

sign_psbt: assert script taprootyness matches our deduced signature type

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 57/100

This commit adds a safety check in the code that signs Bitcoin transactions. It ensures that when the wallet decides to produce a Taproot-style signature, the script being spent actually looks like a Taproot script, and vice versa. Without this check, a mismatch between the script type and signature type could potentially lead to incorrect signatures or unexpected behavior when signing transactions.

AI review queuedsign_tx: rename get_commitments_data and document itby Jon Griffiths · 7bd2fba9 · Sep 4, 2025 · 3 filesMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_tx: rename get_commitments_data and document it

Moves the proof validation call so we don't need to forward declare it.

No functional changes.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit renames a function from get_commitment_data to params_commitment_data, moves a helper function earlier in the file to remove a forward declaration, and adds documentation comments. The commit message explicitly states there are no functional changes, and the diff shows only renaming, reordering, and comment additions with no logic changes.

Security candidatesign_tx/sign_psbt: share code to validate supported sighash flagsby Jon Griffiths · 6e2a10ca · Sep 4, 2025 · 5 filesMessage 50 · ThinLow 45Details
Commit message · Jon Griffiths

sign_tx/sign_psbt: share code to validate supported sighash flags

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Low 45/100

This commit is a code cleanup that moves the rules for which Bitcoin/Liquid 'sighash' flags are allowed into one shared helper function used by both signing paths. Before, the PSBT signing path only rejected non-ALL sighashes for non-Taproot inputs, while the direct sign_tx path had more detailed rules (for example, allowing SINGLE|ANYONECANPAY for partial Liquid swaps). Unifying the logic reduces the chance that one path accidentally allows a dangerous sighash. The change itself does not add new user-facing behavior; it is defensive hardening/refactoring.

Security candidatesign_psbt: skip inputs we arent signing explicitlyby Jon Griffiths · 6b161dc4 · Sep 4, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_psbt: skip inputs we arent signing explicitly

No functional changes, this just shifts the processing code over instead
of holding open a very large if block.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a pure code-style refactor. It flips a large 'if' block into an early 'continue' so the code inside is no longer deeply indented. The commit message explicitly says there are 'No functional changes'. No security issue is introduced or fixed.

AI review queuedsign_tx: Strengthen liquid commitment checks against the tx being signedby Jon Griffiths · a454d1f4 · Sep 4, 2025 · 6 filesMessage 83 · StrongModerate 59Details
Commit message · Jon Griffiths

sign_tx: Strengthen liquid commitment checks against the tx being signed

This change ensures that the transaction and any commitment values
match, if an asset/value commitment pair are given.

Commitments given as part of tx input data must have these fields, while
they are optional (and should be discouraged) for tx outputs.

We move the validation checking which was spread over several unrelated
areas into the function fetching the commitment data. This ensures that
when fetching it, it is either fully validated from that point on or an
error is returned.

Following this we remove the commitment fields from the commitment_t struct
since they are now redundant for the remainder of sign_tx processing.

From experience debugging tests where the commitments mismatched, the
old error messages were not helpful. Update these to include 'trusted
commitment' in all messages to make it clearer when a mismatch is
detected.

Note This commit is deliberately minimal to make the core logic changes
easier to review.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit hardens how Blockstream Jade validates confidential (blinded) transaction data on Liquid. It moves and strengthens checks so that any asset/value commitment pair supplied by the caller must match the transaction actually being signed, and it removes redundant commitment fields from an internal data structure. The change is defensive: it reduces the chance that a malicious or buggy host could trick the hardware wallet into signing a transaction with mismatched blinding data.

Security candidatesign_psbt: use the psbt tx directly if possibleby Jon Griffiths · 90f16a56 · Sep 4, 2025 · 1 fileMessage 60 · AdequateInformational 24Details
Commit message · Jon Griffiths

sign_psbt: use the psbt tx directly if possible

Since we aren't finalizing the tx, we can use it directly for v0 PSBTs
and avoid creating a new one.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 24/100

This commit changes how a Bitcoin hardware wallet (Blockstream Jade) obtains the transaction it signs from a Partially Signed Bitcoin Transaction (PSBT). For older v0 PSBTs, it now uses the transaction embedded in the PSBT directly instead of extracting a fresh copy. The main risk is that the code now trusts the PSBT's internal transaction more directly, but the commit also adds a safety check that the transaction exists and matches the PSBT's input/output counts. There is no clear security bug visible in the diff, but the change touches sensitive signing logic and is described only as a simplification, not a security fix.

AI review queuedsign_tx: move sign_liquid_tx.c to sign_utils.cby Jon Griffiths · c6395cca · Sep 4, 2025 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_tx: move sign_liquid_tx.c to sign_utils.c

Note there are no other changes, for easy review.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a pure file rename: the contents of sign_liquid_tx.c were moved unchanged into a new file called sign_utils.c, and the build include list in amalgamated.c was updated accordingly. The diff shows exactly the same 649 lines deleted and added with no functional changes. There is no security-relevant change.