qr: inset the qr guides more on Jade v1/v1.1 screens
What the developer wrote
Authored by Daniel Newton
qr: inset the qr guides more on Jade v1/v1.1 screens
What changed, and why it matters
This commit is a minor visual tweak for older Jade hardware wallets. It moves the corner guide lines shown around QR codes slightly farther inward on Jade v1 and v1.1 screens so they don't overlap the edges of the actual QR code. There is no security-relevant change.
No security action needed. Treat as a normal UI/layout fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change adjusts the inset of QR guide markers in render_qrguide() in main/gui.c. For BOARD_TYPE_JADE and BOARD_TYPE_JADE_V1_1, the inset changes from square_size/30 (~3%) to square_size/11 (~9%). Other boards keep the original 3% inset. This is purely a UI/UX adjustment for screen layout on specific hardware variants.
Changed components
main/gui.crender_qrguide()Inspect captured patch +5 / −0
diff --git a/main/gui.c b/main/gui.c
index 673c001..49e7a1a 100644
--- a/main/gui.c
+++ b/main/gui.c
@@ -2080,8 +2080,13 @@ static void render_qrguide(gui_view_node_t* node, const dispWin_t cs, const uint
const uint16_t width = cs.x2 - cs.x1;
const uint16_t height = cs.y2 - cs.y1;
const uint16_t square_size = min_u16(width, height);
+#if defined(CONFIG_BOARD_TYPE_JADE) || defined(CONFIG_BOARD_TYPE_JADE_V1_1)
+ // guides 9% inset
+ const uint16_t inset = square_size / 11;
+#else
// guides 3% inset
const uint16_t inset = square_size / 30;
+#endif
// guide boundaries
const uint16_t left = cs.x1 + (width - square_size) / 2 + inset;
const uint16_t right = cs.x2 - (width - square_size) / 2 - inset;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.