fix(core): remove extra maybe_with_colon from Solana [no changelog]
What the developer wrote
Authored by Michal Kazda
fix(core): remove extra maybe_with_colon from Solana
[no changelog]
What changed, and why it matters
This commit removes an extra colon that was being added to Solana transaction confirmation screens on Trezor devices. The change is cosmetic: it stops showing a duplicate colon in front of property names (like 'Fee payer:' becoming 'Fee payer'). There is no direct evidence in the commit that this fixes a security vulnerability, but user-interface clarity on a hardware wallet can indirectly affect security if a misleading label makes a user approve something they misunderstand.
Treat as a routine UI fix. Include in normal regression testing of Solana transaction confirmation screens. No urgent security response is warranted based solely on this diff, but verify that display_name values already contain the colon so the change does not remove needed punctuation on any device variant.
Security signals we found
UI label formatting correction in transaction confirmation flow
No cryptographic, parsing, or access-control changes
Potential indirect security relevance: unclear labels on hardware-wallet confirmation screens can contribute to user confusion/misapproval
Evidence from the diff
In core/src/apps/solana/layout.py, the confirm_instruction() function builds on-screen rows for Solana instruction confirmation. The old code wrapped ui_property.display_name with maybe_with_colon(), which appends a colon. Because the display_name values already include a colon, the result was a double-colon label. The patch passes ui_property.display_name directly. This is a one-line UI formatting fix with no logic, parsing, cryptographic, or authorization changes visible in the diff.
Changed components
Trezor Core firmwareSolana app transaction confirmation UIcore/src/apps/solana/layout.pyInspect captured patch +1 / −1
diff --git a/core/src/apps/solana/layout.py b/core/src/apps/solana/layout.py
index cd5ee739..c9493067 100644
--- a/core/src/apps/solana/layout.py
+++ b/core/src/apps/solana/layout.py
@@ -120,7 +120,7 @@ async def confirm_instruction(
f"{instruction_index}/{instructions_count}",
(
(
- maybe_with_colon(ui_property.display_name),
+ ui_property.display_name,
property_template.format(value, *args),
True,
),
Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.