chore(core): remove personal todo markers
What changed, and why it matters
This commit is a routine cleanup that removes informal developer notes ('!@# TODO' markers) from six source files and makes one tiny code improvement (using an unsigned integer conversion function). There is no security-relevant change and no indication of a vulnerability being fixed.
No security action required; treat as normal housekeeping commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit is titled ‘chore(core): remove personal todo markers’ and contains only cosmetic or non-functional changes: deletion of ‘!@# TODO’ / ‘!@# rework it’ / ‘!@# retry on error?????’ / ‘!@# + 1 to fix difference on TR’ / ‘!@# should we have this test here?’ comments, and one functional micro-change in modtrezorio-ipc.h replacing MP_OBJ_NEW_SMALL_INT with mp_obj_new_int_from_uint for a field that is unsigned. No security boundary, cryptographic, memory-safety, or authentication logic is modified. No changelog entry is requested.
Changed components
core/embed/io/display/unix/display_driver.ccore/embed/io/power_manager/stwlc38/stwlc38.ccore/embed/rust/src/ui/component/qr_code.rscore/embed/sec/tamper/stm32u5/tamper.ccore/embed/upymod/modtrezorio/modtrezorio-ipc.hcore/embed/upymod/modtrezorio/modtrezorio-usb-if.hInspect captured patch +4 / −6
diff --git a/core/embed/io/display/unix/display_driver.c b/core/embed/io/display/unix/display_driver.c
index b6774c5f..f2a5023f 100644
--- a/core/embed/io/display/unix/display_driver.c
+++ b/core/embed/io/display/unix/display_driver.c
@@ -99,7 +99,6 @@ static display_driver_t g_display_driver = {
.initialized = false,
};
-//!@# TODO get rid of this...
int sdl_display_res_x = DISPLAY_RESX, sdl_display_res_y = DISPLAY_RESY;
int sdl_touch_offset_x, sdl_touch_offset_y;
diff --git a/core/embed/io/power_manager/stwlc38/stwlc38.c b/core/embed/io/power_manager/stwlc38/stwlc38.c
index 0fbb8f40..8dbc96df 100644
--- a/core/embed/io/power_manager/stwlc38/stwlc38.c
+++ b/core/embed/io/power_manager/stwlc38/stwlc38.c
@@ -314,7 +314,7 @@ static void stwlc38_i2c_callback(void *context, i2c_packet_t *packet) {
memset(&drv->report, 0, sizeof(stwlc38_report_t));
// Kill periodic timer
systimer_unset(drv->timer);
- // !@# retry on error?????
+ // TODO: consider retry on error
drv->state = STWLC38_STATE_POWER_DOWN;
drv->report_readout_requested = false;
diff --git a/core/embed/rust/src/ui/component/qr_code.rs b/core/embed/rust/src/ui/component/qr_code.rs
index d183238b..cff45aef 100644
--- a/core/embed/rust/src/ui/component/qr_code.rs
+++ b/core/embed/rust/src/ui/component/qr_code.rs
@@ -114,7 +114,7 @@ impl Component for Qr {
if self.border > 0 {
shape::Bar::new(qr_area.expand(self.border))
.with_bg(LIGHT)
- .with_radius(CORNER_RADIUS as i16 + 1) // !@# + 1 to fix difference on TR
+ .with_radius(CORNER_RADIUS as i16 + 1)
.render(target);
}
diff --git a/core/embed/sec/tamper/stm32u5/tamper.c b/core/embed/sec/tamper/stm32u5/tamper.c
index edd74797..e796cae2 100644
--- a/core/embed/sec/tamper/stm32u5/tamper.c
+++ b/core/embed/sec/tamper/stm32u5/tamper.c
@@ -122,7 +122,7 @@ bool tamper_init(void) {
NVIC_ClearPendingIRQ(TAMP_IRQn);
- // Enable battery and power monitoring (!@# rework it)
+ // Enable battery and power monitoring
RCC->AHB3ENR |= RCC_AHB3ENR_PWREN;
// HAL_PWR_EnableBkUpAccess();
PWR->BDCR1 |= PWR_BDCR1_MONEN;
diff --git a/core/embed/upymod/modtrezorio/modtrezorio-ipc.h b/core/embed/upymod/modtrezorio/modtrezorio-ipc.h
index caacb69e..9a44ec6a 100644
--- a/core/embed/upymod/modtrezorio/modtrezorio-ipc.h
+++ b/core/embed/upymod/modtrezorio/modtrezorio-ipc.h
@@ -59,7 +59,7 @@ typedef struct _mp_obj_IpcMessage_t {
/// """
STATIC mp_obj_t mod_trezorio_IpcMessage_fn(mp_obj_t self) {
mp_obj_IpcMessage_t *o = MP_OBJ_TO_PTR(self);
- return MP_OBJ_NEW_SMALL_INT(o->message.fn); // !@# uint
+ return mp_obj_new_int_from_uint(o->message.fn);
}
STATIC MP_DEFINE_CONST_FUN_OBJ_1(mod_trezorio_IpcMessage_fn_obj,
mod_trezorio_IpcMessage_fn);
diff --git a/core/embed/upymod/modtrezorio/modtrezorio-usb-if.h b/core/embed/upymod/modtrezorio/modtrezorio-usb-if.h
index 0c8ce11e..f4ed0631 100644
--- a/core/embed/upymod/modtrezorio/modtrezorio-usb-if.h
+++ b/core/embed/upymod/modtrezorio/modtrezorio-usb-if.h
@@ -85,7 +85,6 @@ STATIC mp_obj_t mod_trezorio_USBIF_write(mp_obj_t self, mp_obj_t msg) {
ssize_t r = syshandle_write(o->handle, buf.buf, buf.len);
- // !@# should we have this test here?
if (r != buf.len) {
mp_raise_msg(&mp_type_OSError, MP_ERROR_TEXT("Write failed"));
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.