fix(core): fixing missing colons from parameter="amount" [no changelog]
What the developer wrote
Authored by Michal Kazda
fix(core): fixing missing colons from parameter="amount"
[no changelog]
What changed, and why it matters
This commit fixes a UI formatting bug where some labels on the Trezor screen were missing colons. In the Solana app, display names like 'amount' were not getting a trailing colon. The fix applies the colon-adding helper in the Solana-specific code and removes a duplicate colon-adding step from a shared UI layout function. This is a cosmetic consistency fix, not a security vulnerability.
No security action required. Treat as a routine UI fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change in core/src/apps/solana/layout.py wraps ui_property.display_name with maybe_with_colon() so that Solana instruction properties render with a colon. The change in core/src/trezor/ui/layouts/bolt/init.py removes the with_colon() call inside confirm_properties() and instead builds items as a plain list, because callers are now expected to supply already-colonized names. This is a refactor/normalization of label formatting; there is no cryptographic, authorization, or data-integrity change.
Changed components
core/src/apps/solana/layout.pycore/src/trezor/ui/layouts/bolt/__init__.pyInspect captured patch +3 / −4
diff --git a/core/src/apps/solana/layout.py b/core/src/apps/solana/layout.py
index c9493067..cd5ee739 100644
--- a/core/src/apps/solana/layout.py
+++ b/core/src/apps/solana/layout.py
@@ -120,7 +120,7 @@ async def confirm_instruction(
f"{instruction_index}/{instructions_count}",
(
(
- ui_property.display_name,
+ maybe_with_colon(ui_property.display_name),
property_template.format(value, *args),
True,
),
diff --git a/core/src/trezor/ui/layouts/bolt/__init__.py b/core/src/trezor/ui/layouts/bolt/__init__.py
index fe8deeda..d61bb40a 100644
--- a/core/src/trezor/ui/layouts/bolt/__init__.py
+++ b/core/src/trezor/ui/layouts/bolt/__init__.py
@@ -908,16 +908,15 @@ async def confirm_properties(
br_code: ButtonRequestType = ButtonRequestType.ConfirmOutput,
verb: str | None = None,
) -> None:
- from ..properties import with_colon
- items = with_colon(
+ items = [
(
prop[0],
(utils.hexlify_if_bytes(prop[1]) if prop[1] else None),
prop[2],
)
for prop in props
- )
+ ]
if subtitle:
title += ": " + subtitle
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.