What the developer wrote
Authored by Jakub Janků
test(stellar): check parsed op count
What changed, and why it matters
This commit only changes a single test file. It adds strict=True to a zip() loop in a Stellar cryptocurrency test so that the test fails if the number of original and parsed operations do not match. There is no change to production firmware code, no fix for a runtime bug, and no disclosed security issue.
No security action required. Treat as a normal test-quality improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/device_tests/stellar/test_stellar.py, replacing zip(operations, operations_parsed) with zip(…, strict=True). This is a test-hardening change that ensures the test catches mismatched operation counts. It does not alter the Stellar parser, signing logic, or any firmware runtime behavior.
Changed components
tests/device_tests/stellar/test_stellar.pyInspect captured patch +1 / −1
diff --git a/tests/device_tests/stellar/test_stellar.py b/tests/device_tests/stellar/test_stellar.py
index 5d4dce1d..f83e13f3 100644
--- a/tests/device_tests/stellar/test_stellar.py
+++ b/tests/device_tests/stellar/test_stellar.py
@@ -146,7 +146,7 @@ def test_sign_tx(session: Session, parameters, result):
tx_parsed.payment_req = tx.payment_req
assert tx == tx_parsed
- for op, op_parsed in zip(operations, operations_parsed):
+ for op, op_parsed in zip(operations, operations_parsed, strict=True):
assert op == op_parsed
if "signature" in result:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.