fix(core): fixing extra colons [no changelog]
What the developer wrote
Authored by Michal Kazda
fix(core): fixing extra colons
[no changelog]
What changed, and why it matters
This commit removes duplicate colons from on-screen text labels in the Trezor hardware wallet's Solana app and Bolt UI layout. It is a cosmetic/user-interface cleanup with no security relevance.
No security action needed; treat as a normal UI fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch stops calling maybe_with_colon() in three places inside core/src/apps/solana/layout.py and instead applies with_colon() once inside core/src/trezor/ui/layouts/bolt/init.py’s confirm_properties(). This centralizes colon formatting and prevents labels from showing double colons (e.g., ‘Fee payer::’). No cryptographic, authorization, parsing, or memory-safety code is changed.
Changed components
core/src/apps/solana/layout.pycore/src/trezor/ui/layouts/bolt/__init__.pyInspect captured patch +5 / −5
diff --git a/core/src/apps/solana/layout.py b/core/src/apps/solana/layout.py
index cd5ee739..54526501 100644
--- a/core/src/apps/solana/layout.py
+++ b/core/src/apps/solana/layout.py
@@ -120,7 +120,7 @@ async def confirm_instruction(
f"{instruction_index}/{instructions_count}",
(
(
- maybe_with_colon(ui_property.display_name),
+ ui_property.display_name,
property_template.format(value, *args),
True,
),
@@ -161,7 +161,7 @@ async def confirm_instruction(
await confirm_properties(
"confirm_instruction",
f"{instruction_index}/{instructions_count}",
- maybe_with_colon(account_data),
+ account_data,
instruction.ui_name,
)
else:
@@ -190,7 +190,7 @@ async def confirm_instruction(
await confirm_properties(
"confirm_instruction",
f"{instruction_index}/{instructions_count}",
- maybe_with_colon(signers),
+ signers,
instruction.ui_name,
)
diff --git a/core/src/trezor/ui/layouts/bolt/__init__.py b/core/src/trezor/ui/layouts/bolt/__init__.py
index d61bb40a..3357d934 100644
--- a/core/src/trezor/ui/layouts/bolt/__init__.py
+++ b/core/src/trezor/ui/layouts/bolt/__init__.py
@@ -909,14 +909,14 @@ async def confirm_properties(
verb: str | None = None,
) -> None:
- items = [
+ items = with_colon(
(
prop[0],
(utils.hexlify_if_bytes(prop[1]) if prop[1] else None),
prop[2],
)
for prop in props
- ]
+ )
if subtitle:
title += ": " + subtitle
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.