chore(core/eckhart): drop warning header if title is empty
What the developer wrote
Authored by Roman Zeyde
chore(core/eckhart): drop warning header if title is empty
[no changelog]
What changed, and why it matters
This is a minor user-interface cleanup for the Trezor hardware wallet's Eckhart layout. It removes the warning header from a screen when the title text is empty, so users don't see a blank header. There is no security-relevant change.
No security action needed. Treat as normal UI polish.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies ui_firmware.rs in the Eckhart UI layout. Previously, a warning/info screen always built a Header with the supplied title, icon, and style. Now it only attaches the header if title is non-empty. The paragraphs and action bar are unchanged. This is purely cosmetic and has no effect on cryptographic operations, input validation, or trust boundaries.
Changed components
core/embed/rust/src/ui/layout_eckhart/ui_firmware.rsInspect captured patch +10 / −6
diff --git a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
index c7ff58ae..c4b58be6 100644
--- a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
@@ -1566,9 +1566,6 @@ impl FirmwareUI for UIEckhart {
(theme::YELLOW, theme::label_title_warning())
};
- let header = Header::new(title)
- .with_icon(theme::ICON_INFO, color)
- .with_text_style(style);
let action_bar = if allow_cancel {
ActionBar::new_double(
Button::with_icon(theme::ICON_CROSS),
@@ -1577,9 +1574,16 @@ impl FirmwareUI for UIEckhart {
} else {
ActionBar::new_single(Button::with_text(button))
};
- let screen = TextScreen::new(paragraphs)
- .with_header(header)
- .with_action_bar(action_bar);
+ let screen = TextScreen::new(paragraphs).with_action_bar(action_bar);
+ let screen = if title.is_empty() {
+ screen
+ } else {
+ screen.with_header(
+ Header::new(title)
+ .with_icon(theme::ICON_INFO, color)
+ .with_text_style(style),
+ )
+ };
let layout = LayoutObj::new(screen)?;
Ok(layout)
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.