ci(core): fix nightly ARM emulator filename
What changed, and why it matters
This commit fixes a filename-renaming step in the project's automated nightly build pipeline. It ensures ARM64 emulator files get the correct name expected by another testing tool. There is no change to the actual Trezor firmware code, device behavior, or security-sensitive logic.
No security action needed. Treat as a normal CI maintenance fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is in .github/workflows/core.yml, a GitHub Actions workflow. It adds a dedicated loop that renames files matching firmware-emu-arm- to trezor-emu-arm-core- before the existing loop renames firmware-emu- to trezor-emu-core-. Without this ordering, the ARM64 files would be renamed incorrectly (the ARM-specific pattern would be consumed by the generic pattern), causing downstream nightly CI jobs that depend on the expected filename to fail. This is a CI-only correctness fix.
Changed components
.github/workflows/core.ymlInspect captured patch +3 / −0
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index 2487980d..9bbca919 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -817,6 +817,9 @@ jobs:
run: |
rm -rf emulators/{bootloader,firmware}-emu emulators/mpy-files emulators/*.json
pushd emulators
+ # trezor-user-env expected format for aarch64: trezor-emu-arm-core-T2T1-universal
+ for F in firmware-emu-arm-*; do NEWF=`echo $F | sed s/firmware-emu-arm/trezor-emu-arm-core/`; mv $F $NEWF; done
+ # trezor-user-env expected format for x86_64: trezor-emu-core-T2T1-universal
for F in firmware-emu-*; do NEWF=`echo $F | sed s/firmware-emu/trezor-emu-core/`; mv $F $NEWF; done
popd
tree
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.