refactor(xtask): rename ResolvedBuild to ResolvedBuildFeatures
What the developer wrote
Authored by cepetr
refactor(xtask): rename ResolvedBuild to ResolvedBuildFeatures
[no changelog]
What changed, and why it matters
This commit is a simple internal code cleanup: it renames a Rust data structure called ResolvedBuild to ResolvedBuildFeatures and updates the places that use it. There are no functional changes, no security fixes, and no changes to how the software behaves or protects secrets.
No action needed; this is a non-security refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
A pure refactor in the trezor-firmware xtask build tooling. The struct ResolvedBuild is renamed to ResolvedBuildFeatures, and all references in core/embed/xtask/src/args.rs and core/embed/xtask/src/feature_resolver.rs are updated accordingly. The fields, logic, and return values remain identical.
Changed components
core/embed/xtask/src/args.rscore/embed/xtask/src/feature_resolver.rsInspect captured patch +5 / −5
diff --git a/core/embed/xtask/src/args.rs b/core/embed/xtask/src/args.rs
index 07c66527..af22be31 100644
--- a/core/embed/xtask/src/args.rs
+++ b/core/embed/xtask/src/args.rs
@@ -5,7 +5,7 @@ use clap::{Args, Parser, Subcommand, ValueEnum};
pub use crate::model::Model;
-pub struct ResolvedBuild {
+pub struct ResolvedBuildFeatures {
pub features: Vec<String>,
pub target_triple: Option<&'static str>,
pub board_header: String,
@@ -287,7 +287,7 @@ impl BuildArgs {
}
}
- pub fn resolve_features(&self) -> Result<ResolvedBuild> {
+ pub fn resolve_features(&self) -> Result<ResolvedBuildFeatures> {
crate::feature_resolver::resolve_features(self)
}
diff --git a/core/embed/xtask/src/feature_resolver.rs b/core/embed/xtask/src/feature_resolver.rs
index e053bdd9..159986c7 100644
--- a/core/embed/xtask/src/feature_resolver.rs
+++ b/core/embed/xtask/src/feature_resolver.rs
@@ -2,11 +2,11 @@ use std::process;
use anyhow::{Result, bail};
-use crate::args::{BuildArgs, ConsoleType, Project, ResolvedBuild};
+use crate::args::{BuildArgs, ConsoleType, Project, ResolvedBuildFeatures};
use crate::{config, helpers};
/// Resolves cargo features and target triple from the provided CLI arguments.
-pub fn resolve_features(args: &BuildArgs) -> Result<ResolvedBuild> {
+pub fn resolve_features(args: &BuildArgs) -> Result<ResolvedBuildFeatures> {
let mut features: Vec<String> = vec![args.model.feature_name()];
if args.emulator {
@@ -169,7 +169,7 @@ pub fn resolve_features(args: &BuildArgs) -> Result<ResolvedBuild> {
Some(model_config.target_triple()?)
};
- Ok(ResolvedBuild {
+ Ok(ResolvedBuildFeatures {
features,
target_triple,
board_header: board_features.board_header,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.