AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 76 Bitcoin

fix(solana): don't present trailing accounts as multisig signers

Public commit record

What the developer wrote

Authored by Jakub Janků

98/100 · Strong
fix(solana): don't present trailing accounts as multisig signers

Token program instructions accept trailing account references beyond
their declared account list. The device labeled every such account
"Signer N" and warned that "the following instruction is a multisig
instruction". Neither claim can be verified on-device:

- Whether an account must co-sign is a message-level fact (its signer
flag), which was never checked. A host could append arbitrary
read-only accounts (silently ignored by the Token program unless
they match a multisig member) or ALT-referenced accounts (which can
never sign) and the device would present them as required
co-signers. E.g. for a 1-of-N multisig, a transfer could be made to
appear to require another party's approval while it actually
executes on the user's signature alone.
- Whether the operation is a multisig operation at all depends on
on-chain state (the owner account's program-owner and data length):
trailing signers attached to a plain single-sig owner are ignored
entirely, yet the multisig warning was still shown.

See validate_owner in the Token-2022 processor for both behaviors:
https://github.com/solana-program/token-2022/blob/426400f29d5f1e299be8b353fdf13f22358fbd68/program/src/processor.rs#L2264-L2293

Instead of interpreting the trailing accounts, display only what the
message provably says:

- List every trailing account with its actual (Writable/Signer)
flags, in the same format the unknown-instruction view already
uses. The signer flag is enforced by the runtime (the transaction
is rejected without that account's signature), so this display
cannot be spoofed by the host.
- Drop the per-instruction multisig warning. It asserted an
unverifiable interpretation, and the transaction-level "requires N
signers" warning already fires in every case where multiple
signatures are in fact required.
- InitializeMultisig: fold the "signer_accounts" reference into the
trailing list. The trailing accounts of this instruction are the
future multisig members (read-only, no signatures required at
creation), and the first member was previously labeled differently
("Signers") from the rest ("Signer 1", "Signer 2", ...). The
at-least-one-member requirement is no longer enforced on-device; a
violating transaction fails on-chain.
https://docs.rs/spl-token-2022-interface/3.1.1/spl_token_2022_interface/instruction/enum.TokenInstruction.html#variant.InitializeMultisig
- Rename is_multisig -> trailing_references (programs.json) and
multisig_signers -> trailing_accounts, since the mechanism is
"instruction may carry extra account references", not anything
multisig-specific (System Program Transfer uses it too).

Partially fixes: https://github.com/satoshilabs/trezor-firmware/issues/325

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 94af18581f3c5a3825bd366c0fdaccdc29e91d11)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This update fixes a Trezor Solana display bug that could mislead users into believing a transaction needed extra approvals when it did not. The device previously labeled any extra account attached to certain Solana instructions as a required 'Signer' and warned that the instruction was a multisig instruction, even when those accounts were not signers, not multisig members, or did not exist on-chain. The fix now shows each extra account with its real on-message flags (Writable/Signer), and removes the unverifiable per-instruction multisig warning. This prevents a malicious or buggy host app from making a single-signature transfer look like a multi-signature transfer.

Recommended action

Apply the patch and ensure users upgrade firmware. Wallet software hosts should also be reviewed to avoid constructing transactions that append misleading trailing accounts. Users should verify the actual 'requires N signers' transaction-level warning rather than any per-instruction label when approving Solana transactions.

Security signals we found

01

UI spoofing / misleading signer presentation

02

Host-supplied account metadata trusted without runtime verification

03

Per-instruction multisig warning asserted unverifiable on-chain state

04

Trailing accounts now rendered with message-level Writable/Signer flags

05

Changelog entry tagged as security fix

Risk score

Why this scored 76/100

Our methodology →
Potential impact 22/30
Exploitability 18/25
Stealth signal 12/15
Affected reach 10/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.