chore(core/eckhart): increase padding between description and content
What the developer wrote
Authored by Lukas Bielesch
chore(core/eckhart): increase padding between description and content
[no changelog]
What changed, and why it matters
This commit is a purely cosmetic UI adjustment for the Trezor hardware wallet's 'Eckhart' layout. It increases the spacing between descriptive labels and their content on the receive-crypto screen, replacing hard-coded padding numbers with shared theme constants. There is no security relevance.
No security action required. Treat as a normal UI polish change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change removes two local constants (ITEM_PADDING = 16, GROUP_PADDING = 20) and replaces their usages with theme constants theme::PROP_INNER_SPACING and theme::PROPS_SPACING. It also adds with_spacing(theme::PROP_INNER_SPACING) to a vertical paragraph placement in ui_firmware.rs. The diff affects only layout/spacing of text paragraphs in the receive flow and a confirmation dialog. No logic, cryptography, input handling, memory management, or trust-boundary code is modified.
Changed components
core/embed/rust/src/ui/layout_eckhart/flow/receive.rscore/embed/rust/src/ui/layout_eckhart/ui_firmware.rsInspect captured patch +11 / −9
diff --git a/core/embed/rust/src/ui/layout_eckhart/flow/receive.rs b/core/embed/rust/src/ui/layout_eckhart/flow/receive.rs
index 3571a318..4204fcf1 100644
--- a/core/embed/rust/src/ui/layout_eckhart/flow/receive.rs
+++ b/core/embed/rust/src/ui/layout_eckhart/flow/receive.rs
@@ -30,9 +30,6 @@ use super::super::{
theme::{self, gradient::Gradient},
};
-const ITEM_PADDING: i16 = 16;
-const GROUP_PADDING: i16 = 20;
-
#[derive(Copy, Clone, PartialEq, Eq)]
pub enum Receive {
Content,
@@ -109,7 +106,8 @@ pub fn new_receive(
let mut paragraphs = ParagraphVecShort::new();
if let Some(description) = description {
paragraphs.add(
- Paragraph::new(&theme::TEXT_SMALL_LIGHT, description).with_bottom_padding(ITEM_PADDING),
+ Paragraph::new(&theme::TEXT_SMALL_LIGHT, description)
+ .with_bottom_padding(theme::PROP_INNER_SPACING),
);
}
paragraphs.add(Paragraph::new(text_style, content));
@@ -177,7 +175,10 @@ pub fn new_receive(
&theme::TEXT_SMALL_LIGHT,
TR::words__account.into(),
));
- para.add(Paragraph::new(&theme::TEXT_MONO_EXTRA_LIGHT, a).with_top_padding(ITEM_PADDING));
+ para.add(
+ Paragraph::new(&theme::TEXT_MONO_EXTRA_LIGHT, a)
+ .with_top_padding(theme::PROP_INNER_SPACING),
+ );
}
if let Some(p) = path {
@@ -186,12 +187,12 @@ pub fn new_receive(
&theme::TEXT_SMALL_LIGHT,
TR::address_details__derivation_path.into(),
)
- .with_top_padding(GROUP_PADDING)
+ .with_top_padding(theme::PROPS_SPACING)
.no_break(),
);
para.add(
Paragraph::new(&theme::TEXT_MONO_EXTRA_LIGHT, p)
- .with_top_padding(ITEM_PADDING)
+ .with_top_padding(theme::PROP_INNER_SPACING)
.break_after(),
);
}
@@ -202,7 +203,7 @@ pub fn new_receive(
para.add(Paragraph::new(&theme::TEXT_SMALL_LIGHT, label).no_break());
para.add(
Paragraph::new(&theme::TEXT_MONO_LIGHT, value)
- .with_top_padding(ITEM_PADDING)
+ .with_top_padding(theme::PROP_INNER_SPACING)
.break_after(),
);
}
diff --git a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
index 3ece4615..bae488d0 100644
--- a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
@@ -478,7 +478,8 @@ impl FirmwareUI for UIEckhart {
extra_font: &theme::TEXT_SMALL,
}
.into_paragraphs()
- .with_placement(LinearPlacement::vertical());
+ .with_placement(LinearPlacement::vertical())
+ .with_spacing(theme::PROP_INNER_SPACING);
let mut right_button = if hold {
let verb = verb.unwrap_or(TR::buttons__hold_to_confirm.into());
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.