chore(rust): remove deprecated `_on_device` from `PassphraseRequest`
What the developer wrote
Authored by Roman Zeyde
chore(rust): remove deprecated `_on_device` from `PassphraseRequest`
[no changelog]
What changed, and why it matters
This commit removes an unused Rust helper method that checked whether a passphrase should be entered on the Trezor device. It is a routine cleanup with no visible security effect.
No action needed; treat as normal code maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes the on_device() method from PassphraseRequest in rust/trezor-client/src/client/common.rs. That method merely forwarded to a deprecated protobuf accessor _on_device(). No logic that uses the method is changed, and no security-sensitive behavior is introduced or removed.
Changed components
rust/trezor-client/src/client/common.rsInspect captured patch +0 / −5
diff --git a/rust/trezor-client/src/client/common.rs b/rust/trezor-client/src/client/common.rs
index c9ce2a5e..95ce9556 100644
--- a/rust/trezor-client/src/client/common.rs
+++ b/rust/trezor-client/src/client/common.rs
@@ -101,11 +101,6 @@ impl<'a, T, R: TrezorMessage> fmt::Debug for PassphraseRequest<'a, T, R> {
}
impl<'a, T, R: TrezorMessage> PassphraseRequest<'a, T, R> {
- /// Check whether the use is supposed to enter the passphrase on the device or not.
- pub fn on_device(&self) -> bool {
- self.message._on_device()
- }
-
/// Ack the request with a passphrase and get the next message from the device.
pub fn ack_passphrase(self, passphrase: String) -> Result<TrezorResponse<'a, T, R>> {
let mut req = protos::PassphraseAck::new();
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.