fix(solana): never hide account self-assignment
What changed, and why it matters
This fix prevents a Trezor hardware wallet from silently approving a specific Solana 'Assign' instruction. Previously, when a user assigned their own account as the new owner program, both key details were hidden from the device screen, so the instruction produced no visible prompt at all. An attacker could tack this silent self-assignment onto an otherwise normal-looking transfer, tricking the user into signing a transaction that permanently locks their Solana account's funds. The patch now always displays both the account being assigned and the new owner program.
Users should upgrade to firmware containing this commit. Developers should review other Solana instructions for similar default_value_to_hide patterns that could hide entire screens when values match the signer, and ensure every instruction renders at least one confirmation screen.
Security signals we found
UI field suppression caused an entire instruction screen to disappear when values equal the signer
Silent instruction could be appended to a visible transfer in the same transaction
Self-assignment to a non-executable owner program permanently locks lamports per Solana account rules
Vendor-authored changelog fragment labels the change as a security fix
Patch is a cherry-pick, indicating backport of a security-relevant fix
Evidence from the diff
In Trezor’s Solana instruction UI definitions, the System Program ‘Assign’ instruction had UIProperty entries with default_value_to_hide=’signer’. When the assigned_account and owner both equal the transaction signer, both fields were suppressed, causing the instruction to render no confirmation screen. The commit removes default_value_to_hide for both fields, so the screen is always shown. A new test fixture ‘Assign Self’ verifies the behavior. The changelog fragment classifies this as a security fix. Self-assignment assigns a wallet account to its own non-executable address as owner, which on Solana means only that owner program can debit lamports or reassign ownership, effectively freezing the account.
Changed components
Trezor firmware Solana appcore/src/apps/solana/transaction/instructions.pycommon/defs/solana/programs.jsonSystem Program Assign instruction UI renderingInspect captured patch +40 / −6
### common/defs/solana/programs.json
@@ -74,13 +74,11 @@
"ui_properties": [
{
"account": "assigned_account",
- "display_name": "Assign account",
- "default_value_to_hide": "signer"
+ "display_name": "Assign account"
},
{
"parameter": "owner",
- "display_name": "Assign account to program",
- "default_value_to_hide": "signer"
+ "display_name": "Assign account to program"
}
]
},
### common/tests/fixtures/solana/sign_tx.system_program.json
@@ -78,6 +78,41 @@
"expected_signature": "d533f38bcc0b302d2353ee1883217f7cdb283b749ca1b7251b365a4e8c8742b49e8847b759ab845abe2d0b37f4cc916a91a566e40559f5679794cb458be1750e"
}
},
+ {
+ "description": "Assign Self",
+ "parameters": {
+ "address": "m/44'/501'/0'/0'",
+ "construct": {
+ "version": null,
+ "header": {
+ "signers": 1,
+ "readonly_signers": 0,
+ "readonly_non_signers": 1
+ },
+ "accounts": [
+ "14CCvQzQzHCVgZM3j9soPnXuJXh1RmCfwLVUcdfbZVBS",
+ "11111111111111111111111111111111"
+ ],
+ "blockhash": "2p4rYZAaFfV5Uk5ugdG5KPNty9Uda9B3b4gWB8qnNqak",
+ "instructions": [
+ {
+ "program_index": 1,
+ "accounts": {
+ "assigned_account": 0
+ },
+ "data": {
+ "instruction_id": 1,
+ "owner": "14CCvQzQzHCVgZM3j9soPnXuJXh1RmCfwLVUcdfbZVBS"
+ }
+ }
+ ],
+ "luts": []
+ }
+ },
+ "result": {
+ "expected_signature": "6b6500c68b37d7374ab4839f020e132faaaec78fd83be6dc91127595b8d28f81263511797ca474c8d4610e796cde10f163541bf15411bc343746e71536b39301"
+ }
+ },
{
"description": "Transfer",
"parameters": {
### core/.changelog.d/+solana_assign_self.security
@@ -0,0 +1 @@
+Solana: Always show the assigned account and new owner program in System Program Assign instructions.
### core/src/apps/solana/transaction/instructions.py
@@ -969,13 +969,13 @@ def get_instruction(
None,
"assigned_account",
"Assign account",
- "signer",
+ None,
),
UIProperty(
"owner",
None,
"Assign account to program",
- "signer",
+ None,
),
),
"System Program: Assign",Why this scored 75/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.