test(core): use layout-specific expected `view_all_data` string
What the developer wrote
Authored by Roman Zeyde
test(core): use layout-specific expected `view_all_data` string
Previous code didn't work with blanked translated strings.
[no changelog]
What changed, and why it matters
This is a minor test-only change. It updates a single test helper to check for different on-screen text depending on which Trezor device screen layout is being used. It does not change any firmware behavior, user-facing functionality, or security logic.
No security action needed. Treat as a normal test fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies tests/input_flows.py in the InputFlowEthereumSignTxData class. The assertion that detects whether the current Ethereum transaction data screen is the ‘intro’ layout is split into two branches: Delizia layouts look for TR.instructions__view_all_data in text_content(), while Eckhart layouts look for TR.buttons__view_all_data in button_contents(). The previous combined check failed when translated strings were blanked. No production code is touched.
Changed components
tests/input_flows.pyInspect captured patch +8 / −4
diff --git a/tests/input_flows.py b/tests/input_flows.py
index bbf84ac5..7de47f7a 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -1735,10 +1735,14 @@ class InputFlowEthereumSignTxData(InputFlowBase):
assert layout.title().startswith(TR.ethereum__title_input_data)
# Only intro layout contains "view all" functionality:
- assert is_intro == (
- TR.instructions__view_all_data in layout.text_content()
- or TR.buttons__view_all_data in layout.button_contents()
- )
+ if self.client.layout_type is LayoutType.Delizia:
+ assert is_intro == (
+ TR.instructions__view_all_data in layout.text_content()
+ )
+ elif self.client.layout_type is LayoutType.Eckhart:
+ assert is_intro == (
+ TR.buttons__view_all_data in layout.button_contents()
+ )
if self.scroll:
self._go_to_next_page(is_intro)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.