What changed, and why it matters
This commit adds a new CI feature that uploads firmware memory-usage reports to a third-party service called MemBrowse. It does not change any firmware code, cryptographic logic, or user-facing behavior. It only affects GitHub Actions automation and is purely informational for developers reviewing pull requests.
No security action required. As a routine hygiene measure, reviewers may want to confirm that the MemBrowse API key secret is scoped only to this upload purpose and that the third-party action membrowse/membrowse-action@v1 is pinned to a trusted version or hash in future updates.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change introduces GitHub Actions workflows and a composite action to build Trezor firmware artifacts and upload ELF/map/linker-script data to MemBrowse for memory-layout visualization. It adds: (1) .github/actions/membrowse/action.yml, a reusable action that invokes membrowse/membrowse-action@v1 for firmware/kernel/secmon/bootloader targets; (2) .github/membrowse-targets.json, a static list of build commands and artifact paths for each supported model; (3) a step in .github/workflows/core.yml that runs the MemBrowse action on normal core_firmware builds for pull requests and pushes to main, with continue-on-error: true and an optional API key; (4) .github/workflows/membrowse-comment.yml, a workflow_run-triggered job that posts a memory report PR comment; and (5) .github/workflows/membrowse-onboard.yml, a manually dispatched workflow to backfill historical reports. No source code, linker scripts, or build outputs consumed by devices are modified.
Changed components
GitHub Actions CI configuration.github/workflows/core.yml.github/workflows/membrowse-comment.yml.github/workflows/membrowse-onboard.yml.github/actions/membrowse/action.yml.github/membrowse-targets.jsonInspect captured patch +416 / −0
### .github/actions/membrowse/action.yml
@@ -0,0 +1,92 @@
+name: 'MemBrowse memory report'
+description: 'Upload memory usage of the built firmware, kernel, secmon and bootloader to MemBrowse'
+inputs:
+ model:
+ description: 'Trezor model, e.g. T3W1'
+ required: true
+ coins:
+ description: 'universal or btconly'
+ required: true
+ api-key:
+ description: 'MemBrowse API key (empty for fork PRs, which upload without one)'
+ required: false
+ default: ''
+runs:
+ using: "composite"
+ steps:
+ - name: Resolve linker scripts
+ id: cfg
+ shell: bash
+ env:
+ MODEL: ${{ inputs.model }}
+ COINS: ${{ inputs.coins }}
+ run: |
+ model_dir=core/embed/models/$MODEL
+ mcu=$(sed -n 's/^mcu *= *"\(.*\)"/\1/p' "$model_dir/model.toml")
+ # Same mapping as core/embed/xbuild/src/trezor.rs (link_as)
+ case "$mcu" in
+ stm32f4*) linker_dir=core/embed/sys/linker/stm32f4 ;;
+ *) linker_dir=core/embed/sys/linker/$mcu ;;
+ esac
+ # Firmware, kernel and secmon enable the secmon_layout feature, the bootloader does not
+ layout_ld=$model_dir/memory.ld
+ if grep -q '"secmon_layout"' "$model_dir/model.toml"; then
+ layout_ld=$model_dir/memory_secmon.ld
+ fi
+ artifacts=core/build/artifacts/$MODEL
+ {
+ echo "artifacts=$artifacts"
+ echo "linker_dir=$linker_dir"
+ echo "layout_ld=$layout_ld"
+ echo "memory_ld=$model_dir/memory.ld"
+ echo "suffix=$([ "$COINS" = btconly ] && echo -btconly)"
+ for project in kernel secmon bootloader; do
+ echo "has_$project=$([ "$COINS" = universal ] && [ -f "$artifacts/$project.elf" ] && echo true)"
+ done
+ } >> "$GITHUB_OUTPUT"
+ cat "$GITHUB_OUTPUT"
+
+ - name: MemBrowse firmware
+ uses: membrowse/membrowse-action@v1
+ with:
+ target_name: ${{ inputs.model }}-firmware${{ steps.cfg.outputs.suffix }}
+ elf: ${{ steps.cfg.outputs.artifacts }}/firmware.elf
+ ld: ${{ steps.cfg.outputs.layout_ld }} ${{ steps.cfg.outputs.linker_dir }}/firmware.ld
+ map_file: ${{ steps.cfg.outputs.artifacts }}/firmware.map
+ # The MicroPython heap takes all RAM left in its region; its usage is only known at runtime
+ skip_sections: .heap
+ exclude_alignment: true
+ api_key: ${{ inputs.api-key }}
+
+ - name: MemBrowse kernel
+ if: steps.cfg.outputs.has_kernel == 'true'
+ uses: membrowse/membrowse-action@v1
+ with:
+ target_name: ${{ inputs.model }}-kernel
+ elf: ${{ steps.cfg.outputs.artifacts }}/kernel.elf
+ ld: ${{ steps.cfg.outputs.layout_ld }} ${{ steps.cfg.outputs.linker_dir }}/kernel.ld
+ map_file: ${{ steps.cfg.outputs.artifacts }}/kernel.map
+ exclude_alignment: true
+ api_key: ${{ inputs.api-key }}
+
+ - name: MemBrowse secmon
+ if: steps.cfg.outputs.has_secmon == 'true'
+ uses: membrowse/membrowse-action@v1
+ with:
+ target_name: ${{ inputs.model }}-secmon
+ elf: ${{ steps.cfg.outputs.artifacts }}/secmon.elf
+ ld: ${{ steps.cfg.outputs.layout_ld }} ${{ steps.cfg.outputs.linker_dir }}/secmon.ld
+ map_file: ${{ steps.cfg.outputs.artifacts }}/secmon.map
+ exclude_alignment: true
+ api_key: ${{ inputs.api-key }}
+
+ - name: MemBrowse bootloader
+ if: steps.cfg.outputs.has_bootloader == 'true'
+ uses: membrowse/membrowse-action@v1
+ with:
+ target_name: ${{ inputs.model }}-bootloader
+ elf: ${{ steps.cfg.outputs.artifacts }}/bootloader.elf
+ ld: ${{ steps.cfg.outputs.memory_ld }} ${{ steps.cfg.outputs.linker_dir }}/bootloader.ld
+ map_file: ${{ steps.cfg.outputs.artifacts }}/bootloader.map
+ exclude_alignment: true
+ api_key: ${{ inputs.api-key }}
### .github/membrowse-targets.json
@@ -0,0 +1,191 @@
+[
+ {
+ "target_name": "T2T1-firmware",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T2T1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T2T1/firmware.elf",
+ "ld": "core/embed/models/T2T1/memory.ld core/embed/sys/linker/stm32f4/firmware.ld",
+ "map_file": "core/build/artifacts/T2T1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T2T1-firmware-btconly",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T2T1 PYOPT=1 BITCOIN_ONLY=1\"",
+ "elf": "core/build/artifacts/T2T1/firmware.elf",
+ "ld": "core/embed/models/T2T1/memory.ld core/embed/sys/linker/stm32f4/firmware.ld",
+ "map_file": "core/build/artifacts/T2T1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T2T1-kernel",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T2T1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T2T1/kernel.elf",
+ "ld": "core/embed/models/T2T1/memory.ld core/embed/sys/linker/stm32f4/kernel.ld",
+ "map_file": "core/build/artifacts/T2T1/kernel.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T2T1-bootloader",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_bootloader TREZOR_MODEL=T2T1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T2T1/bootloader.elf",
+ "ld": "core/embed/models/T2T1/memory.ld core/embed/sys/linker/stm32f4/bootloader.ld",
+ "map_file": "core/build/artifacts/T2T1/bootloader.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T2B1-firmware",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T2B1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T2B1/firmware.elf",
+ "ld": "core/embed/models/T2B1/memory.ld core/embed/sys/linker/stm32f4/firmware.ld",
+ "map_file": "core/build/artifacts/T2B1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T2B1-firmware-btconly",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T2B1 PYOPT=1 BITCOIN_ONLY=1\"",
+ "elf": "core/build/artifacts/T2B1/firmware.elf",
+ "ld": "core/embed/models/T2B1/memory.ld core/embed/sys/linker/stm32f4/firmware.ld",
+ "map_file": "core/build/artifacts/T2B1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T2B1-kernel",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T2B1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T2B1/kernel.elf",
+ "ld": "core/embed/models/T2B1/memory.ld core/embed/sys/linker/stm32f4/kernel.ld",
+ "map_file": "core/build/artifacts/T2B1/kernel.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T2B1-bootloader",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_bootloader TREZOR_MODEL=T2B1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T2B1/bootloader.elf",
+ "ld": "core/embed/models/T2B1/memory.ld core/embed/sys/linker/stm32f4/bootloader.ld",
+ "map_file": "core/build/artifacts/T2B1/bootloader.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3B1-firmware",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3B1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T3B1/firmware.elf",
+ "ld": "core/embed/models/T3B1/memory.ld core/embed/sys/linker/stm32u58/firmware.ld",
+ "map_file": "core/build/artifacts/T3B1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T3B1-firmware-btconly",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3B1 PYOPT=1 BITCOIN_ONLY=1\"",
+ "elf": "core/build/artifacts/T3B1/firmware.elf",
+ "ld": "core/embed/models/T3B1/memory.ld core/embed/sys/linker/stm32u58/firmware.ld",
+ "map_file": "core/build/artifacts/T3B1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T3B1-kernel",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3B1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T3B1/kernel.elf",
+ "ld": "core/embed/models/T3B1/memory.ld core/embed/sys/linker/stm32u58/kernel.ld",
+ "map_file": "core/build/artifacts/T3B1/kernel.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3B1-bootloader",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_bootloader TREZOR_MODEL=T3B1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T3B1/bootloader.elf",
+ "ld": "core/embed/models/T3B1/memory.ld core/embed/sys/linker/stm32u58/bootloader.ld",
+ "map_file": "core/build/artifacts/T3B1/bootloader.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3T1-firmware",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3T1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T3T1/firmware.elf",
+ "ld": "core/embed/models/T3T1/memory.ld core/embed/sys/linker/stm32u58/firmware.ld",
+ "map_file": "core/build/artifacts/T3T1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T3T1-firmware-btconly",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3T1 PYOPT=1 BITCOIN_ONLY=1\"",
+ "elf": "core/build/artifacts/T3T1/firmware.elf",
+ "ld": "core/embed/models/T3T1/memory.ld core/embed/sys/linker/stm32u58/firmware.ld",
+ "map_file": "core/build/artifacts/T3T1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T3T1-kernel",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3T1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T3T1/kernel.elf",
+ "ld": "core/embed/models/T3T1/memory.ld core/embed/sys/linker/stm32u58/kernel.ld",
+ "map_file": "core/build/artifacts/T3T1/kernel.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3T1-bootloader",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_bootloader TREZOR_MODEL=T3T1 PYOPT=1\"",
+ "elf": "core/build/artifacts/T3T1/bootloader.elf",
+ "ld": "core/embed/models/T3T1/memory.ld core/embed/sys/linker/stm32u58/bootloader.ld",
+ "map_file": "core/build/artifacts/T3T1/bootloader.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3W1-firmware",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3W1 PYOPT=1 BOOTLOADER_DEVEL=1\"",
+ "elf": "core/build/artifacts/T3W1/firmware.elf",
+ "ld": "core/embed/models/T3W1/memory_secmon.ld core/embed/sys/linker/stm32u5g/firmware.ld",
+ "map_file": "core/build/artifacts/T3W1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T3W1-firmware-btconly",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3W1 PYOPT=1 BOOTLOADER_DEVEL=1 BITCOIN_ONLY=1\"",
+ "elf": "core/build/artifacts/T3W1/firmware.elf",
+ "ld": "core/embed/models/T3W1/memory_secmon.ld core/embed/sys/linker/stm32u5g/firmware.ld",
+ "map_file": "core/build/artifacts/T3W1/firmware.map",
+ "linker_vars": "",
+ "skip_sections": ".heap"
+ },
+ {
+ "target_name": "T3W1-kernel",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3W1 PYOPT=1 BOOTLOADER_DEVEL=1\"",
+ "elf": "core/build/artifacts/T3W1/kernel.elf",
+ "ld": "core/embed/models/T3W1/memory_secmon.ld core/embed/sys/linker/stm32u5g/kernel.ld",
+ "map_file": "core/build/artifacts/T3W1/kernel.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3W1-secmon",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_firmware TREZOR_MODEL=T3W1 PYOPT=1 BOOTLOADER_DEVEL=1\"",
+ "elf": "core/build/artifacts/T3W1/secmon.elf",
+ "ld": "core/embed/models/T3W1/memory_secmon.ld core/embed/sys/linker/stm32u5g/secmon.ld",
+ "map_file": "core/build/artifacts/T3W1/secmon.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ },
+ {
+ "target_name": "T3W1-bootloader",
+ "build_cmd": "nix-shell --run \"uv run make -C core build_bootloader TREZOR_MODEL=T3W1 PYOPT=1 BOOTLOADER_DEVEL=1\"",
+ "elf": "core/build/artifacts/T3W1/bootloader.elf",
+ "ld": "core/embed/models/T3W1/memory.ld core/embed/sys/linker/stm32u5g/bootloader.ld",
+ "map_file": "core/build/artifacts/T3W1/bootloader.map",
+ "linker_vars": "",
+ "skip_sections": ""
+ }
+]
### .github/workflows/core.yml
@@ -138,6 +138,18 @@ jobs:
core/build/artifacts/latest/*.map
core/build/artifacts/pub/*
retention-days: 7
+ # Memory report on MemBrowse for PRs and pushes to main; the PR comment is posted by membrowse-comment.yml.
+ # Not on the nightly schedule or workflow_dispatch: they would re-upload the main tip without its parent.
+ - uses: ./.github/actions/membrowse
+ if: >
+ matrix.type == 'normal' && !matrix.miniscript && !matrix.n1w1 && matrix.model != 'D001' &&
+ (github.event_name == 'pull_request' ||
+ (github.event_name == 'push' && github.ref == 'refs/heads/main'))
+ continue-on-error: true # never fail the firmware build because of the report
+ with:
+ model: ${{ matrix.model }}
+ coins: ${{ matrix.coins }}
+ api-key: ${{ secrets.MEMBROWSE_API_KEY }}
core_emu:
name: Build emu (${{ matrix.model }}, ${{ matrix.coins }}, ${{ matrix.type }}, ${{ matrix.asan }}${{ matrix.miniscript && ', miniscript' || '' }}${{matrix.k1n1 && ', k1n1' || '' }})
### .github/workflows/membrowse-comment.yml
@@ -0,0 +1,36 @@
+name: MemBrowse PR comment
+
+# Runs in the base repository after the Core workflow, so it can comment on fork PRs too.
+on:
+ workflow_run:
+ workflows: [Core]
+ types:
+ - completed
+
+permissions:
+ contents: read
+
+jobs:
+ comment:
+ name: Post memory report
+ runs-on: ubuntu-latest
+ timeout-minutes: 5
+ # Skip cancelled runs, e.g. superseded by a newer push to the same PR
+ if: >
+ github.event.workflow_run.event == 'pull_request' &&
+ github.event.workflow_run.conclusion != 'cancelled'
+ permissions:
+ contents: read
+ pull-requests: write
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # actions/checkout@v6.0.2
+ with:
+ persist-credentials: false
+ - uses: membrowse/membrowse-action/comment-action@v1
+ if: env.MEMBROWSE_API_KEY != ''
+ with:
+ api_key: ${{ secrets.MEMBROWSE_API_KEY }}
+ commit: ${{ github.event.workflow_run.head_sha }}
+ env:
+ MEMBROWSE_API_KEY: ${{ secrets.MEMBROWSE_API_KEY }}
+ GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
### .github/workflows/membrowse-onboard.yml
@@ -0,0 +1,85 @@
+name: Onboard to MemBrowse
+
+on:
+ workflow_dispatch:
+ inputs:
+ num_commits:
+ description: 'Number of commits to process'
+ required: true
+ default: '200'
+ type: string
+ targets:
+ description: 'Space-separated target names to onboard (empty = all)'
+ required: false
+ default: ''
+ type: string
+
+permissions:
+ contents: read
+
+jobs:
+ load-targets:
+ runs-on: ubuntu-latest
+ outputs:
+ matrix: ${{ steps.set-matrix.outputs.matrix }}
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # actions/checkout@v6.0.2
+ with:
+ persist-credentials: false
+
+ - name: Load target matrix
+ id: set-matrix
+ env:
+ TARGETS: ${{ github.event.inputs.targets }}
+ run: |
+ matrix=$(jq -c --arg t "$TARGETS" \
+ '($t | split(" ") | map(select(. != ""))) as $sel
+ | map(select(($sel | length) == 0 or (.target_name | IN($sel[]))))' \
+ .github/membrowse-targets.json)
+ echo "$matrix" | jq -r '.[].target_name'
+ echo "matrix=$matrix" >> "$GITHUB_OUTPUT"
+
+ onboard:
+ name: Onboard (${{ matrix.target_name }})
+ needs: load-targets
+ runs-on: ubuntu-latest
+ timeout-minutes: 360
+ strategy:
+ fail-fast: false
+ matrix:
+ include: ${{ fromJson(needs.load-targets.outputs.matrix) }}
+
+ steps:
+ - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # actions/checkout@v6.0.2
+ with:
+ # Onboard iterates through historical commits, so it needs full history
+ fetch-depth: 0
+ submodules: recursive
+ persist-credentials: false
+
+ - name: Set up Python
+ uses: actions/setup-python@v6
+ with:
+ python-version: '3.13'
+
+ # Pre-download nix + uv deps; build_cmd runs through nix-shell, which (unlike
+ # the flake used by $UV_RUN) works on commits older than flake.nix
+ - uses: ./.github/actions/environment
+
+ - name: Run MemBrowse Onboard Action
+ uses: membrowse/membrowse-action/onboard-action@v1
+ with:
+ target_name: ${{ matrix.target_name }}
+ num_commits: ${{ github.event.inputs.num_commits }}
+ # Submodule pins change across history, so sync them for every commit
+ build_script: git submodule update --init --recursive && ${{ matrix.build_cmd }}
+ elf: ${{ matrix.elf }}
+ ld: ${{ matrix.ld }}
+ map_file: ${{ matrix.map_file }}
+ linker_vars: ${{ matrix.linker_vars }}
+ # Sections that fill their regions by design, e.g. the MicroPython .heap
+ skip_sections: ${{ matrix.skip_sections }}
+ exclude_alignment: 'true'
+ binary_search: 'true'
+ api_key: ${{ secrets.MEMBROWSE_API_KEY }}
+ api_url: ${{ vars.MEMBROWSE_API_URL }}Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.