What the developer wrote
Authored by Ioan Bizău
fix: tests
[no changelog]
What changed, and why it matters
This commit only updates test helper code in tests/input_flows.py. It renames a helper method and changes which on-screen text labels the tests look for, matching the tests to updated wording in the device firmware's user interface. There is no change to the actual Trezor firmware or wallet logic, so it has no security relevance for end users.
No action required. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies two test helper classes (InputFlowSignTxInformation and InputFlowSignTxInformationMixed) in tests/input_flows.py. It replaces a parameterized assert_content(content, title_path) helper with fixed assertions that check for TR.words__account, removing per-device title-path differences. All call sites are updated accordingly. This is purely a test-maintenance change; no firmware, crypto, or security-critical code is touched.
Changed components
tests/input_flows.pyInspect captured patch +12 / −12
diff --git a/tests/input_flows.py b/tests/input_flows.py
index 1bcf2d8c..7611c240 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -1309,32 +1309,32 @@ class InputFlowSignTxInformation(InputFlowBase):
def __init__(self, client: Client | DebugSession):
super().__init__(client)
- def assert_content(self, content: str, title_path: str) -> None:
- assert TR.translate(title_path) in content
+ def assert_account_details(self, content: str) -> None:
+ assert TR.words__account in content
assert "Legacy #6" in content
assert TR.confirm_total__fee_rate in content
assert "71.56 sat" in content
def input_flow_bolt(self) -> BRGeneratorType:
content = yield from sign_tx_go_to_info_bolt(self.client)
- self.assert_content(content, "confirm_total__sending_from_account")
+ self.assert_account_details(content)
self.debug.press_yes()
def input_flow_caesar(self) -> BRGeneratorType:
content = yield from sign_tx_go_to_info_caesar(self.client)
print("content", content)
- self.assert_content(content, "confirm_total__title_sending_from")
+ self.assert_account_details(content)
self.debug.press_yes()
def input_flow_delizia(self) -> BRGeneratorType:
content = yield from sign_tx_go_to_info_delizia(self.client)
- self.assert_content(content, "confirm_total__sending_from_account")
+ self.assert_account_details(content)
self.debug.swipe_up()
self.debug.press_yes()
def input_flow_eckhart(self) -> BRGeneratorType:
content = yield from sign_tx_go_to_info_eckhart(self.client)
- self.assert_content(content, "words__account")
+ self.assert_account_details(content)
self.debug.press_yes()
@@ -1342,8 +1342,8 @@ class InputFlowSignTxInformationMixed(InputFlowBase):
def __init__(self, client: Client | DebugSession):
super().__init__(client)
- def assert_content(self, content: str, title_path: str) -> None:
- assert TR.translate(title_path) in content
+ def assert_content(self, content: str) -> None:
+ assert TR.words__account in content
assert TR.bitcoin__multiple_accounts in content
assert TR.confirm_total__fee_rate in content
assert "18.33 sat" in content
@@ -1354,7 +1354,7 @@ class InputFlowSignTxInformationMixed(InputFlowBase):
self.debug.press_yes()
content = yield from sign_tx_go_to_info_bolt(self.client)
- self.assert_content(content, "confirm_total__sending_from_account")
+ self.assert_content(content)
self.debug.press_yes()
def input_flow_caesar(self) -> BRGeneratorType:
@@ -1363,18 +1363,18 @@ class InputFlowSignTxInformationMixed(InputFlowBase):
self.debug.press_yes()
content = yield from sign_tx_go_to_info_caesar(self.client)
- self.assert_content(content, "confirm_total__title_sending_from")
+ self.assert_content(content)
self.debug.press_yes()
def input_flow_delizia(self) -> BRGeneratorType:
content = yield from sign_tx_go_to_info_delizia(self.client, multi_account=True)
- self.assert_content(content, "confirm_total__sending_from_account")
+ self.assert_content(content)
self.debug.swipe_up()
self.debug.press_yes()
def input_flow_eckhart(self) -> BRGeneratorType:
content = yield from sign_tx_go_to_info_eckhart(self.client, multi_account=True)
- self.assert_content(content, "words__account")
+ self.assert_content(content)
self.debug.press_yes()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.