fix(core): remove duplicit rgb_led_set_color function in unix implementation.
What the developer wrote
Authored by kopecdav
fix(core): remove duplicit rgb_led_set_color function in unix implementation.
[no changelog]
What changed, and why it matters
This commit removes an accidental duplicate of a harmless LED color-setting function in the Unix (simulator/emulator) build of the Trezor firmware. It is a routine cleanup with no security relevance.
No security action needed. Treat as normal code hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change deletes a second definition of rgb_led_set_color(uint32_t color) in core/embed/io/rgb_led/unix/rgb_led.c. The function simply forwards to display_rgb_led(color). The duplicate would have caused a compile-time or link-time error, not a runtime vulnerability. It only affects the Unix emulator target, not real Trezor hardware.
Changed components
core/embed/io/rgb_led/unix/rgb_led.cInspect captured patch +0 / −2
diff --git a/core/embed/io/rgb_led/unix/rgb_led.c b/core/embed/io/rgb_led/unix/rgb_led.c
index 62b854c65..e2e364ff3 100644
--- a/core/embed/io/rgb_led/unix/rgb_led.c
+++ b/core/embed/io/rgb_led/unix/rgb_led.c
@@ -89,8 +89,6 @@ void rgb_led_set_color(uint32_t color) {
display_rgb_led(color);
}
-void rgb_led_set_color(uint32_t color) { display_rgb_led(color); }
-
void rgb_led_effect_start(rgb_led_effect_type_t effect_type,
uint32_t requested_cycles) {
// RGB effect not supported in unix yet
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.