test(core): drop an unused parameter of `make_payment_request()`

Trezor/Trezor firmware

6dd19fdc View source ↗

Public commit record

What the developer wrote

Authored by Roman Zeyde

72/100 · Adequate

test(core): drop an unused parameter of `make_payment_request()`

[no changelog]

✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body

The short version

What changed, and why it matters

This commit only cleans up test code by removing an unused 'session' argument from a helper function used in automated tests. It does not change the actual Trezor firmware or any code that runs on the device, so it has no security impact for users.

Recommended action

No action required; this is a non-security test refactor.

Security signals we found

No strong security signals were identified.

Technical analysis

Evidence from the diff

The commit refactors the test helper make_payment_request() in tests/device_tests/payment_req.py to drop its unused session: Session parameter, and updates all call sites across eight test files to match the new signature. No firmware, bootloader, library, or runtime logic is modified. The change is purely a test-code hygiene improvement.

Changed components

tests/device_tests/payment_req.pytests/device_tests/bitcoin/test_signtx_payreq.pytests/device_tests/cardano/test_sign_tx.pytests/device_tests/ethereum/test_signtx.pytests/device_tests/misc/test_msg_paymentnotification.pytests/device_tests/ripple/test_sign_tx.pytests/device_tests/solana/test_sign_tx.pytests/device_tests/stellar/test_stellar.py

Inspect captured patch +0 / −18

### tests/device_tests/bitcoin/test_signtx_payreq.py
@@ -96,7 +96,6 @@ def test_signtx_payment_req_swap_with_text_and_refund(
     nonce = misc.get_nonce(session)
 
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=1,
         outputs=[(o.amount, o.address) for o in outputs],
@@ -250,7 +249,6 @@ def test_payment_request(session: Session, payment_request_params):
                 )
         payment_reqs.append(
             make_payment_request(
-                session,
                 recipient_name="trezor.io",
                 slip44=1,
                 outputs=request_outputs,
@@ -293,7 +291,6 @@ def test_payment_req_wrong_amount(session: Session):
     outputs[1].payment_req_index = 0
     outputs[2].payment_req_index = None
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=1,
         outputs=[(txo.amount, txo.address) for txo in outputs[:2]],
@@ -322,7 +319,6 @@ def test_payment_req_amount_encoding_bytes(session: Session):
     outputs[1].payment_req_index = 0
     outputs[2].payment_req_index = None
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=1,
         outputs=[(txo.amount, txo.address) for txo in outputs[:2]],
@@ -355,7 +351,6 @@ def test_payment_req_wrong_mac_refund(session: Session):
     outputs[1].payment_req_index = 0
     outputs[2].payment_req_index = None
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=1,
         outputs=[(txo.amount, txo.address) for txo in outputs[:2]],
@@ -395,7 +390,6 @@ def test_payment_req_wrong_mac_purchase(session: Session):
     outputs[1].payment_req_index = 0
     outputs[2].payment_req_index = None
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=1,
         outputs=[(txo.amount, txo.address) for txo in outputs[:2]],
@@ -425,7 +419,6 @@ def test_payment_req_wrong_output(session: Session):
     outputs[1].payment_req_index = 0
     outputs[2].payment_req_index = None
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=1,
         outputs=[(txo.amount, txo.address) for txo in outputs[:2]],

### tests/device_tests/cardano/test_sign_tx.py
@@ -150,7 +150,6 @@ def call_sign_tx(session: Session, parameters, input_flow=None, chunkify: bool =
         memos = [purchase_memo, refund_memo, text_details_memo]
         nonce = misc.get_nonce(session)
         payment_request = make_payment_request(
-            session,
             recipient_name="trezor.io",
             slip44=1815,
             outputs=[(o[0].amount, o[0].address) for o in outputs],

### tests/device_tests/ethereum/test_signtx.py
@@ -759,7 +759,6 @@ def test_signtx_payment_req(
 
     params = dict(example_input_data["parameters"])
     params["payment_req"] = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=60,
         outputs=[(int(params["value"], 16), params["to_address"])],
@@ -799,7 +798,6 @@ def test_signtx_payment_req_long_value(
 
     params = dict(example_input_data_long_value["parameters"])
     params["payment_req"] = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=60,
         outputs=[(int(params["value"], 16), params["to_address"])],
@@ -816,7 +814,6 @@ def test_signtx_payment_req_long_value(
 
     params = dict(example_input_data_too_long_value["parameters"])
     params["payment_req"] = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=60,
         outputs=[(int(params["value"], 16), params["to_address"])],

### tests/device_tests/misc/test_msg_paymentnotification.py
@@ -39,7 +39,6 @@ def test_paymentnotification(session: Session):
 
     nonce = misc.get_nonce(session)
     payment_request = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=None,
         outputs=None,

### tests/device_tests/payment_req.py
@@ -4,7 +4,6 @@
 from ecdsa import NIST256p, SigningKey
 
 from trezorlib import messages
-from trezorlib.client import Session
 from trezorlib.tools import compact_size
 
 SLIP44_ID_UNDEFINED = 0xFFFF_FFFF
@@ -48,7 +47,6 @@ def hash_bytes_prefixed(hasher, data) -> None:
 
 
 def make_payment_request(
-    session: Session,
     recipient_name,
     slip44,
     outputs,

### tests/device_tests/ripple/test_sign_tx.py
@@ -148,7 +148,6 @@ def test_signtx_payment_req(session: Session):
     )
     nonce = misc.get_nonce(session)
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=144,
         outputs=[(msg.payment.amount, msg.payment.destination)],
@@ -184,7 +183,6 @@ def test_signtx_payment_req(session: Session):
     nonce = misc.get_nonce(session)
     address = f"{msg.payment.destination}?dt={msg.payment.destination_tag}"
     payment_req = make_payment_request(
-        session,
         recipient_name="trezor.io",
         slip44=144,
         outputs=[(msg.payment.amount, address)],

### tests/device_tests/solana/test_sign_tx.py
@@ -115,7 +115,6 @@ def test_solana_sign_tx(session: Session, parameters, result):
             memos = [purchase_memo, refund_memo, text_details_memo]
             nonce = misc.get_nonce(session)
             payment_request = make_payment_request(
-                session,
                 recipient_name="trezor.io",
                 slip44=501,
                 outputs=[

### tests/device_tests/stellar/test_stellar.py
@@ -108,7 +108,6 @@ def parameters_to_proto(session, parameters):
         memos = [purchase_memo, refund_memo, text_details_memo]
         nonce = misc.get_nonce(session)
         payment_request = make_payment_request(
-            session,
             recipient_name="trezor.io",
             slip44=148,
             outputs=[

Risk score

Why this scored 15/100

Our methodology →

Potential impact 0/30

Exploitability 0/25

Stealth signal 0/15

Affected reach 0/15

Confidence 10/10

Evidence quality 5/5

Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

What the developer wrote

What changed, and why it matters

Security signals we found

Evidence from the diff

Changed components

Why this scored 15/100

Community notes

Related watches

test(core/ethereum): EIP-7702 tuple nonce must be non-zero

build(core): propagate emulator feature from projects

refactor(core): digest EIP-1559/EIP-7702 magic without RLP encoding