What the developer wrote
Authored by Ioan Bizău
chore(ethereum): drop unused constants
[no changelog]
What changed, and why it matters
This commit simply removes two unused Ethereum address and chain-list constants from a Python file. There is no functional code change, no bug fix, and no security relevance.
No security action needed. This is a routine code-cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes the constants ONEINCH_ADDRESS and ONEINCH_CHAINS from core/src/apps/ethereum/clear_signing_definitions.py. No other code references these constants, so the change is purely cleanup. No logic, parsing, or trust assumptions are modified.
Changed components
core/src/apps/ethereum/clear_signing_definitions.pyInspect captured patch +0 / −18
diff --git a/core/src/apps/ethereum/clear_signing_definitions.py b/core/src/apps/ethereum/clear_signing_definitions.py
index 8adfca14..deb50ede 100644
--- a/core/src/apps/ethereum/clear_signing_definitions.py
+++ b/core/src/apps/ethereum/clear_signing_definitions.py
@@ -76,24 +76,6 @@ if __debug__:
ALL_DISPLAY_FORMATS = [APPROVE_DISPLAY_FORMAT, TRANSFER_DISPLAY_FORMAT]
-# https://github.com/LedgerHQ/clear-signing-erc7730-registry/blob/master/registry/1inch/calldata-AggregationRouterV6.json#L9
-ONEINCH_ADDRESS = unhexlify("111111125421cA6dc452d289314280a0f8842A65")
-ONEINCH_CHAINS = [
- 1,
- 10,
- 56,
- 100,
- 137,
- 146,
- 250,
- 8217,
- 8453,
- 42161,
- 43114,
- 59144,
- 1313161554,
-]
-
# https://github.com/LedgerHQ/clear-signing-erc7730-registry/blob/master/registry/lifi/calldata-LIFIDiamond.json
LIFI_ADDRESS = unhexlify("1231DEB6f5749EF6cE6943a275A1D3E7486F4EaE")
LIFI_CHAINS = [
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.