fix(tools): exception for English is no longer necessary in crowdin.py [no changelog]
What the developer wrote
Authored by Michal Kazda
fix(tools): exception for English is no longer necessary in crowdin.py
[no changelog]
What changed, and why it matters
This commit removes a small workaround in a translation-management script. Previously the script skipped English because English was added as a target language in the Crowdin translation platform, which produced empty English translation files that could overwrite the real English strings. The exception is no longer needed, so it was deleted. There is no security-relevant change visible in the diff.
No security action required. Treat as routine maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In core/translations/crowdin.py the merge() function used to skip lang == ‘en’ while merging translation JSON files, with a comment explaining that English ‘translations’ from Crowdin were empty and would overwrite en.json. The commit removes that skip. The change is purely a tooling cleanup in the localization workflow and does not alter device firmware, cryptographic, or privileged code paths.
Changed components
core/translations/crowdin.pyInspect captured patch +0 / −4
diff --git a/core/translations/crowdin.py b/core/translations/crowdin.py
index 03c85f90..3b7ab4d4 100644
--- a/core/translations/crowdin.py
+++ b/core/translations/crowdin.py
@@ -61,10 +61,6 @@ def merge() -> None:
return text
for lang in sorted(tdir.all_languages()):
- # No reason to process English "translations", they are empty and overwrite en.json
- # This is happening because English was added to Crowdin as a target language
- if lang == "en":
- continue
merged_translations: dict[str, str | dict[str, str]] = collections.defaultdict(dict)
for layout_type in translations.ALL_LAYOUTS:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.