fix(solana): correct misleading account labels in token instruction UI
What changed, and why it matters
This commit fixes incorrect on-screen labels shown to Trezor users when they confirm Solana token operations such as burning tokens, freezing accounts, minting tokens, or revoking a delegate. The labels wrongly described whose account or authority was involved, which could trick a user into approving a transaction they did not understand. The actual blockchain instructions and account handling were not changed—only the text the user sees on the device screen.
Treat as a low-to-moderate security fix and include in release notes. Users should upgrade firmware to obtain corrected labels. No immediate emergency response is warranted because transaction semantics and authorization were not altered, but the fix reduces social-engineering risk during Solana token transaction signing.
Security signals we found
UI label mismatch between displayed role and actual account role in Solana token instructions
Potential social-engineering / user-confusion risk leading to unintended transaction approval
Changelog fragment explicitly classifies the fix as a security issue
Commit references upstream issue #325 as partially fixed
No change to transaction parsing logic, signatures, or authorization checks
Evidence from the diff
The patch updates Solana SPL Token / Token-2022 UI definitions in common/defs/solana/programs.json, the generated programs.md, and core/src/apps/solana/transaction/instructions.py. It corrects misleading display_name strings: Burn now labels the owner as ‘Owner’ instead of ‘Mint authority’; FreezeAccount/ThawAccount label the freeze authority as ‘Freeze authority’ instead of ‘Owner’; MintToChecked labels the minting authority as ‘Mint authority’ instead of ‘Owner’; Revoke labels the source token account as ‘Revoke delegate for’ instead of ‘Revoke delegate’ and fixes a ‘Rewoke’ typo. A changelog fragment marks this as a security fix. The underlying instruction parsing and account roles are unchanged; only the human-readable labels are corrected.
Changed components
Trezor Core Solana app UIcommon/defs/solana/programs.jsoncommon/defs/solana/programs.mdcore/src/apps/solana/transaction/instructions.pySPL Token and Token-2022 instruction UI definitionsInspect captured patch +31 / −30
### common/defs/solana/programs.json
@@ -1264,7 +1264,7 @@
"ui_properties": [
{
"account": "source_account",
- "display_name": "Revoke delegate"
+ "display_name": "Revoke delegate for"
},
{
"account": "owner",
@@ -1386,7 +1386,7 @@
},
{
"account": "owner",
- "display_name": "Mint authority",
+ "display_name": "Owner",
"default_value_to_hide": "signer"
}
]
@@ -1440,7 +1440,7 @@
},
{
"account": "freeze_authority",
- "display_name": "Owner",
+ "display_name": "Freeze authority",
"default_value_to_hide": "signer"
}
]
@@ -1467,7 +1467,7 @@
},
{
"account": "freeze_authority",
- "display_name": "Owner",
+ "display_name": "Freeze authority",
"default_value_to_hide": "signer"
}
]
@@ -1615,7 +1615,7 @@
},
{
"account": "minting_authority",
- "display_name": "Owner",
+ "display_name": "Mint authority",
"default_value_to_hide": "signer"
}
]
@@ -1916,7 +1916,7 @@
"ui_properties": [
{
"account": "source_account",
- "display_name": "Rewoke delegate"
+ "display_name": "Revoke delegate for"
},
{
"account": "owner",
@@ -2038,7 +2038,7 @@
},
{
"account": "owner",
- "display_name": "Mint authority",
+ "display_name": "Owner",
"default_value_to_hide": "signer"
}
]
@@ -2092,7 +2092,7 @@
},
{
"account": "freeze_authority",
- "display_name": "Owner",
+ "display_name": "Freeze authority",
"default_value_to_hide": "signer"
}
]
@@ -2119,7 +2119,7 @@
},
{
"account": "freeze_authority",
- "display_name": "Owner",
+ "display_name": "Freeze authority",
"default_value_to_hide": "signer"
}
]
@@ -2267,7 +2267,7 @@
},
{
"account": "minting_authority",
- "display_name": "Owner",
+ "display_name": "Mint authority",
"default_value_to_hide": "signer"
}
]
### common/defs/solana/programs.md
@@ -333,7 +333,7 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
| Label | Value | Type |
|-------|-------|------|
-| Revoke delegate | `source_account` | `account` |
+| Revoke delegate for | `source_account` | `account` |
| Owner | `owner` | `account` |
### (6) Set Authority
@@ -361,7 +361,7 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
| Burn token | `token_mint` | `account` |
| Burn amount | `amount` | `u64` |
| From | `account_to_burn_from` | `account` |
-| Mint authority | `owner` | `account` |
+| Owner | `owner` | `account` |
### (9) Close Account
@@ -377,15 +377,15 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
|-------|-------|------|
| Freeze account | `account_to_freeze` | `account` |
| Token | `token_mint` | `account` |
-| Owner | `freeze_authority` | `account` |
+| Freeze authority | `freeze_authority` | `account` |
### (11) Thaw Account
| Label | Value | Type |
|-------|-------|------|
| Thaw account | `account_to_freeze` | `account` |
| Token | `token_mint` | `account` |
-| Owner | `freeze_authority` | `account` |
+| Freeze authority | `freeze_authority` | `account` |
### (12) Transfer Checked
@@ -416,7 +416,7 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
| Mint token | `mint` | `account` |
| Mint amount | `amount` | `token_amount` |
| To | `account_to_mint` | `account` |
-| Owner | `minting_authority` | `account` |
+| Mint authority | `minting_authority` | `account` |
| _(not shown)_ | `decimals` | `u8` |
### (15) Burn Checked
@@ -502,7 +502,7 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
| Label | Value | Type |
|-------|-------|------|
-| Rewoke delegate | `source_account` | `account` |
+| Revoke delegate for | `source_account` | `account` |
| Owner | `owner` | `account` |
### (6) Set Authority
@@ -530,7 +530,7 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
| Burn token | `token_mint` | `account` |
| Burn amount | `amount` | `u64` |
| From | `account_to_burn_from` | `account` |
-| Mint authority | `owner` | `account` |
+| Owner | `owner` | `account` |
### (9) Close Account
@@ -546,15 +546,15 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
|-------|-------|------|
| Freeze account | `account_to_freeze` | `account` |
| Token | `token_mint` | `account` |
-| Owner | `freeze_authority` | `account` |
+| Freeze authority | `freeze_authority` | `account` |
### (11) Thaw Account
| Label | Value | Type |
|-------|-------|------|
| Thaw account | `account_to_freeze` | `account` |
| Token | `token_mint` | `account` |
-| Owner | `freeze_authority` | `account` |
+| Freeze authority | `freeze_authority` | `account` |
### (12) Transfer Checked
@@ -585,7 +585,7 @@ _This file is generated by `programs.md.mako` via `make solana_templates`, do no
| Mint token | `mint` | `account` |
| Mint amount | `amount` | `token_amount` |
| To | `account_to_mint` | `account` |
-| Owner | `minting_authority` | `account` |
+| Mint authority | `minting_authority` | `account` |
| _(not shown)_ | `decimals` | `u8` |
### (15) Burn Checked
### core/.changelog.d/+solana_ui_labels.security
@@ -0,0 +1 @@
+Solana: Fixed misleading account labels in Token program instructions.
### core/src/apps/solana/transaction/instructions.py
@@ -2634,7 +2634,7 @@ def get_instruction(
UIProperty(
None,
"source_account",
- "Revoke delegate",
+ "Revoke delegate for",
None,
),
UIProperty(
@@ -2797,7 +2797,7 @@ def get_instruction(
UIProperty(
None,
"owner",
- "Mint authority",
+ "Owner",
"signer",
),
),
@@ -2869,7 +2869,7 @@ def get_instruction(
UIProperty(
None,
"freeze_authority",
- "Owner",
+ "Freeze authority",
"signer",
),
),
@@ -2905,7 +2905,7 @@ def get_instruction(
UIProperty(
None,
"freeze_authority",
- "Owner",
+ "Freeze authority",
"signer",
),
),
@@ -3088,7 +3088,7 @@ def get_instruction(
UIProperty(
None,
"minting_authority",
- "Owner",
+ "Mint authority",
"signer",
),
),
@@ -3501,7 +3501,7 @@ def get_instruction(
UIProperty(
None,
"source_account",
- "Rewoke delegate",
+ "Revoke delegate for",
None,
),
UIProperty(
@@ -3664,7 +3664,7 @@ def get_instruction(
UIProperty(
None,
"owner",
- "Mint authority",
+ "Owner",
"signer",
),
),
@@ -3736,7 +3736,7 @@ def get_instruction(
UIProperty(
None,
"freeze_authority",
- "Owner",
+ "Freeze authority",
"signer",
),
),
@@ -3772,7 +3772,7 @@ def get_instruction(
UIProperty(
None,
"freeze_authority",
- "Owner",
+ "Freeze authority",
"signer",
),
),
@@ -3955,7 +3955,7 @@ def get_instruction(
UIProperty(
None,
"minting_authority",
- "Owner",
+ "Mint authority",
"signer",
),
),Why this scored 53/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.