AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 53 Bitcoin

fix(solana): correct misleading account labels in token instruction UI

Public commit record

What the developer wrote

Authored by Jakub Janků

93/100 · Strong
fix(solana): correct misleading account labels in token instruction UI

Fix wrong role labels in the SPL Token / Token 2022 UI definitions
(the classic Token Program declares identical account lists):

- Burn: "Mint authority" -> "Owner" (the account is the owner/delegate)
https://docs.rs/spl-token-2022-interface/3.1.1/spl_token_2022_interface/instruction/enum.TokenInstruction.html#variant.Burn
- Freeze/Thaw Account: "Owner" -> "Freeze authority"
https://docs.rs/spl-token-2022-interface/3.1.1/spl_token_2022_interface/instruction/enum.TokenInstruction.html#variant.FreezeAccount
- Mint to Checked: "Owner" -> "Mint authority"
https://docs.rs/spl-token-2022-interface/3.1.1/spl_token_2022_interface/instruction/enum.TokenInstruction.html#variant.MintToChecked
- Revoke: "Revoke delegate" -> "Revoke delegate for" (the shown account
is the source token account, not the delegate); also fix "Rewoke" typo
https://docs.rs/spl-token-2022-interface/3.1.1/spl_token_2022_interface/instruction/enum.TokenInstruction.html#variant.Revoke

Paritally fixes: https://github.com/satoshilabs/trezor-firmware/issues/325

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit e38b1ac28b1ebef85166360c3e1db1192d4b0699)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes incorrect on-screen labels shown to Trezor users when they confirm Solana token operations such as burning tokens, freezing accounts, minting tokens, or revoking a delegate. The labels wrongly described whose account or authority was involved, which could trick a user into approving a transaction they did not understand. The actual blockchain instructions and account handling were not changed—only the text the user sees on the device screen.

Recommended action

Treat as a low-to-moderate security fix and include in release notes. Users should upgrade firmware to obtain corrected labels. No immediate emergency response is warranted because transaction semantics and authorization were not altered, but the fix reduces social-engineering risk during Solana token transaction signing.

Security signals we found

01

UI label mismatch between displayed role and actual account role in Solana token instructions

02

Potential social-engineering / user-confusion risk leading to unintended transaction approval

03

Changelog fragment explicitly classifies the fix as a security issue

04

Commit references upstream issue #325 as partially fixed

05

No change to transaction parsing logic, signatures, or authorization checks

Risk score

Why this scored 53/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 11/15
Affected reach 8/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.