fix(core): remove fstrings from Delizia Eckhart [no changelog]
What the developer wrote
Authored by Michal Kazda
fix(core): remove fstrings from Delizia Eckhart
[no changelog]
What changed, and why it matters
This commit removes colon characters from the ends of a few on-screen labels in the Trezor hardware wallet's user interface. For example, labels that previously read 'Amount:' now read 'Amount'. There is no security-relevant change visible in the code.
No security action needed. Treat as a routine UI consistency/cosmetic change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch changes eight Python f-string expressions into plain translation-string references across two UI layout modules (Delizia and Eckhart). In each case the only difference is dropping a trailing colon that was hard-coded after a translated word. No logic, parsing, formatting, or trust boundary changes are present.
Changed components
core/src/trezor/ui/layouts/delizia/__init__.pycore/src/trezor/ui/layouts/eckhart/__init__.pyInspect captured patch +8 / −8
diff --git a/core/src/trezor/ui/layouts/delizia/__init__.py b/core/src/trezor/ui/layouts/delizia/__init__.py
index ecd621e3..1e12e273 100644
--- a/core/src/trezor/ui/layouts/delizia/__init__.py
+++ b/core/src/trezor/ui/layouts/delizia/__init__.py
@@ -825,7 +825,7 @@ def confirm_amount(
br_name: str = "confirm_amount",
br_code: ButtonRequestType = BR_CODE_OTHER,
) -> Awaitable[ui.UiResult]:
- description = description or f"{TR.words__amount}:" # def_arg
+ description = description or TR.words__amount # def_arg
return confirm_value(
title,
amount,
@@ -1670,7 +1670,7 @@ if not utils.BITCOIN_ONLY:
br_code: ButtonRequestType = ButtonRequestType.SignTx,
) -> Awaitable[None]:
amount_title = (
- amount_title if amount_title is not None else f"{TR.words__amount}:"
+ amount_title if amount_title is not None else TR.words__amount
) # def_arg
fee_title = fee_title or TR.words__fee # def_arg
return _confirm_summary(
@@ -2012,7 +2012,7 @@ if not utils.BITCOIN_ONLY:
properties: list[StrPropertyType] = [
summary_view,
- (f"{TR.words__chain}:", "Tron", True),
+ (TR.words__chain, "Tron", True),
]
await confirm_properties(
@@ -2110,7 +2110,7 @@ async def confirm_modify_output(
value=address,
verb=TR.buttons__continue,
verb_cancel=None,
- description=f"{TR.words__address}:",
+ description=TR.words__address,
)
modify_ctx = trezorui_api.confirm_modify_output(
sign=sign,
diff --git a/core/src/trezor/ui/layouts/eckhart/__init__.py b/core/src/trezor/ui/layouts/eckhart/__init__.py
index d782930f..7a3b7a59 100644
--- a/core/src/trezor/ui/layouts/eckhart/__init__.py
+++ b/core/src/trezor/ui/layouts/eckhart/__init__.py
@@ -826,7 +826,7 @@ def confirm_amount(
br_name: str = "confirm_amount",
br_code: ButtonRequestType = BR_CODE_OTHER,
) -> Awaitable[None]:
- description = description or f"{TR.words__send}:" # def_arg
+ description = description or TR.words__send # def_arg
return confirm_value(
title,
amount,
@@ -1732,7 +1732,7 @@ if not utils.BITCOIN_ONLY:
br_code: ButtonRequestType = ButtonRequestType.SignTx,
) -> Awaitable[None]:
amount_title = (
- amount_title if amount_title is not None else f"{TR.words__amount}:"
+ amount_title if amount_title is not None else TR.words__amount
) # def_arg
fee_title = fee_title or TR.words__fee # def_arg
return _confirm_summary(
@@ -2051,7 +2051,7 @@ if not utils.BITCOIN_ONLY:
properties: Iterable[StrPropertyType] = (
(
- f"{TR.words__amount}:",
+ TR.words__amount,
amount_str,
False,
),
@@ -2119,7 +2119,7 @@ if not utils.BITCOIN_ONLY:
properties: list[StrPropertyType] = [
summary_view,
- (f"{TR.words__chain}:", "Tron", True),
+ (TR.words__chain, "Tron", True),
]
await confirm_properties(
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.