← Watch feed
chore(core): drop unused `trezorui_api.show_wait_text()`
Public commit record
62/100 · Adequate
What the developer wrote
Authored by Roman Zeyde
chore(core): drop unused `trezorui_api.show_wait_text()`
[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
What changed, and why it matters
This commit simply removes an unused on-screen message function called show_wait_text() from the Trezor firmware. There is no security fix or behavior change; it is a routine code cleanup.
Recommended action
No security action needed. Treat as normal code hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the show_wait_text() API and its implementations across all UI layouts (bolt, caesar, delizia, eckhart). It removes the corresponding qstr, Micropython binding, trait method, mock stub, and Python wrappers. No callers are modified, indicating the function was already unused. No vulnerability is introduced or patched.
Changed components
core/embed/rust/librust_qstr.hcore/embed/rust/src/ui/api/firmware_micropython.rscore/embed/rust/src/ui/layout_bolt/ui_firmware.rscore/embed/rust/src/ui/layout_caesar/ui_firmware.rscore/embed/rust/src/ui/layout_delizia/ui_firmware.rscore/embed/rust/src/ui/layout_eckhart/ui_firmware.rscore/embed/rust/src/ui/ui_firmware.rscore/mocks/generated/trezorui_api.pyicore/src/trezor/ui/layouts/bolt/__init__.pycore/src/trezor/ui/layouts/caesar/__init__.pycore/src/trezor/ui/layouts/delizia/__init__.pycore/src/trezor/ui/layouts/eckhart/__init__.pyInspect captured patch +0 / −66
diff --git a/core/embed/rust/librust_qstr.h b/core/embed/rust/librust_qstr.h
index fcaae7b3..8b8b8254 100644
--- a/core/embed/rust/librust_qstr.h
+++ b/core/embed/rust/librust_qstr.h
@@ -868,7 +868,6 @@ static void _librust_qstrs(void) {
MP_QSTR_show_simple;
MP_QSTR_show_success;
MP_QSTR_show_thp_pairing_code;
- MP_QSTR_show_wait_text;
MP_QSTR_show_warning;
MP_QSTR_sign;
MP_QSTR_sign_message__bytes_template;
diff --git a/core/embed/rust/src/ui/api/firmware_micropython.rs b/core/embed/rust/src/ui/api/firmware_micropython.rs
index 37a430b5..ff3313da 100644
--- a/core/embed/rust/src/ui/api/firmware_micropython.rs
+++ b/core/embed/rust/src/ui/api/firmware_micropython.rs
@@ -1263,17 +1263,6 @@ extern "C" fn new_show_success(n_args: usize, args: *const Obj, kwargs: *mut Map
unsafe { util::try_with_args_and_kwargs(n_args, args, kwargs, block) }
}
-extern "C" fn new_show_wait_text(message: Obj) -> Obj {
- let block = || {
- let message: TString<'static> = message.try_into()?;
-
- let layout = ModelUI::show_wait_text(message)?;
- Ok(LayoutObj::new_root(layout)?.into())
- };
-
- unsafe { util::try_or_raise(block) }
-}
-
extern "C" fn new_show_warning(n_args: usize, args: *const Obj, kwargs: *mut Map) -> Obj {
let block = move |_args: &[Obj], kwargs: &Map| {
let title: Option<TString> = kwargs.get(Qstr::MP_QSTR_title)?.try_into_option()?;
@@ -2152,10 +2141,6 @@ pub static mp_module_trezorui_api: Module = obj_module! {
/// """Success modal. No buttons shown when `button` is empty string."""
Qstr::MP_QSTR_show_success => obj_fn_kw!(0, new_show_success).as_obj(),
- /// def show_wait_text(message: str, /) -> LayoutObj[None]:
- /// """Show single-line text in the middle of the screen."""
- Qstr::MP_QSTR_show_wait_text => obj_fn_1!(new_show_wait_text).as_obj(),
-
/// def show_warning(
/// *,
/// title: str | None,
diff --git a/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs b/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs
index f0803b51..f687fd5d 100644
--- a/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs
@@ -1265,12 +1265,6 @@ impl FirmwareUI for UIBolt {
)
}
- fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- Ok(RootComponent::new(
- Paragraph::new(&theme::TEXT_NORMAL, text).into_paragraphs(),
- ))
- }
-
fn show_warning(
title: Option<TString<'static>>,
button: TString<'static>,
diff --git a/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs b/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
index bd6e5af2..1d005e52 100644
--- a/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
@@ -1362,12 +1362,6 @@ impl FirmwareUI for UICaesar {
Err::<Gc<LayoutObj>, Error>(Error::NotImplementedError)
}
- fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- Ok(RootComponent::new(
- Paragraph::new(&theme::TEXT_NORMAL, text).into_paragraphs(),
- ))
- }
-
fn show_warning(
title: Option<TString<'static>>,
button: TString<'static>,
diff --git a/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs b/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
index 6397cbf8..2819190d 100644
--- a/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
@@ -1227,12 +1227,6 @@ impl FirmwareUI for UIDelizia {
Ok(layout)
}
- fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- Ok(RootComponent::new(
- Paragraph::new(&theme::TEXT_DEMIBOLD, text).into_paragraphs(),
- ))
- }
-
fn show_warning(
title: Option<TString<'static>>,
button: TString<'static>,
diff --git a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
index 1b5f490a..c690dad1 100644
--- a/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_eckhart/ui_firmware.rs
@@ -1542,15 +1542,6 @@ impl FirmwareUI for UIEckhart {
Ok(layout)
}
- fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- let paragraphs = Paragraph::new(&theme::TEXT_REGULAR, text)
- .into_paragraphs()
- .with_placement(LinearPlacement::vertical());
- let screen = TextScreen::new(paragraphs);
- let layout = RootComponent::new(screen);
- Ok(layout)
- }
-
fn show_warning(
title: Option<TString<'static>>,
button: TString<'static>,
diff --git a/core/embed/rust/src/ui/ui_firmware.rs b/core/embed/rust/src/ui/ui_firmware.rs
index df283594..01f7564d 100644
--- a/core/embed/rust/src/ui/ui_firmware.rs
+++ b/core/embed/rust/src/ui/ui_firmware.rs
@@ -462,8 +462,6 @@ pub trait FirmwareUI {
time_ms: u32,
) -> Result<Gc<LayoutObj>, Error>; // TODO: return LayoutMaybeTrace
- fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error>;
-
fn show_warning(
title: Option<TString<'static>>,
button: TString<'static>,
diff --git a/core/mocks/generated/trezorui_api.pyi b/core/mocks/generated/trezorui_api.pyi
index 7af02aa2..43137d5b 100644
--- a/core/mocks/generated/trezorui_api.pyi
+++ b/core/mocks/generated/trezorui_api.pyi
@@ -827,11 +827,6 @@ def show_success(
"""Success modal. No buttons shown when `button` is empty string."""
-# rust/src/ui/api/firmware_micropython.rs
-def show_wait_text(message: str, /) -> LayoutObj[None]:
- """Show single-line text in the middle of the screen."""
-
-
# rust/src/ui/api/firmware_micropython.rs
def show_warning(
*,
diff --git a/core/src/trezor/ui/layouts/bolt/__init__.py b/core/src/trezor/ui/layouts/bolt/__init__.py
index 25f3d56d..c69339c4 100644
--- a/core/src/trezor/ui/layouts/bolt/__init__.py
+++ b/core/src/trezor/ui/layouts/bolt/__init__.py
@@ -2192,10 +2192,6 @@ def request_passphrase_on_host() -> None:
draw_simple(trezorui_api.show_simple(title=None, text=TR.passphrase__please_enter))
-def show_wait_text(message: str) -> None:
- draw_simple(trezorui_api.show_wait_text(message))
-
-
async def request_passphrase_on_device(max_len: int) -> str:
with trezorui_api.request_passphrase(
prompt=TR.passphrase__title_enter,
diff --git a/core/src/trezor/ui/layouts/caesar/__init__.py b/core/src/trezor/ui/layouts/caesar/__init__.py
index bbd3a68d..38000e5c 100644
--- a/core/src/trezor/ui/layouts/caesar/__init__.py
+++ b/core/src/trezor/ui/layouts/caesar/__init__.py
@@ -2230,10 +2230,6 @@ def request_passphrase_on_host() -> None:
draw_simple(trezorui_api.show_simple(title=None, text=TR.passphrase__please_enter))
-def show_wait_text(message: str) -> None:
- draw_simple(trezorui_api.show_wait_text(message))
-
-
async def request_passphrase_on_device(max_len: int) -> str:
with trezorui_api.request_passphrase(
prompt=TR.passphrase__title_enter,
diff --git a/core/src/trezor/ui/layouts/delizia/__init__.py b/core/src/trezor/ui/layouts/delizia/__init__.py
index 91316518..8d551511 100644
--- a/core/src/trezor/ui/layouts/delizia/__init__.py
+++ b/core/src/trezor/ui/layouts/delizia/__init__.py
@@ -2187,10 +2187,6 @@ def request_passphrase_on_host() -> None:
draw_simple(trezorui_api.show_simple(title=None, text=TR.passphrase__please_enter))
-def show_wait_text(message: str) -> None:
- draw_simple(trezorui_api.show_wait_text(message))
-
-
async def request_passphrase_on_device(max_len: int) -> str:
with trezorui_api.request_passphrase(
prompt=TR.passphrase__title_enter,
diff --git a/core/src/trezor/ui/layouts/eckhart/__init__.py b/core/src/trezor/ui/layouts/eckhart/__init__.py
index 273c709a..a96543be 100644
--- a/core/src/trezor/ui/layouts/eckhart/__init__.py
+++ b/core/src/trezor/ui/layouts/eckhart/__init__.py
@@ -2309,10 +2309,6 @@ def request_passphrase_on_host() -> None:
draw_simple(trezorui_api.show_simple(title=None, text=TR.passphrase__please_enter))
-def show_wait_text(message: str) -> None:
- draw_simple(trezorui_api.show_wait_text(message))
-
-
async def request_passphrase_on_device(max_len: int) -> str:
with trezorui_api.request_passphrase(
prompt=TR.passphrase__title_enter,
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.