fix(ci): use both runners for HW tests of T2B1 [no changelog]
What changed, and why it matters
This commit is a routine GitHub Actions CI configuration fix. It changes which physical hardware test runner is used for one Trezor device model (T2B1) so that both runners are used again. There is no change to firmware code, cryptography, user data handling, or anything an attacker could exploit.
No security action needed; this is a CI infrastructure housekeeping change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates .github/workflows/core-hw.yml, replacing a temporary runner label ‘runner3’ with the intended label ‘hw-t2b1’ for T2B1 hardware-in-the-loop tests. It removes two FIXME comments noting that runner4 with t2b1 was not working. The second job remains disabled (if: … && false). This is purely an infrastructure/CI maintenance change with no product-code modifications.
Changed components
.github/workflows/core-hw.ymlInspect captured patch +2 / −4
diff --git a/.github/workflows/core-hw.yml b/.github/workflows/core-hw.yml
index dbed2c7a..e16b58e0 100644
--- a/.github/workflows/core-hw.yml
+++ b/.github/workflows/core-hw.yml
@@ -55,8 +55,7 @@ jobs:
needs: param
runs-on:
- self-hosted
- # FIXME runner4 with t2b1 does not work at the moment
- - ${{ matrix.model == 'T2B1' && 'runner3' || matrix.model == 'T3T1' && 'hw-t3t1' || matrix.model == 'T3B1' && 'hw-t3b1' || matrix.model == 'T3W1' && 'hw-t3w1' || 'hw-t2t1' }}
+ - ${{ matrix.model == 'T2B1' && 'hw-t2b1' || matrix.model == 'T3T1' && 'hw-t3t1' || matrix.model == 'T3B1' && 'hw-t3b1' || matrix.model == 'T3W1' && 'hw-t3w1' || 'hw-t2t1' }}
if: needs.param.outputs.core_models != '[]'
strategy:
fail-fast: false
@@ -116,8 +115,7 @@ jobs:
needs: param
runs-on:
- self-hosted
- # FIXME runner4 with t2b1 does not work at the moment
- - ${{ matrix.model == 'T2B1' && 'runner3' || matrix.model == 'T3T1' && 'hw-t3t1' || matrix.model == 'T3B1' && 'hw-t3b1' || matrix.model == 'T3W1' && 'hw-t3w1' || 'hw-t2t1' }}
+ - ${{ matrix.model == 'T2B1' && 'hw-t2b1' || matrix.model == 'T3T1' && 'hw-t3t1' || matrix.model == 'T3B1' && 'hw-t3b1' || matrix.model == 'T3W1' && 'hw-t3w1' || 'hw-t2t1' }}
if: needs.param.outputs.core_models != '[]' && false # FIXME https://github.com/trezor/trezor-firmware/issues/3128
strategy:
fail-fast: false
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.