CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

fix(core): logic error in `ToifInfo::parse`

TZ368d6203 View source ↗
Public commit record

What the developer wrote

Authored by obrusvit

82/100 · Strong
fix(core): logic error in `ToifInfo::parse`

- device test wrong TOIF prefix
- chore: rename relevant test functions to caesar

[no changelog]
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit fixes a logic bug in how the Trezor hardware wallet checks image files used as custom home screens. The old code accidentally accepted almost any image as valid because it used 'AND' instead of 'OR' when checking the file's magic bytes. The patch corrects the check so only proper TOIF images are accepted. It also removes a size-limit check on the stored homescreen, which is a separate hardening concern.

Recommended action

Review whether removing the HOMESCREEN_MAXSIZE limit is intentional and safe, since the commit message only mentions the TOIF parsing fix. Confirm that downstream TOIF parsing or rendering imposes its own bounds to prevent oversized or malformed homescreen payloads from being stored or rendered. Otherwise, ship the TOIF prefix fix promptly.

Security signals we found

01

Logic error in format/magic-byte validation

02

Input validation bypass for custom homescreen images

03

Removal of an input size limit for stored homescreen data

04

New negative test added for invalid TOIF prefix

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 19 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

feat(core): support dev-signed definitions on non-production builds

This commit moves the public keys used to verify coin/token definitions from Python code into a new Rust module. It also makes development-signed definitions accepted on non-production builds, similar to an existing feature for translation…

Moved signature verification of external token/coin definitions from Python to RustAdded development-key fallback gated by `#[cfg(feature = "dev_keys")]`Removed `__debug__`-gated dev-key acceptance from Python; replaced with feature-gated Rust fallback
3006c023by Roman Zeyde+115−5212 files
No security note in commit
Open full analysis →Source commit ↗
Informational 12 AI analysisMessage 47 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core): update fixtures

This commit only refreshes test data files: it updates a translation signature metadata file and regenerates UI test fixtures. There is no code change, no security fix, and no indication of a vulnerability being addressed.

b30af88eby Michal Kazda+598−5982 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(translations): sync Crowdin translations

This commit only updates translated text strings in Czech, German, and Spanish language files, plus the corresponding translation signature metadata. There are no code, logic, or security-related changes.

82264593by Thalarion+30−304 files
No security note in commit
Open full analysis →Source commit ↗