What the developer wrote
Authored by Michal Kazda
fix(core): remove unused confirm_amount
[no changelog]
What changed, and why it matters
This commit simply deletes an unused helper function called confirm_amount from four different user-interface layout files. Because the function was not being called anywhere, removing it cannot change device behavior or introduce a security issue. It is a routine code cleanup.
No security action needed. Treat as normal maintenance/cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes the confirm_amount() wrapper from bolt, caesar, delizia, and eckhart UI layout modules. Each wrapper merely delegated to confirm_value() or confirm_blob() with a default description. No call sites are modified, and the commit message explicitly states the function is unused. There is no functional or security-relevant change.
Changed components
core/src/trezor/ui/layouts/bolt/__init__.pycore/src/trezor/ui/layouts/caesar/__init__.pycore/src/trezor/ui/layouts/delizia/__init__.pycore/src/trezor/ui/layouts/eckhart/__init__.pyInspect captured patch +0 / −72
### core/src/trezor/ui/layouts/bolt/__init__.py
@@ -830,24 +830,6 @@ def confirm_text(
)
-def confirm_amount(
- title: str,
- amount: str,
- description: str | None = None,
- br_name: str = "confirm_amount",
- br_code: ButtonRequestType = BR_CODE_OTHER,
-) -> Awaitable[None]:
- description = description or with_colon(TR.words__amount) # def_arg
- return confirm_value(
- title,
- amount,
- description,
- br_name,
- br_code,
- verb=TR.buttons__confirm,
- )
-
-
async def confirm_value(
title: str,
value: str,
### core/src/trezor/ui/layouts/caesar/__init__.py
@@ -894,25 +894,6 @@ def confirm_text(
)
-def confirm_amount(
- title: str,
- amount: str,
- description: str | None = None,
- br_name: str = "confirm_amount",
- br_code: ButtonRequestType = BR_CODE_OTHER,
-) -> Awaitable[None]:
- from ..properties import with_colon
-
- description = description or with_colon(TR.words__amount) # def_arg
- return confirm_blob(
- br_name,
- title,
- amount,
- description,
- br_code=br_code,
- )
-
-
async def confirm_properties(
br_name: str,
title: str,
### core/src/trezor/ui/layouts/delizia/__init__.py
@@ -819,24 +819,6 @@ def confirm_text(
)
-def confirm_amount(
- title: str,
- amount: str,
- description: str | None = None,
- br_name: str = "confirm_amount",
- br_code: ButtonRequestType = BR_CODE_OTHER,
-) -> Awaitable[ui.UiResult]:
- description = description or TR.words__amount # def_arg
- return confirm_value(
- title,
- amount,
- description,
- br_name,
- br_code,
- verb=TR.buttons__confirm,
- )
-
-
async def confirm_value(
title: str,
value: str,
### core/src/trezor/ui/layouts/eckhart/__init__.py
@@ -822,23 +822,6 @@ def confirm_text(
)
-def confirm_amount(
- title: str,
- amount: str,
- description: str | None = None,
- br_name: str = "confirm_amount",
- br_code: ButtonRequestType = BR_CODE_OTHER,
-) -> Awaitable[None]:
- description = description or TR.words__send # def_arg
- return confirm_value(
- title,
- amount,
- description,
- br_name,
- br_code,
- )
-
-
async def confirm_value(
title: str,
value: StrOrBytes,Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.