CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 18 Bitcoin

refactor(core/ethereum): simplify empty calldata handling

TZ1580e435 View source ↗
Public commit record

What the developer wrote

Authored by Roman Zeyde

85/100 · Strong
refactor(core/ethereum): simplify empty calldata handling

No need to call `get_progress_indicator()` if there is not calldata.
We don't need to confirm/hash it as well.

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This is a small code cleanup in Trezor's Ethereum transaction signing. When an Ethereum transaction has no extra data (calldata), the device no longer runs a now-unnecessary progress-indicator step. This only changes the user-interface flow for no-data transactions; it does not change what is signed or how the signature is computed. The large diff is mostly updated test screenshot fingerprints (hashes) reflecting the changed on-screen sequence.

Recommended action

No security action required. Treat as a normal refactor. If reviewing, verify that the no-data path still reaches require_confirm_tx() and that the resulting signed transaction hashes match previous versions for identical inputs.

Security signals we found

01

Behavioral change limited to empty-calldata Ethereum transactions

02

No change to transaction hashing, RLP encoding, or signature algorithm

03

No input validation, bounds checking, or cryptographic code modified

04

UI test fixture hashes updated consistently across locales for no-data cases

05

Commit message explicitly frames change as a refactor with no changelog

Risk score

Why this scored 18/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 3/15
Confidence 8/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove sha1 from regular FW

This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…

Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
16d15774by M1nd3r+0−2006 files
No security note in commit
Open full analysis →Source commit ↗
Low 27 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…

Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
1b3128a4by Ondřej Vejpustek+20−92 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): change order of parameters

This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.

33a119eeby Ondřej Vejpustek+15−151 file
No security note in commit
Open full analysis →Source commit ↗