AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 61 Bitcoin

fix(solana): instruction data misalignment

Public commit record

What the developer wrote

Authored by Jakub Janků

80/100 · Strong
fix(solana): instruction data misalignment

When an instruction's data was shorter than its program's instruction
id (1-3 bytes for System and Stake), the data was left unread and parsed
as the next instruction. The parser now reads the whole data, and the
instruction id is split off when the instructions are created, where
the program is known. Such an instruction is shown as unsupported.

[no changelog]

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a bug in how Trezor's Solana app read transaction instructions. Previously, if an instruction's data was shorter than its expected ID header, the parser skipped reading the data entirely and treated leftover bytes as the next instruction. That could misalign the whole instruction stream and potentially trick the device into showing or signing a different transaction than the user expects. The fix reads the full data first and only splits off the instruction ID later, marking too-short data as unsupported so it requires blind signing.

Recommended action

Treat this as a security-relevant parser hardening fix. Review whether the misalignment could have been exploited in practice to bypass UI warnings or induce unintended signatures, and consider whether a security advisory or firmware release note is warranted. Ensure the new blind-signing path cannot be abused to silently downgrade supported instructions.

Security signals we found

01

Parser misalignment when instruction data shorter than expected instruction-id length

02

Unread bytes re-parsed as next instruction, risking incorrect transaction interpretation

03

Fix moves instruction-id parsing to a later stage after full data is captured

04

Short-data instructions now classified as unsupported and trigger blind signing

05

New unit tests cover both normal and malformed short-data cases

Risk score

Why this scored 61/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.