What the developer wrote
Authored by M1nd3r
fix: style
[no changelog]
What changed, and why it matters
This commit is a pure code-style cleanup in the Ethereum 'clear signing' module. It removes unnecessary extra parentheses around tuple unpacking assignments. There is no functional change, no security fix, and no behavior change to the hardware wallet's transaction handling.
No security action required. Treat as routine style/maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies four lines in core/src/apps/ethereum/clear_signing.py, changing nested tuple unpacking from ((name, value, _), _, _) = fields[N] to (name, value, _), _, _ = fields[N]. This is a syntactic simplification only; the assigned variables, assertions, and downstream logic are identical. No security relevance is evident from the diff or commit metadata.
Changed components
core/src/apps/ethereum/clear_signing.pyInspect captured patch +4 / −4
diff --git a/core/src/apps/ethereum/clear_signing.py b/core/src/apps/ethereum/clear_signing.py
index ee6eb87a..197e1a80 100644
--- a/core/src/apps/ethereum/clear_signing.py
+++ b/core/src/apps/ethereum/clear_signing.py
@@ -761,13 +761,13 @@ async def _handle_approve(
assert len(fields) == 2
arg0_raw_value = args[0]
- ((field0_name, recipient_addr, _), _, _) = fields[0]
+ (field0_name, recipient_addr, _), _, _ = fields[0]
assert field0_name == "Spender"
assert isinstance(arg0_raw_value, bytes)
assert isinstance(recipient_addr, str)
arg1_raw_value = args[1]
- ((field1_name, value, _), _, _) = fields[1]
+ (field1_name, value, _), _, _ = fields[1]
assert field1_name == "Amount"
assert isinstance(arg1_raw_value, int)
@@ -810,13 +810,13 @@ async def _handle_transfer(
assert len(args) == 2
assert len(fields) == 2
- ((arg0_name, recipient_addr, _), _, _) = fields[0]
+ (arg0_name, recipient_addr, _), _, _ = fields[0]
assert arg0_name == "To"
assert isinstance(recipient_addr, str)
arg1_raw_value = args[1]
assert isinstance(arg1_raw_value, int)
- ((arg1_name, value, _), _, _) = fields[1]
+ (arg1_name, value, _), _, _ = fields[1]
assert arg1_name == "Amount"
assert isinstance(value, str)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.