fix attachment link opening on desktop
What changed, and why it matters
This is a one-line UI bug fix for opening attachment links on desktop versions of the Stack Wallet app. The change tells the app to use the root navigator on desktop when displaying an 'Opening attachment' progress indicator. There is no indication this fixes a security vulnerability; it appears to address a navigation/display issue specific to desktop layouts.
No security action required. Treat as a normal UI/UX bug fix. If reviewing for security, verify separately that `_resolveAndLaunch` validates attachment URLs before launching them, as this commit does not modify that behavior.
Security signals we found
No security-related keywords in commit title or message
Single-line UI/navigation parameter change
No input validation, parsing, or trust-boundary changes
No changes to URL handling, launching, or attachment resolution logic
Evidence from the diff
The commit adds rootNavigator: Util.isDesktop to a whileFuture call in _AttachmentFileLink. This Flutter navigation parameter controls which Navigator is used to show the loading overlay/dialog. On desktop, using the root navigator likely prevents the progress indicator from being displayed within a nested navigator where it would be hidden or behave incorrectly. The underlying attachment launch logic (_resolveAndLaunch) is unchanged.
Changed components
lib/pages/shopinbit/shopinbit_ticket_detail.dartShopInBit ticket attachment link UIInspect captured patch +1 / −0
diff --git a/lib/pages/shopinbit/shopinbit_ticket_detail.dart b/lib/pages/shopinbit/shopinbit_ticket_detail.dart
index e71757b..f4a7190 100644
--- a/lib/pages/shopinbit/shopinbit_ticket_detail.dart
+++ b/lib/pages/shopinbit/shopinbit_ticket_detail.dart
@@ -830,6 +830,7 @@ class _AttachmentFileLink extends ConsumerWidget {
whileFuture: _resolveAndLaunch(ref),
context: context,
message: "Opening attachment",
+ rootNavigator: Util.isDesktop,
onException: (e) {
Logging.instance.w("ShopInBit open attachment failed", error: e);
showFloatingFlushBar(
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.