AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Monero

Merge pull request #1528 from cypherstack/fix/taproot-input-sequence

Public commit record

What the developer wrote

Authored by Julian

73/100 · Adequate
Merge pull request #1528 from cypherstack/fix/taproot-input-sequence

Preserve input sequence for Taproot key-path spends
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a bug in how Taproot (a modern Bitcoin-style transaction format) inputs were being built. Previously, the 'sequence number'—a field that controls things like time-locks and replacement rules—was being dropped for Taproot key-path spends and silently reset to a default value. That could break intended transaction behavior such as time-locked refunds or Replace-By-Fee (RBF), and in some wallet designs could even make a transaction spendable under different conditions than the user expected. The fix simply passes the intended sequence number through when creating the Taproot input.

Recommended action

Review whether any already-signed or broadcast Taproot transactions were affected by the dropped sequence, especially those relying on RBF or timelocks. Add regression tests covering sequence preservation for all DerivePathType branches, including bip86. Consider auditing other Taproot-specific code paths for similar omissions.

Security signals we found

01

Missing nSequence preservation for Taproot key-path inputs

02

Behavioral divergence between Taproot and other input types in the same switch

03

Potential for unintended transaction semantics (RBF, timelocks) due to default sequence value

04

Fix is a one-line parameter pass-through, indicating an omission rather than a design change

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.