split full name into separate fields for first and last name
What changed, and why it matters
This commit simply changes the user interface for entering a billing/shipping name. Instead of one 'Full name' text box that the app later tried to split into first and last names, it now shows two separate boxes labeled 'First name' and 'Last name'. There is no security fix or vulnerability here; it is a routine UI and data-handling refactor.
No security action required. Treat as a normal UI/data-quality refactor during routine review.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch refactors two ShopInBit checkout views (car fee and shipping) to replace a single full-name TextEditingController with separate first-name and last-name controllers. It removes the previous string-splitting logic (split on spaces, lastIndexOf, etc.) and updates validation to require both first and last name fields to be non-empty. No security-sensitive code paths are modified beyond ordinary form handling.
Changed components
lib/pages/shopinbit/shopinbit_car_fee_view.dartlib/pages/shopinbit/shopinbit_shipping_view.dartInspect captured patch +87 / −84
diff --git a/lib/pages/shopinbit/shopinbit_car_fee_view.dart b/lib/pages/shopinbit/shopinbit_car_fee_view.dart
index f656e41..555924e 100644
--- a/lib/pages/shopinbit/shopinbit_car_fee_view.dart
+++ b/lib/pages/shopinbit/shopinbit_car_fee_view.dart
@@ -39,7 +39,8 @@ class ShopInBitCarFeeView extends ConsumerStatefulWidget {
}
class _ShopInBitCarFeeViewState extends ConsumerState<ShopInBitCarFeeView> {
- late final TextEditingController _billingNameController;
+ late final TextEditingController _billingFirstNameController;
+ late final TextEditingController _billingLastNameController;
late final TextEditingController _billingStreetController;
late final TextEditingController _billingCityController;
late final TextEditingController _billingPostalCodeController;
@@ -50,21 +51,14 @@ class _ShopInBitCarFeeViewState extends ConsumerState<ShopInBitCarFeeView> {
bool _canContinue = false;
void _validate() {
- bool valid =
- _billingNameController.text.trim().isNotEmpty &&
+ final valid =
+ _billingFirstNameController.text.trim().isNotEmpty &&
+ _billingLastNameController.text.trim().isNotEmpty &&
_billingStreetController.text.trim().isNotEmpty &&
_billingCityController.text.trim().isNotEmpty &&
_billingPostalCodeController.text.trim().isNotEmpty &&
widget.draft.deliveryCountryCode.isNotEmpty;
- if (valid) {
- // check full name
- final parts = _billingNameController.text
- .split(" ")
- .where((e) => e.isNotEmpty);
- valid = parts.length > 1;
- }
-
if (_canContinue != valid && mounted) {
setState(() {
_canContinue = valid;
@@ -76,7 +70,8 @@ class _ShopInBitCarFeeViewState extends ConsumerState<ShopInBitCarFeeView> {
void initState() {
super.initState();
- _billingNameController = TextEditingController();
+ _billingFirstNameController = TextEditingController();
+ _billingLastNameController = TextEditingController();
_billingStreetController = TextEditingController();
_billingCityController = TextEditingController();
_billingPostalCodeController = TextEditingController();
@@ -84,7 +79,8 @@ class _ShopInBitCarFeeViewState extends ConsumerState<ShopInBitCarFeeView> {
@override
void dispose() {
- _billingNameController.dispose();
+ _billingFirstNameController.dispose();
+ _billingLastNameController.dispose();
_billingStreetController.dispose();
_billingCityController.dispose();
_billingPostalCodeController.dispose();
@@ -107,29 +103,15 @@ class _ShopInBitCarFeeViewState extends ConsumerState<ShopInBitCarFeeView> {
});
}
- ({String first, String last}) _splitFullName(String raw) {
- final trimmed = raw.trim();
- final idx = trimmed.lastIndexOf(' ');
- if (idx >= 0) {
- return (
- first: trimmed.substring(0, idx).trim(),
- last: trimmed.substring(idx + 1).trim(),
- );
- }
- return (first: trimmed, last: "");
- }
-
Future<void> _createInvoice() async {
if (_submitting) return;
setState(() => _submitting = true);
try {
final customerKey = await ref.read(pShopinBitService).ensureCustomerKey();
- final Address billing;
- final billingName = _splitFullName(_billingNameController.text);
- billing = Address(
- firstName: billingName.first,
- lastName: billingName.last,
+ final billing = Address(
+ firstName: _billingFirstNameController.text.trim(),
+ lastName: _billingLastNameController.text.trim(),
street: _billingStreetController.text.trim(),
zip: _billingPostalCodeController.text.trim(),
city: _billingCityController.text.trim(),
@@ -321,8 +303,16 @@ class _ShopInBitCarFeeViewState extends ConsumerState<ShopInBitCarFeeView> {
),
SizedBox(height: isDesktop ? 16 : 12),
AdaptiveTextField(
- controller: _billingNameController,
- labelText: "Full name",
+ controller: _billingFirstNameController,
+ labelText: "First name",
+ autocorrect: false,
+ enableSuggestions: false,
+ onChangedComprehensive: (_) => _validate(),
+ ),
+ spacing,
+ AdaptiveTextField(
+ controller: _billingLastNameController,
+ labelText: "Last name",
autocorrect: false,
enableSuggestions: false,
onChangedComprehensive: (_) => _validate(),
diff --git a/lib/pages/shopinbit/shopinbit_shipping_view.dart b/lib/pages/shopinbit/shopinbit_shipping_view.dart
index 306b853..c29aa9d 100644
--- a/lib/pages/shopinbit/shopinbit_shipping_view.dart
+++ b/lib/pages/shopinbit/shopinbit_shipping_view.dart
@@ -42,21 +42,25 @@ class ShopInBitShippingView extends ConsumerStatefulWidget {
}
class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
- late final TextEditingController _nameController;
+ late final TextEditingController _nameFirstController;
+ late final TextEditingController _nameLastController;
late final TextEditingController _streetController;
late final TextEditingController _cityController;
late final TextEditingController _postalCodeController;
- late final FocusNode _nameFocusNode;
+ late final FocusNode _nameFirstFocusNode;
+ late final FocusNode _nameLastFocusNode;
late final FocusNode _streetFocusNode;
late final FocusNode _cityFocusNode;
late final FocusNode _postalCodeFocusNode;
// Billing address controllers
- late final TextEditingController _billingNameController;
+ late final TextEditingController _billingFirstNameController;
+ late final TextEditingController _billingLastNameController;
late final TextEditingController _billingStreetController;
late final TextEditingController _billingCityController;
late final TextEditingController _billingPostalCodeController;
- late final FocusNode _billingNameFocusNode;
+ late final FocusNode _billingFirstNameFocusNode;
+ late final FocusNode _billingLastNameFocusNode;
late final FocusNode _billingStreetFocusNode;
late final FocusNode _billingCityFocusNode;
late final FocusNode _billingPostalCodeFocusNode;
@@ -78,25 +82,15 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
bool get _canContinue {
if (_submitting) return false;
final shippingValid =
- _nameController.text.trim().isNotEmpty &&
- _nameController.text
- .split(" ")
- .map((e) => e.trim())
- .where((e) => e.isNotEmpty)
- .length >
- 1 &&
+ _nameFirstController.text.trim().isNotEmpty &&
+ _nameLastController.text.trim().isNotEmpty &&
_streetController.text.trim().isNotEmpty &&
_cityController.text.trim().isNotEmpty &&
_postalCodeController.text.trim().isNotEmpty;
if (!shippingValid) return false;
if (_differentBilling) {
- return _billingNameController.text.trim().isNotEmpty &&
- _billingNameController.text
- .split(" ")
- .map((e) => e.trim())
- .where((e) => e.isNotEmpty)
- .length >
- 1 &&
+ return _billingFirstNameController.text.trim().isNotEmpty &&
+ _billingLastNameController.text.trim().isNotEmpty &&
_billingStreetController.text.trim().isNotEmpty &&
_billingCityController.text.trim().isNotEmpty &&
_billingPostalCodeController.text.trim().isNotEmpty &&
@@ -108,20 +102,24 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
@override
void initState() {
super.initState();
- _nameController = TextEditingController();
+ _nameFirstController = TextEditingController();
+ _nameLastController = TextEditingController();
_streetController = TextEditingController();
_cityController = TextEditingController();
_postalCodeController = TextEditingController();
- _nameFocusNode = FocusNode();
+ _nameFirstFocusNode = FocusNode();
+ _nameLastFocusNode = FocusNode();
_streetFocusNode = FocusNode();
_cityFocusNode = FocusNode();
_postalCodeFocusNode = FocusNode();
- _billingNameController = TextEditingController();
+ _billingFirstNameController = TextEditingController();
+ _billingLastNameController = TextEditingController();
_billingStreetController = TextEditingController();
_billingCityController = TextEditingController();
_billingPostalCodeController = TextEditingController();
- _billingNameFocusNode = FocusNode();
+ _billingFirstNameFocusNode = FocusNode();
+ _billingLastNameFocusNode = FocusNode();
_billingStreetFocusNode = FocusNode();
_billingCityFocusNode = FocusNode();
_billingPostalCodeFocusNode = FocusNode();
@@ -163,11 +161,13 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
as String;
for (final node in [
- _nameFocusNode,
+ _nameFirstFocusNode,
+ _nameLastFocusNode,
_streetFocusNode,
_cityFocusNode,
_postalCodeFocusNode,
- _billingNameFocusNode,
+ _billingFirstNameFocusNode,
+ _billingLastNameFocusNode,
_billingStreetFocusNode,
_billingCityFocusNode,
_billingPostalCodeFocusNode,
@@ -178,19 +178,23 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
@override
void dispose() {
- _nameController.dispose();
+ _nameFirstController.dispose();
+ _nameLastController.dispose();
_streetController.dispose();
_cityController.dispose();
_postalCodeController.dispose();
- _nameFocusNode.dispose();
+ _nameFirstFocusNode.dispose();
+ _nameLastFocusNode.dispose();
_streetFocusNode.dispose();
_cityFocusNode.dispose();
_postalCodeFocusNode.dispose();
- _billingNameController.dispose();
+ _billingFirstNameController.dispose();
+ _billingLastNameController.dispose();
_billingStreetController.dispose();
_billingCityController.dispose();
_billingPostalCodeController.dispose();
- _billingNameFocusNode.dispose();
+ _billingFirstNameFocusNode.dispose();
+ _billingLastNameFocusNode.dispose();
_billingStreetFocusNode.dispose();
_billingCityFocusNode.dispose();
_billingPostalCodeFocusNode.dispose();
@@ -198,7 +202,8 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
}
Future<void> _continue() async {
- final name = _nameController.text.trim();
+ final nameFirst = _nameFirstController.text.trim();
+ final nameLast = _nameLastController.text.trim();
final street = _streetController.text.trim();
final city = _cityController.text.trim();
final postalCode = _postalCodeController.text.trim();
@@ -207,22 +212,11 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
PaymentInfo? paymentInfo;
setState(() => _submitting = true);
try {
- // Split name into first/last
- final parts = name.split(' ');
- final firstName = parts.first;
- final lastName = parts.length > 1 ? parts.sublist(1).join(' ') : '';
-
Address? billingAddress;
if (_differentBilling) {
- final billingName = _billingNameController.text.trim();
- final billingParts = billingName.split(' ');
- final billingFirst = billingParts.first;
- final billingLast = billingParts.length > 1
- ? billingParts.sublist(1).join(' ')
- : '';
billingAddress = Address(
- firstName: billingFirst,
- lastName: billingLast,
+ firstName: _billingFirstNameController.text.trim(),
+ lastName: _billingLastNameController.text.trim(),
street: _billingStreetController.text.trim(),
zip: _billingPostalCodeController.text.trim(),
city: _billingCityController.text.trim(),
@@ -237,8 +231,8 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
.submitAddress(
widget.ticket.apiTicketId,
shipping: Address(
- firstName: firstName,
- lastName: lastName,
+ firstName: nameFirst,
+ lastName: nameLast,
street: street,
zip: postalCode,
city: city,
@@ -326,9 +320,18 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
),
SizedBox(height: isDesktop ? 32 : 24),
AdaptiveTextField(
- controller: _nameController,
- focusNode: _nameFocusNode,
- labelText: "Full name",
+ controller: _nameFirstController,
+ focusNode: _nameFirstFocusNode,
+ labelText: "First name",
+ autocorrect: false,
+ enableSuggestions: false,
+ onChanged: (_) => setState(() {}),
+ ),
+ spacing,
+ AdaptiveTextField(
+ controller: _nameLastController,
+ focusNode: _nameLastFocusNode,
+ labelText: "Last name",
autocorrect: false,
enableSuggestions: false,
onChanged: (_) => setState(() {}),
@@ -380,7 +383,8 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
_differentBilling = !_differentBilling;
if (!_differentBilling) {
// Clear billing fields.
- _billingNameController.clear();
+ _billingFirstNameController.clear();
+ _billingLastNameController.clear();
_billingStreetController.clear();
_billingCityController.clear();
_billingPostalCodeController.clear();
@@ -400,7 +404,8 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
setState(() {
_differentBilling = v ?? false;
if (!_differentBilling) {
- _billingNameController.clear();
+ _billingFirstNameController.clear();
+ _billingLastNameController.clear();
_billingStreetController.clear();
_billingCityController.clear();
_billingPostalCodeController.clear();
@@ -437,9 +442,17 @@ class _ShopInBitShippingViewState extends ConsumerState<ShopInBitShippingView> {
),
spacing,
AdaptiveTextField(
- controller: _billingNameController,
- focusNode: _billingNameFocusNode,
- labelText: "Full name",
+ controller: _billingFirstNameController,
+ labelText: "First name",
+ focusNode: _billingFirstNameFocusNode,
+ autocorrect: false,
+ enableSuggestions: false,
+ onChanged: (_) => setState(() {}),
+ ),
+ AdaptiveTextField(
+ controller: _billingLastNameController,
+ labelText: "Last name",
+ focusNode: _billingLastNameFocusNode,
autocorrect: false,
enableSuggestions: false,
onChanged: (_) => setState(() {}),
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.