AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 63 Monero

Merge branch 'staging' into fix/desktop-address-book-chooser

Public commit record

What the developer wrote

Authored by Julian

50/100 · Thin
Merge branch 'staging' into fix/desktop-address-book-chooser
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This large merge commit mostly hardens privacy and fixes amount-input bugs. It routes remote images through Tor when the user has Tor enabled, switches several coins (Fact0rn, Ethereum, Nano) to support Tor, and rewrites amount parsing so changing currency units or locales does not accidentally alter the value being sent. It also migrates existing Fact0rn default nodes to allow Tor while leaving user-customised nodes untouched, and stops Ethereum/Stellar node tests from silently bypassing the Tor proxy.

Recommended action

Reviewers should verify that all prior Image.network/SvgPicture.network call sites in the changed files are covered, that the new Tor proxy client is disposed correctly in long-lived Ethereum wallet loops, and that the amount-lock logic does not skip legitimate user edits. The DB migration tests look solid but should be run against real Fact0rn node records. No CVE or advisory is referenced in the materials, so treat this as a routine privacy/bug-fix merge unless a public disclosure emerges.

Security signals we found

01

Network traffic that previously bypassed Tor (Image.network/SvgPicture.network) is now routed through Tor when enabled, preventing clearnet IP leaks for remote icons, theme previews, CakePay/ShopInBit images, and exchange provider logos.

02

Default Fact0rn node is migrated to allow Tor, reducing fingerprinting for existing users, with a guard that preserves user-edited node settings.

03

Ethereum and Stellar node connections now respect the Tor preference instead of silently using clearnet.

04

Amount-input recursion bug fixed: changing locale or unit no longer re-parses the displayed text and accidentally changes the send/stake/filter amount.

05

ShopInBit attachment proxy switched from query-auth URL to header auth, keeping bearer token and customer key out of logged URLs.

06

Ethereum node form now keeps the port inside the URL for Ethereum (because the port field is ignored), and exposes Tor/clearnet/both radio options for Ethereum nodes.

Risk score

Why this scored 63/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 12/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.