AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 24 Monero

Hide unregistered Solana wallets in the add-token wallet picker

Public commit record

What the developer wrote

Authored by sneurlax

83/100 · Strong
Hide unregistered Solana wallets in the add-token wallet picker

Wallet.create writes the new wallet's info to the db before the verify
step calls pWallets.addWallet, so the Solana token wallet picker rebuilt
under the create flow with an id that Wallets.getWallet throws on. Skip
ids that aren't registered yet, base the empty-state message on the
registered ones, and toggle the picker's trigger after addWallet in the
verify and restore steps so it rebuilds once the wallet is registered.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit fixes a UI crash in Stack Wallet's Solana token wallet picker. When creating or restoring a Solana wallet, the app temporarily saved the new wallet's details to the database before fully registering it in memory. The token picker could then try to display a wallet that wasn't fully ready yet, causing an error. The fix hides not-yet-registered wallets from the picker and refreshes the picker once registration is complete.

Recommended action

Treat as a stability/robustness fix rather than a critical security patch. Review whether other token pickers (e.g., select_wallet_for_token_view.dart) have the same unregistered-wallet exposure, and consider centralizing registration-before-read ordering to avoid similar crashes.

Security signals we found

01

UI crash / unhandled exception in wallet picker

02

Use of unregistered wallet ID before in-memory registration

03

Race condition between database write and provider registration

04

Defensive filtering added to prevent lookup failure

Risk score

Why this scored 24/100

Our methodology →
Potential impact 4/30
Exploitability 2/25
Stealth signal 3/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.