AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 47 Monero

Merge pull request #1496 from cypherstack/pr1479/eth-client-tor-change

Public commit record

What the developer wrote

Authored by Julian

73/100 · Adequate
Merge pull request #1496 from cypherstack/pr1479/eth-client-tor-change

Fail ETH RPCs when the Tor preference changed after the client was built
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a privacy issue in Stack Wallet's Ethereum support. Previously, if a user turned Tor on or off while the wallet was running, some Ethereum network requests could still use the old connection method, potentially exposing the user's real IP address or sending traffic outside Tor. The fix makes the wallet refuse to send such requests once the Tor setting changes, so the next request creates a fresh connection matching the current preference. The change includes tests proving the behavior.

Recommended action

Treat as a security-relevant privacy fix. Review whether other wallets or long-lived clients in the codebase reuse clients across Tor preference changes and apply the same fail-closed pattern. No immediate user action is required beyond updating to the patched version.

Security signals we found

01

Tor preference change could leave RPCs on wrong transport

02

Long-lived web3 client reused across preference changes

03

Potential IP/transport leak when toggling Tor at runtime

04

Fix implemented as fail-closed wrapper around HTTP client

05

Unit tests assert no direct or proxy traffic after preference flip

Risk score

Why this scored 47/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 9/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.