← Watch feed
fix(ui): clean up as much as possible without fully refactoring
Public commit record
62/100 · Adequate
What the developer wrote
Authored by julian
fix(ui): clean up as much as possible without fully refactoring
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
What changed, and why it matters
This commit is a purely cosmetic UI cleanup for a ticket detail screen in the Stack Wallet app. It swaps some text widgets for selectable text, adjusts padding and borders, and replaces a custom container with a reusable rounded container. There is no security-relevant change.
Recommended action
No security action needed. This is a routine UI refactor and can be reviewed as normal code quality.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies lib/pages/shopinbit/shopinbit_ticket_detail.dart only. Changes include: wrapping RoundedWhiteContainer in Padding, adding borderColor properties, replacing Text with SelectableText for ticketId and requestDescription, changing Container to RoundedContainer for the input bar, and adding mainAxisSize/crossAxisAlignment to a Column. No logic, validation, cryptography, network, or permission changes are present.
Changed components
lib/pages/shopinbit/shopinbit_ticket_detail.dartInspect captured patch +52 / −37
diff --git a/lib/pages/shopinbit/shopinbit_ticket_detail.dart b/lib/pages/shopinbit/shopinbit_ticket_detail.dart
index 5e88802..9875a7b 100644
--- a/lib/pages/shopinbit/shopinbit_ticket_detail.dart
+++ b/lib/pages/shopinbit/shopinbit_ticket_detail.dart
@@ -386,45 +386,56 @@ class _ShopInBitTicketDetailState extends ConsumerState<ShopInBitTicketDetail> {
final isDesktop = Util.isDesktop;
final model = widget.model;
- final statusBar = RoundedWhiteContainer(
- child: Row(
- mainAxisAlignment: MainAxisAlignment.spaceBetween,
- children: [
- Text(
- model.ticketId ?? "Request",
- style: isDesktop
- ? STextStyles.desktopTextSmall(context)
- : STextStyles.titleBold12(context),
- ),
- Container(
- padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 2),
- decoration: BoxDecoration(
- borderRadius: BorderRadius.circular(8),
- color: model.status
- .getColor(Theme.of(context).extension<StackColors>()!)
- .withOpacity(0.2),
+ final statusBar = Padding(
+ padding: .only(bottom: isDesktop ? 12 : 8),
+ child: RoundedWhiteContainer(
+ borderColor: isDesktop
+ ? Theme.of(context).extension<StackColors>()!.textFieldDefaultBG
+ : null,
+ child: Row(
+ mainAxisAlignment: MainAxisAlignment.spaceBetween,
+ children: [
+ SelectableText(
+ model.ticketId ?? "Request",
+ style: isDesktop
+ ? STextStyles.desktopTextSmall(context)
+ : STextStyles.titleBold12(context),
),
- child: Text(
- model.status.label,
- style:
- (isDesktop
- ? STextStyles.desktopTextExtraExtraSmall(context)
- : STextStyles.itemSubtitle12(context))
- .copyWith(
- color: model.status.getColor(
- Theme.of(context).extension<StackColors>()!,
+ Container(
+ padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 2),
+ decoration: BoxDecoration(
+ borderRadius: BorderRadius.circular(8),
+ color: model.status
+ .getColor(Theme.of(context).extension<StackColors>()!)
+ .withOpacity(0.2),
+ ),
+ child: Text(
+ model.status.label,
+ style:
+ (isDesktop
+ ? STextStyles.desktopTextExtraExtraSmall(context)
+ : STextStyles.itemSubtitle12(context))
+ .copyWith(
+ color: model.status.getColor(
+ Theme.of(context).extension<StackColors>()!,
+ ),
),
- ),
+ ),
),
- ),
- ],
+ ],
+ ),
),
);
final offerBanner = model.status == ShopInBitOrderStatus.offerAvailable
? Padding(
- padding: EdgeInsets.only(bottom: isDesktop ? 16 : 12),
+ padding: .only(bottom: isDesktop ? 12 : 8),
child: RoundedWhiteContainer(
+ borderColor: isDesktop
+ ? Theme.of(
+ context,
+ ).extension<StackColors>()!.textFieldDefaultBG
+ : null,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
@@ -494,12 +505,9 @@ class _ShopInBitTicketDetailState extends ConsumerState<ShopInBitTicketDetail> {
),
);
- final inputBar = Container(
- padding: Util.isDesktop ? null : const EdgeInsets.all(8),
- decoration: BoxDecoration(
- color: Theme.of(context).extension<StackColors>()!.popupBG,
- borderRadius: BorderRadius.circular(12),
- ),
+ final inputBar = RoundedContainer(
+ padding: Util.isDesktop ? .zero : const .all(8),
+ color: Theme.of(context).extension<StackColors>()!.popupBG,
child: Row(
children: [
Expanded(
@@ -548,6 +556,11 @@ class _ShopInBitTicketDetailState extends ConsumerState<ShopInBitTicketDetail> {
? Padding(
padding: EdgeInsets.only(bottom: isDesktop ? 12 : 8),
child: RoundedWhiteContainer(
+ borderColor: isDesktop
+ ? Theme.of(
+ context,
+ ).extension<StackColors>()!.textFieldDefaultBG
+ : null,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
@@ -558,7 +571,7 @@ class _ShopInBitTicketDetailState extends ConsumerState<ShopInBitTicketDetail> {
: STextStyles.titleBold12(context),
),
const SizedBox(height: 8),
- Text(
+ SelectableText(
model.requestDescription,
style: isDesktop
? STextStyles.desktopTextExtraExtraSmall(context)
@@ -586,6 +599,8 @@ class _ShopInBitTicketDetailState extends ConsumerState<ShopInBitTicketDetail> {
: const SizedBox.shrink();
final body = Column(
+ mainAxisSize: .min,
+ crossAxisAlignment: .stretch,
children: [
statusBar,
retryButton,
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.