AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 64 Monero

Merge branch 'staging' into feat/openalias

Public commit record

What the developer wrote

Authored by Julian

45/100 · Thin
Merge branch 'staging' into feat/openalias
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds a defensive security feature to Stack Wallet that verifies transactions and coin values received from ElectrumX servers before trusting them. It protects against a malicious or compromised server lying about transaction sizes, coin values, or transaction contents. The wallet now fetches raw transaction bytes, checks they hash to the expected transaction ID, verifies the wallet's own signatures, and for older P2PKH coins cross-checks the parent transaction to confirm the amount. Unverified transactions are dropped and unverified coins are blocked from spending. The commit also fixes RBF (Replace-By-Fee) fee calculations to use verified sizes and follow Bitcoin's replacement fee rules.

Recommended action

Review and merge if not already deployed. Validate that all ElectrumX-based wallets invoke verifyPendingSpend for unconfirmed outgoing transactions and authenticatedP2pkhOutput for P2PKH UTXOs. Run the new test suites (owned_input_signatures_test, raw_transaction_layouts_test, replacement_fee_test). Consider whether non-P2PKH input types (e.g., P2SH multisig) need analogous parent verification, and audit error handling so network failures do not silently delete valid pending transactions.

Security signals we found

01

Server-supplied transaction sizes and coin values are now cryptographically authenticated before use

02

P2PKH parent output amounts are verified against parent transaction bytes to prevent fee/amount spoofing

03

Pending spends that cannot be proven to be signed by the wallet are deleted instead of retained

04

RBF fee bumping now uses authenticated transaction sizes and enforces BIP 125 incremental relay fee rule

05

New raw transaction parser handles Dash/Firo extra payload and Peercoin legacy timestamp variants

Risk score

Why this scored 64/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.