Public commit record
45/100 · Thin
What the developer wrote
Authored by julian
at least log wallet delete errors
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
What changed, and why it matters
This commit adds error logging when deleting a wallet fails, and makes minor code cleanups. It does not fix the underlying deletion failure or change how the app behaves when an error occurs. The user still sees the same result, but developers now get a log entry to help diagnose problems.
Recommended action
Treat as a minor maintainability/diagnostics improvement. If wallet deletion failures have security or data-loss implications, follow up with a patch that surfaces the error to the user, rolls back any partial deletion state, and ensures secure storage entries are not left in an inconsistent state.
Security signals we found
01
Error path in destructive operation (wallet deletion) was previously silent
02
Patch only adds logging; it does not prevent, recover, or report failure to the user
03
No input validation, access-control, or cryptographic changes
Evidence from the diff
The patch wraps ref.read(pWallets).deleteWallet(...) in a try/catch block and logs caught exceptions via Logging.instance.f(...). It also refactors formatting, extracts a help string constant, and replaces mounted with context.mounted in two places. No error-handling behavior is changed for the user: the dialog still pops after the call regardless of success or failure.
Changed components
lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dartConfirmDelete widgetWallet deletion flow on desktopInspect captured patch +40 / −52
diff --git a/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dart b/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dart
index bd6dac1..c9a0c50 100644
--- a/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dart
+++ b/lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/delete_wallet_keys_popup.dart
@@ -13,6 +13,7 @@ import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';
+
import '../../../../notifications/show_flush_bar.dart';
import '../../../../pages/add_wallet_views/new_wallet_recovery_phrase_view/sub_widgets/mnemonic_table.dart';
import '../../../../providers/global/secure_store_provider.dart';
@@ -21,6 +22,7 @@ import '../../../../route_generator.dart';
import '../../../../themes/stack_colors.dart';
import '../../../../utilities/assets.dart';
import '../../../../utilities/clipboard_interface.dart';
+import '../../../../utilities/logger.dart';
import '../../../../utilities/text_styles.dart';
import '../../../../wallets/isar/providers/wallet_info_provider.dart';
import '../../../../widgets/desktop/desktop_dialog.dart';
@@ -52,6 +54,11 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
late final List<String> _words;
late final ClipboardInterface _clipboardInterface;
+ static const _recoveryPhraseInfo =
+ "Please write down your recovery phrase in the correct order and save it "
+ "to keep your funds secure. "
+ "You will be shown your recovery phrase on the next screen.";
+
@override
void initState() {
_walletId = widget.walletId;
@@ -72,9 +79,7 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
Padding(
- padding: const EdgeInsets.only(
- left: 32,
- ),
+ padding: const EdgeInsets.only(left: 32),
child: Text(
"Wallet keys",
style: STextStyles.desktopH3(context),
@@ -82,51 +87,37 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
),
DesktopDialogCloseButton(
onPressedOverride: () {
- Navigator.of(
- context,
- rootNavigator: true,
- ).pop();
+ Navigator.of(context, rootNavigator: true).pop();
},
),
],
),
- const SizedBox(
- height: 28,
- ),
+ const SizedBox(height: 28),
Text(
"Recovery phrase",
style: STextStyles.desktopTextMedium(context),
),
- const SizedBox(
- height: 8,
- ),
+ const SizedBox(height: 8),
Center(
child: Padding(
- padding: const EdgeInsets.symmetric(
- horizontal: 32,
- ),
+ padding: const EdgeInsets.symmetric(horizontal: 32),
child: Text(
- "Please write down your recovery phrase in the correct order and "
- "save it to keep your funds secure. You will be shown your recovery phrase on the next screen.",
+ _recoveryPhraseInfo,
style: STextStyles.desktopTextExtraExtraSmall(context),
textAlign: TextAlign.center,
),
),
),
- const SizedBox(
- height: 24,
- ),
+ const SizedBox(height: 24),
Padding(
- padding: const EdgeInsets.symmetric(
- horizontal: 32,
- ),
+ padding: const EdgeInsets.symmetric(horizontal: 32),
child: RawMaterialButton(
hoverColor: Colors.transparent,
onPressed: () async {
await _clipboardInterface.setData(
ClipboardData(text: _words.join(" ")),
);
- if (mounted) {
+ if (context.mounted) {
unawaited(
showFloatingFlushBar(
type: FlushBarType.info,
@@ -140,19 +131,15 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
child: MnemonicTable(
words: widget.words,
isDesktop: true,
- itemBorderColor: Theme.of(context)
- .extension<StackColors>()!
- .buttonBackSecondary,
+ itemBorderColor: Theme.of(
+ context,
+ ).extension<StackColors>()!.buttonBackSecondary,
),
),
),
- const SizedBox(
- height: 24,
- ),
+ const SizedBox(height: 24),
Padding(
- padding: const EdgeInsets.symmetric(
- horizontal: 32,
- ),
+ padding: const EdgeInsets.symmetric(horizontal: 32),
child: Row(
children: [
Expanded(
@@ -162,9 +149,7 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
await Navigator.of(context).push(
RouteGenerator.getRoute(
builder: (context) {
- return ConfirmDelete(
- walletId: _walletId,
- );
+ return ConfirmDelete(walletId: _walletId);
},
settings: const RouteSettings(
name: "/desktopConfirmDelete",
@@ -177,9 +162,7 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
],
),
),
- const SizedBox(
- height: 32,
- ),
+ const SizedBox(height: 32),
],
),
);
@@ -187,10 +170,7 @@ class _DeleteWalletKeysPopup extends ConsumerState<DeleteWalletKeysPopup> {
}
class ConfirmDelete extends ConsumerStatefulWidget {
- const ConfirmDelete({
- super.key,
- required this.walletId,
- });
+ const ConfirmDelete({super.key, required this.walletId});
final String walletId;
@@ -207,9 +187,7 @@ class _ConfirmDeleteState extends ConsumerState<ConfirmDelete> {
children: [
const Row(
mainAxisAlignment: MainAxisAlignment.end,
- children: [
- DesktopDialogCloseButton(),
- ],
+ children: [DesktopDialogCloseButton()],
),
Column(
crossAxisAlignment: CrossAxisAlignment.center,
@@ -238,12 +216,22 @@ class _ConfirmDeleteState extends ConsumerState<ConfirmDelete> {
buttonHeight: ButtonHeight.xl,
label: "Continue",
onPressed: () async {
- await ref.read(pWallets).deleteWallet(
- ref.read(pWalletInfo(widget.walletId)),
- ref.read(secureStoreProvider),
- );
+ try {
+ await ref
+ .read(pWallets)
+ .deleteWallet(
+ ref.read(pWalletInfo(widget.walletId)),
+ ref.read(secureStoreProvider),
+ );
+ } catch (e, s) {
+ Logging.instance.f(
+ "Wallet deletion errors",
+ error: e,
+ stackTrace: s,
+ );
+ }
- if (mounted) {
+ if (context.mounted) {
Navigator.of(context, rootNavigator: true).pop(true);
}
},
Risk score
Our methodology →Why this scored 18/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.