Merge pull request #1476 from cypherstack/fix/recipient-locale-change
What changed, and why it matters
This commit fixes a UI bug in Stack Wallet where changing the app's language/locale or the amount unit (like switching from full coins to milli-coins) would accidentally clear or alter the recipient's entered amount. The fix separates 'display updates' from actual user input so the wallet keeps the intended payment amount while only reformatting how it looks. It also adds many automated tests to prevent the bug from returning.
No immediate security response is required; this is a defensive bug-fix merge. Users and auditors should verify the new tests pass and consider whether any other views still call tryParseEditable on programmatically updated controller text without a display lock.
Security signals we found
UI state corruption on locale/unit change could lead to an unintended transaction amount being prepared
Fix separates display formatting from canonical amount parsing to prevent feedback loops
Extensive regression tests added for send, token send, FROST recipient, staking, and transaction filter views
Evidence from the diff
The patch refactors amount parsing and display relocalization across send, token-send, FROST multisig recipient, desktop send, Salvium staking, and transaction-filter views. Previously, locale or unit changes triggered controller text updates that were re-parsed as user edits, which could reset the stored amount or lose precision. The change introduces an AmountParser helper and an updateControllers/updateAmountDisplay lock so programmatic display changes bypass the onChanged parsing path. Tests verify that locale switches (e.g., en_US -> de_DE) and unit switches preserve the canonical Amount value and format the text correctly.
Changed components
lib/pages/send_view/send_view.dartlib/pages/send_view/token_send_view.dartlib/pages/send_view/frost_ms/recipient.dartlib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dartlib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_token_send.dartlib/pages/salvium_stake/salvium_create_stake_view.dartlib/pages/wallet_view/transaction_views/transaction_search_filter_view.dartlib/utilities/amount/amount_field_relocalization.dartlib/utilities/amount/amount_formatter.dartlib/utilities/amount/amount_parser.dartInspect captured patch +1224 / −92
### lib/pages/salvium_stake/salvium_create_stake_view.dart
@@ -11,6 +11,7 @@ import '../../themes/stack_colors.dart';
import '../../utilities/amount/amount.dart';
import '../../utilities/amount/amount_field_relocalization.dart';
import '../../utilities/amount/amount_formatter.dart';
+import '../../utilities/amount/amount_parser.dart';
import '../../utilities/amount/amount_input_formatter.dart';
import '../../utilities/amount/amount_unit.dart';
import '../../utilities/enums/fee_rate_type_enum.dart';
@@ -58,9 +59,14 @@ class _SalviumCreateStakeViewState
}
void _parseAmount(String string) {
- final cryptoAmount = ref
- .read(pAmountFormatter(ref.read(pWalletCoin(widget.walletId))))
- .tryParseEditable(string);
+ if (_updatingAmountDisplay) return;
+ final coin = ref.read(pWalletCoin(widget.walletId));
+ final cryptoAmount = AmountParser.tryParseEditable(
+ string,
+ locale: ref.read(localeServiceChangeNotifierProvider).locale,
+ unit: ref.read(pAmountUnit(coin)),
+ coin: coin,
+ );
if (_amount != cryptoAmount) {
setState(() {
@@ -69,6 +75,18 @@ class _SalviumCreateStakeViewState
}
}
+ bool _updatingAmountDisplay = false;
+
+ void _updateAmountDisplay(VoidCallback update) {
+ final wasUpdating = _updatingAmountDisplay;
+ _updatingAmountDisplay = true;
+ try {
+ update();
+ } finally {
+ _updatingAmountDisplay = wasUpdating;
+ }
+ }
+
bool _lock = false;
Future<void> _previewPressed() async {
if (_lock) return;
@@ -289,7 +307,18 @@ class _SalviumCreateStakeViewState
final locale = ref.watch(
localeServiceChangeNotifierProvider.select((s) => s.locale),
);
- listenForAmountRelocalization(ref.listen, controllers: [_amountController]);
+ listenForAmountRelocalization(
+ ref.listen,
+ controllers: [_amountController],
+ updateControllers: _updateAmountDisplay,
+ );
+ ref.listen<AmountFormatter>(pAmountFormatter(coin), (previous, next) {
+ if (previous?.unit != next.unit && _amount != null) {
+ _updateAmountDisplay(() {
+ _amountController.text = next.formatEditable(_amount!);
+ });
+ }
+ });
return ConditionalParent(
condition: !Util.isDesktop,
### lib/pages/send_view/frost_ms/recipient.dart
@@ -8,6 +8,7 @@ import '../../../utilities/address_utils.dart';
import '../../../utilities/amount/amount.dart';
import '../../../utilities/amount/amount_field_relocalization.dart';
import '../../../utilities/amount/amount_formatter.dart';
+import '../../../utilities/amount/amount_parser.dart';
import '../../../utilities/amount/amount_input_formatter.dart';
import '../../../utilities/amount/amount_unit.dart';
import '../../../utilities/barcode_scanner_interface.dart';
@@ -85,17 +86,32 @@ class _RecipientState extends ConsumerState<Recipient> {
late final FocusNode addressFocusNode, amountFocusNode;
bool _addressIsEmpty = true;
- final bool _cryptoAmountChangeLock = false;
+ bool _cryptoAmountChangeLock = false;
bool get isSingle => widget.remove == null;
RecipientId get _id => (walletId: widget.walletId, index: widget.index);
+ Amount? _parseAmount() => AmountParser.tryParseEditable(
+ amountController.text,
+ locale: ref.read(localeServiceChangeNotifierProvider).locale,
+ unit: ref.read(pAmountUnit(widget.coin)),
+ coin: widget.coin,
+ );
+
+ void _updateAmountDisplay(VoidCallback update) {
+ final wasLocked = _cryptoAmountChangeLock;
+ _cryptoAmountChangeLock = true;
+ try {
+ update();
+ } finally {
+ _cryptoAmountChangeLock = wasLocked;
+ }
+ }
+
void _updateRecipientData({String? label, bool replaceLabel = false}) {
final address = addressController.text;
- final amount = ref
- .read(pAmountFormatter(widget.coin))
- .tryParseEditable(amountController.text);
+ final amount = _parseAmount();
final previous = ref.read(pRecipient(_id));
ref.read(pRecipient(_id).notifier).state = (
@@ -174,9 +190,7 @@ class _RecipientState extends ConsumerState<Recipient> {
void _cryptoAmountChanged() async {
if (!_cryptoAmountChangeLock) {
- Amount? cryptoAmount = ref
- .read(pAmountFormatter(widget.coin))
- .tryParseEditable(amountController.text);
+ Amount? cryptoAmount = _parseAmount();
if (cryptoAmount != null) {
if (ref.read(pRecipient(_id))?.amount != null &&
ref.read(pRecipient(_id))?.amount == cryptoAmount) {
@@ -299,15 +313,21 @@ class _RecipientState extends ConsumerState<Recipient> {
final String locale = ref.watch(
localeServiceChangeNotifierProvider.select((value) => value.locale),
);
- listenForAmountRelocalization(ref.listen, controllers: [amountController]);
+ listenForAmountRelocalization(
+ ref.listen,
+ controllers: [amountController],
+ updateControllers: _updateAmountDisplay,
+ );
// Keep the amount, rather than the number typed, when the unit changes.
ref.listen<AmountFormatter>(pAmountFormatter(widget.coin), (
previous,
next,
) {
final amount = ref.read(pRecipient(_id))?.amount;
if (previous?.unit != next.unit && amount != null) {
- amountController.text = next.formatEditable(amount);
+ _updateAmountDisplay(() {
+ amountController.text = next.formatEditable(amount);
+ });
}
});
### lib/pages/send_view/send_view.dart
@@ -39,6 +39,7 @@ import '../../utilities/address_utils.dart';
import '../../utilities/amount/amount.dart';
import '../../utilities/amount/amount_field_relocalization.dart';
import '../../utilities/amount/amount_formatter.dart';
+import '../../utilities/amount/amount_parser.dart';
import '../../utilities/amount/amount_input_formatter.dart';
import '../../utilities/amount/amount_unit.dart';
import '../../utilities/assets.dart';
@@ -567,6 +568,7 @@ class _SendViewState extends ConsumerState<SendView> {
}
void _fiatFieldChanged(String baseAmountString) {
+ _xelisSendAll = false;
final baseAmount = Amount.tryParseFiatString(
baseAmountString,
locale: ref.read(localeServiceChangeNotifierProvider).locale,
@@ -616,12 +618,26 @@ class _SendViewState extends ConsumerState<SendView> {
bool _xelisSendAll = false;
+ // Controller assignments used for display must not edit the stored amount.
+ void _updateAmountDisplay(VoidCallback update) {
+ final wasLocked = _cryptoAmountChangeLock;
+ _cryptoAmountChangeLock = true;
+ try {
+ update();
+ } finally {
+ _cryptoAmountChangeLock = wasLocked;
+ }
+ }
+
void _cryptoAmountChanged() async {
- _xelisSendAll = false;
if (!_cryptoAmountChangeLock) {
- final cryptoAmount = ref
- .read(pAmountFormatter(coin))
- .tryParseEditable(cryptoAmountController.text);
+ _xelisSendAll = false;
+ final cryptoAmount = AmountParser.tryParseEditable(
+ cryptoAmountController.text,
+ locale: ref.read(localeServiceChangeNotifierProvider).locale,
+ unit: ref.read(pAmountUnit(coin)),
+ coin: coin,
+ );
final Amount? amount;
if (cryptoAmount != null) {
amount = cryptoAmount;
@@ -1710,15 +1726,17 @@ class _SendViewState extends ConsumerState<SendView> {
listenForAmountRelocalization(
ref.listen,
controllers: [cryptoAmountController, baseAmountController],
- onRelocalized: _cryptoAmountChanged,
+ updateControllers: _updateAmountDisplay,
);
// Keep the amount, rather than the number typed, when the unit changes.
ref.listen<AmountFormatter>(pAmountFormatter(coin), (previous, next) {
final amount = ref.read(pSendAmount);
if (previous?.unit != next.unit && amount != null) {
// Only the display changes, so keep the send all intent.
final xelisSendAll = _xelisSendAll;
- cryptoAmountController.text = next.formatEditable(amount);
+ _updateAmountDisplay(() {
+ cryptoAmountController.text = next.formatEditable(amount);
+ });
_xelisSendAll = xelisSendAll;
}
});
### lib/pages/send_view/token_send_view.dart
@@ -27,6 +27,7 @@ import '../../utilities/address_utils.dart';
import '../../utilities/amount/amount.dart';
import '../../utilities/amount/amount_field_relocalization.dart';
import '../../utilities/amount/amount_formatter.dart';
+import '../../utilities/amount/amount_parser.dart';
import '../../utilities/amount/amount_input_formatter.dart';
import '../../utilities/amount/amount_unit.dart';
import '../../utilities/assets.dart';
@@ -294,14 +295,26 @@ class _TokenSendViewState extends ConsumerState<TokenSendView> {
_updatePreviewButtonState(_address, _amountToSend);
}
+ // Controller assignments used for display must not edit the stored amount.
+ void _updateAmountDisplay(VoidCallback update) {
+ final wasLocked = _cryptoAmountChangeLock;
+ _cryptoAmountChangeLock = true;
+ try {
+ update();
+ } finally {
+ _cryptoAmountChangeLock = wasLocked;
+ }
+ }
+
void _cryptoAmountChanged() async {
if (!_cryptoAmountChangeLock) {
- final cryptoAmount = ref
- .read(pAmountFormatter(coin))
- .tryParseEditable(
- cryptoAmountController.text,
- tokenContract: tokenContract,
- );
+ final cryptoAmount = AmountParser.tryParseEditable(
+ cryptoAmountController.text,
+ locale: ref.read(localeServiceChangeNotifierProvider).locale,
+ unit: ref.read(pAmountUnit(coin)),
+ coin: coin,
+ tokenContract: tokenContract,
+ );
if (cryptoAmount != null) {
_amountToSend = cryptoAmount;
if (_cachedAmountToSend != null &&
@@ -656,8 +669,15 @@ class _TokenSendViewState extends ConsumerState<TokenSendView> {
listenForAmountRelocalization(
ref.listen,
controllers: [cryptoAmountController, baseAmountController],
- onRelocalized: _cryptoAmountChanged,
+ updateControllers: _updateAmountDisplay,
);
+ ref.listen<AmountFormatter>(pAmountFormatter(coin), (previous, next) {
+ if (previous?.unit != next.unit && _amountToSend != null) {
+ _updateAmountDisplay(() {
+ cryptoAmountController.text = next.formatEditable(_amountToSend!);
+ });
+ }
+ });
// ethFee is checked in the ValueListenableBuilder around the preview
// button so fee keystrokes don't rebuild this whole view.
final previewEnabled = ref
### lib/pages/settings_views/global_settings_view/hidden_settings.dart
@@ -41,17 +41,17 @@ class HiddenSettings extends StatelessWidget {
padding: const EdgeInsets.all(8.0),
child: AppBarIconButton(
size: 32,
- color: Theme.of(
- context,
- ).extension<StackColors>()!.textFieldDefaultBG,
+ color: Theme.of(context)
+ .extension<StackColors>()!
+ .textFieldDefaultBG,
shadows: const [],
icon: SvgPicture.asset(
Assets.svg.arrowLeft,
width: 18,
height: 18,
- color: Theme.of(
- context,
- ).extension<StackColors>()!.topNavIconPrimary,
+ color: Theme.of(context)
+ .extension<StackColors>()!
+ .topNavIconPrimary,
),
onPressed: Navigator.of(context).pop,
),
### lib/pages/wallet_view/transaction_views/transaction_search_filter_view.dart
@@ -19,6 +19,8 @@ import '../../../themes/theme_providers.dart';
import '../../../utilities/amount/amount.dart';
import '../../../utilities/amount/amount_field_relocalization.dart';
import '../../../utilities/amount/amount_formatter.dart';
+import '../../../utilities/amount/amount_parser.dart';
+import '../../../utilities/amount/amount_unit.dart';
import '../../../utilities/amount/amount_input_formatter.dart';
import '../../../utilities/constants.dart';
import '../../../utilities/text_styles.dart';
@@ -39,15 +41,21 @@ import '../../../widgets/textfield_icon_button.dart';
({bool isValid, Amount? amount}) parseTransactionFilterAmountInput({
required String text,
required String locale,
- required AmountFormatter formatter,
+ required AmountUnit unit,
+ required CryptoCurrency coin,
}) {
final decimalSeparator =
Util.getSymbolsFor(locale: locale)?.DECIMAL_SEP ?? ".";
if (text.isEmpty || text == decimalSeparator) {
return (isValid: true, amount: null);
}
- final amount = formatter.tryParseEditable(text);
+ final amount = AmountParser.tryParseEditable(
+ text,
+ locale: locale,
+ unit: unit,
+ coin: coin,
+ );
return (isValid: amount != null, amount: amount);
}
@@ -653,7 +661,8 @@ class _TransactionSearchViewState
final parsedAmount = parseTransactionFilterAmountInput(
text: _amountTextEditingController.text,
locale: locale,
- formatter: ref.read(pAmountFormatter(widget.coin)),
+ unit: ref.read(pAmountUnit(widget.coin)),
+ coin: widget.coin,
);
if (!parsedAmount.isValid) {
return;
### lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart
@@ -45,6 +45,7 @@ import '../../../../utilities/address_utils.dart';
import '../../../../utilities/amount/amount.dart';
import '../../../../utilities/amount/amount_field_relocalization.dart';
import '../../../../utilities/amount/amount_formatter.dart';
+import '../../../../utilities/amount/amount_parser.dart';
import '../../../../utilities/amount/amount_input_formatter.dart';
import '../../../../utilities/amount/amount_unit.dart';
import '../../../../utilities/assets.dart';
@@ -996,12 +997,26 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
bool _xelisSendAll = false;
+ // Controller assignments used for display must not edit the stored amount.
+ void _updateAmountDisplay(VoidCallback update) {
+ final wasLocked = _cryptoAmountChangeLock;
+ _cryptoAmountChangeLock = true;
+ try {
+ update();
+ } finally {
+ _cryptoAmountChangeLock = wasLocked;
+ }
+ }
+
void _cryptoAmountChanged() async {
- _xelisSendAll = false;
if (!_cryptoAmountChangeLock) {
- final cryptoAmount = ref
- .read(pAmountFormatter(coin))
- .tryParseEditable(cryptoAmountController.text);
+ _xelisSendAll = false;
+ final cryptoAmount = AmountParser.tryParseEditable(
+ cryptoAmountController.text,
+ locale: ref.read(localeServiceChangeNotifierProvider).locale,
+ unit: ref.read(pAmountUnit(coin)),
+ coin: coin,
+ );
final Amount? amount;
if (cryptoAmount != null) {
amount = cryptoAmount;
@@ -1438,6 +1453,7 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
}
void fiatTextFieldOnChanged(String baseAmountString) {
+ _xelisSendAll = false;
final baseAmount = Amount.tryParseFiatString(
baseAmountString,
locale: ref.read(localeServiceChangeNotifierProvider).locale,
@@ -1648,15 +1664,17 @@ class _DesktopSendState extends ConsumerState<DesktopSend> {
listenForAmountRelocalization(
ref.listen,
controllers: [cryptoAmountController, baseAmountController],
- onRelocalized: _cryptoAmountChanged,
+ updateControllers: _updateAmountDisplay,
);
// Keep the amount, rather than the number typed, when the unit changes.
ref.listen<AmountFormatter>(pAmountFormatter(coin), (previous, next) {
final amount = ref.read(pSendAmount);
if (previous?.unit != next.unit && amount != null) {
// Only the display changes, so keep the send all intent.
final xelisSendAll = _xelisSendAll;
- cryptoAmountController.text = next.formatEditable(amount);
+ _updateAmountDisplay(() {
+ cryptoAmountController.text = next.formatEditable(amount);
+ });
_xelisSendAll = xelisSendAll;
}
});
### lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_token_send.dart
@@ -29,6 +29,7 @@ import '../../../../utilities/address_utils.dart';
import '../../../../utilities/amount/amount.dart';
import '../../../../utilities/amount/amount_field_relocalization.dart';
import '../../../../utilities/amount/amount_formatter.dart';
+import '../../../../utilities/amount/amount_parser.dart';
import '../../../../utilities/amount/amount_input_formatter.dart';
import '../../../../utilities/amount/amount_unit.dart';
import '../../../../utilities/clipboard_interface.dart';
@@ -373,14 +374,26 @@ class _DesktopTokenSendState extends ConsumerState<DesktopTokenSend> {
amount ?? Amount.zeroWith(fractionDigits: tokenDecimals);
}
+ // Controller assignments used for display must not edit the stored amount.
+ void _updateAmountDisplay(VoidCallback update) {
+ final wasLocked = _cryptoAmountChangeLock;
+ _cryptoAmountChangeLock = true;
+ try {
+ update();
+ } finally {
+ _cryptoAmountChangeLock = wasLocked;
+ }
+ }
+
void _cryptoAmountChanged() async {
if (!_cryptoAmountChangeLock) {
- final cryptoAmount = ref
- .read(pAmountFormatter(coin))
- .tryParseEditable(
- cryptoAmountController.text,
- tokenContract: ref.read(pCurrentTokenWallet)!.tokenContract,
- );
+ final cryptoAmount = AmountParser.tryParseEditable(
+ cryptoAmountController.text,
+ locale: ref.read(localeServiceChangeNotifierProvider).locale,
+ unit: ref.read(pAmountUnit(coin)),
+ coin: coin,
+ tokenContract: ref.read(pCurrentTokenWallet)!.tokenContract,
+ );
if (cryptoAmount != null) {
_amountToSend = cryptoAmount;
@@ -700,8 +713,15 @@ class _DesktopTokenSendState extends ConsumerState<DesktopTokenSend> {
listenForAmountRelocalization(
ref.listen,
controllers: [cryptoAmountController, baseAmountController],
- onRelocalized: _cryptoAmountChanged,
+ updateControllers: _updateAmountDisplay,
);
+ ref.listen<AmountFormatter>(pAmountFormatter(coin), (previous, next) {
+ if (previous?.unit != next.unit && _amountToSend != null) {
+ _updateAmountDisplay(() {
+ cryptoAmountController.text = next.formatEditable(_amountToSend!);
+ });
+ }
+ });
final isCustomFee = ref.watch(feeRateTypeDesktopStateProvider).isCustom;
// ethFee is checked in the ValueListenableBuilder around the preview
// button so fee keystrokes don't rebuild this whole view.
### lib/utilities/amount/amount_field_relocalization.dart
@@ -57,23 +57,36 @@ void relocalizeAmountController(
/// parsers, then invokes [onRelocalized] so the caller can re-run any
/// parsing/validation that cached state from the old text.
///
+/// [updateControllers] can wrap the assignments to suppress input listeners.
+/// Use it when the caller stores a canonical amount: a display change must not
+/// be interpreted as another edit of that amount.
+///
/// Must be called from a widget's build method with `ref.listen`.
void listenForAmountRelocalization(
ProviderListen<String> listen, {
required List<TextEditingController> controllers,
VoidCallback? onRelocalized,
+ void Function(VoidCallback update)? updateControllers,
}) {
listen(localeServiceChangeNotifierProvider.select((value) => value.locale), (
previous,
next,
) {
if (previous == null || previous == next) return;
- for (final controller in controllers) {
- relocalizeAmountController(
- controller,
- sourceLocale: previous,
- targetLocale: next,
- );
+ void update() {
+ for (final controller in controllers) {
+ relocalizeAmountController(
+ controller,
+ sourceLocale: previous,
+ targetLocale: next,
+ );
+ }
+ }
+
+ if (updateControllers == null) {
+ update();
+ } else {
+ updateControllers(update);
}
onRelocalized?.call();
});
### lib/utilities/amount/amount_formatter.dart
@@ -69,13 +69,4 @@ class AmountFormatter {
String formatEditable(Amount amount) {
return unit.formatEditable(amount: amount, locale: locale);
}
-
- Amount? tryParseEditable(String string, {Contract? tokenContract}) {
- return unit.tryParse(
- string,
- locale: locale,
- coin: coin,
- tokenContract: tokenContract,
- );
- }
}
### lib/utilities/amount/amount_parser.dart
@@ -0,0 +1,24 @@
+import '../../models/isar/models/contract.dart';
+import '../../wallets/crypto_currency/crypto_currency.dart';
+import 'amount.dart';
+import 'amount_unit.dart';
+
+/// Parses editable text using the locale and unit associated with that text.
+///
+/// Parsing deliberately has no provider or cached formatting preferences.
+/// Display updates must preserve the canonical amount instead of parsing their
+/// own output. Only input changes should call this API.
+abstract final class AmountParser {
+ static Amount? tryParseEditable(
+ String text, {
+ required String locale,
+ required AmountUnit unit,
+ required CryptoCurrency coin,
+ Contract? tokenContract,
+ }) => unit.tryParse(
+ text,
+ locale: locale,
+ coin: coin,
+ tokenContract: tokenContract,
+ );
+}
### test/pages/send_view/amount_display_updates_test.dart
@@ -0,0 +1,240 @@
+import 'dart:io';
+
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:platform/platform.dart' as platform;
+import 'package:stackwallet/models/balance.dart';
+import 'package:stackwallet/models/isar/models/blockchain_data/address.dart';
+import 'package:stackwallet/models/isar/stack_theme.dart';
+import 'package:stackwallet/pages/send_view/send_view.dart';
+import 'package:stackwallet/pages/salvium_stake/salvium_create_stake_view.dart';
+import 'package:stackwallet/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart';
+import 'package:stackwallet/providers/global/locale_provider.dart';
+import 'package:stackwallet/providers/global/prefs_provider.dart';
+import 'package:stackwallet/providers/global/wallets_provider.dart';
+import 'package:stackwallet/providers/ui/preview_tx_button_state_provider.dart';
+import 'package:stackwallet/services/locale_service.dart';
+import 'package:stackwallet/themes/coin_icon_provider.dart';
+import 'package:stackwallet/themes/stack_colors.dart';
+import 'package:stackwallet/themes/theme_providers.dart';
+import 'package:stackwallet/utilities/amount/amount.dart';
+import 'package:stackwallet/utilities/amount/amount_unit.dart';
+import 'package:stackwallet/utilities/stack_file_system.dart';
+import 'package:stackwallet/utilities/util.dart';
+import 'package:stackwallet/wallets/crypto_currency/crypto_currency.dart';
+import 'package:stackwallet/wallets/isar/models/wallet_info.dart';
+import 'package:stackwallet/wallets/isar/providers/wallet_info_provider.dart';
+import 'package:stackwallet/widgets/desktop/primary_button.dart';
+
+import '../../sample_data/theme_json.dart';
+import '../../wallets/support/xelis_test_fakes.dart';
+
+class _Locale extends LocaleService {
+ String value = 'en_US';
+ @override
+ String get locale => value;
+ void change(String next) {
+ value = next;
+ notifyListeners();
+ }
+}
+
+class _Prefs extends ConfirmationPrefs {
+ @override
+ bool get enableCoinControl => false;
+ AmountUnit selectedUnit = AmountUnit.normal;
+ @override
+ AmountUnit amountUnit(CryptoCurrency coin) => selectedUnit;
+ @override
+ int maxDecimals(CryptoCurrency coin) => coin.fractionDigits;
+ void changeUnit(AmountUnit next) {
+ selectedUnit = next;
+ notifyListeners();
+ }
+}
+
+void main() {
+ const walletId = 'provider-audit-wallet';
+ void setupLayout(WidgetTester tester, bool desktop) {
+ final oldPlatform = Util.layoutPlatform;
+ final oldThemesDir = StackFileSystem.themesDir;
+ Util.layoutPlatform = platform.FakePlatform(
+ operatingSystem: desktop ? 'linux' : 'android',
+ );
+ StackFileSystem.themesDir = Directory('test/sample_data').absolute;
+ tester.view.physicalSize = const Size(1200, 1800);
+ tester.view.devicePixelRatio = 1;
+ addTearDown(() {
+ Util.layoutPlatform = oldPlatform;
+ StackFileSystem.themesDir = oldThemesDir;
+ tester.view.resetPhysicalSize();
+ tester.view.resetDevicePixelRatio();
+ });
+ }
+
+ Future<void> pump(
+ WidgetTester tester,
+ ProviderContainer container,
+ Widget child,
+ ) async {
+ final theme = StackTheme.fromJson(json: lightThemeJsonMap);
+ await tester.pumpWidget(
+ UncontrolledProviderScope(
+ container: container,
+ child: MaterialApp(
+ theme: ThemeData(
+ extensions: [StackColors.fromStackColorTheme(theme)],
+ ),
+ home: Util.isDesktop
+ ? Scaffold(body: SingleChildScrollView(child: child))
+ : child,
+ ),
+ ),
+ );
+ await tester.pumpAndSettle();
+ expect(tester.takeException(), isNull);
+ }
+
+ for (final desktop in [false, true]) {
+ testWidgets('normal send preserves amount on locale change ($desktop)', (
+ tester,
+ ) async {
+ setupLayout(tester, desktop);
+ final wallet = TestWallet(FakeNative());
+ final coin = wallet.cryptoCurrency;
+ final info = WalletInfo(
+ walletId: walletId,
+ name: 'Audit wallet',
+ mainAddressType: AddressType.xelis,
+ coinName: coin.identifier,
+ );
+ final locale = _Locale();
+ final prefs = _Prefs();
+ final theme = StackTheme.fromJson(json: lightThemeJsonMap);
+ final container = ProviderContainer(
+ overrides: [
+ pWallets.overrideWithValue(ConfirmationWallets(wallet)),
+ pWalletInfo(walletId).overrideWithValue(info),
+ pWalletCoin(walletId).overrideWithValue(coin),
+ pWalletName(walletId).overrideWithValue(info.name),
+ pWalletBalance(walletId)
+ .overrideWithValue(Balance.zeroFor(currency: coin)),
+ prefsChangeNotifierProvider.overrideWithValue(prefs),
+ localeServiceChangeNotifierProvider.overrideWithValue(locale),
+ themeProvider.overrideWithProvider(StateProvider((ref) => theme)),
+ coinIconProvider(coin).overrideWithValue(
+ File('test/sample_data/light/assets/dummy.svg').absolute.path,
+ ),
+ ],
+ );
+ addTearDown(container.dispose);
+ await pump(
+ tester,
+ container,
+ desktop
+ ? const DesktopSend(walletId: walletId)
+ : SendView(walletId: walletId, coin: coin),
+ );
+ final field = find.byKey(const Key('amountInputFieldCryptoTextFieldKey'));
+ await tester.enterText(field, '1.25');
+ await tester.pump(const Duration(milliseconds: 600));
+ final expected = container.read(pSendAmount);
+ expect(
+ expected,
+ Amount(
+ rawValue: BigInt.from(125000000),
+ fractionDigits: coin.fractionDigits,
+ ),
+ );
+ locale.change('de_DE');
+ await tester.pump(const Duration(milliseconds: 600));
+ final actual = container.read(pSendAmount);
+ final text = tester.widget<TextField>(field).controller!.text;
+ expect(text, '1,25');
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ expect(
+ actual,
+ expected,
+ reason: 'Locale change must preserve the canonical send amount',
+ );
+ });
+ testWidgets('Salvium stake keeps amount and unit consistent ($desktop)', (
+ tester,
+ ) async {
+ setupLayout(tester, desktop);
+ final coin = Salvium(CryptoCurrencyNetwork.main);
+ final prefs = _Prefs();
+ final container = ProviderContainer(
+ overrides: [
+ pWalletCoin(walletId).overrideWithValue(coin),
+ themeProvider.overrideWithProvider(
+ StateProvider(
+ (ref) => StackTheme.fromJson(json: lightThemeJsonMap),
+ ),
+ ),
+ prefsChangeNotifierProvider.overrideWithValue(prefs),
+ localeServiceChangeNotifierProvider.overrideWithValue(_Locale()),
+ ],
+ );
+ addTearDown(container.dispose);
+ await pump(
+ tester,
+ container,
+ const SalviumCreateStakeView(walletId: walletId),
+ );
+ final field = find.byType(TextField).first;
+ await tester.enterText(field, '1.25');
+ await tester.pump();
+ prefs.changeUnit(AmountUnit.milli);
+ await tester.pump();
+ final text = tester.widget<TextField>(field).controller!.text;
+ final preview = find.widgetWithText(PrimaryButton, 'Preview');
+ expect(tester.widget<PrimaryButton>(preview).enabled, true);
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ expect(text, '1250', reason: '1.25 SAL must display as 1250 mSAL');
+ });
+ testWidgets('Salvium stake preserves amount on locale change ($desktop)', (
+ tester,
+ ) async {
+ setupLayout(tester, desktop);
+ final coin = Salvium(CryptoCurrencyNetwork.main);
+ final locale = _Locale();
+ final container = ProviderContainer(
+ overrides: [
+ pWalletCoin(walletId).overrideWithValue(coin),
+ themeProvider.overrideWithProvider(
+ StateProvider(
+ (ref) => StackTheme.fromJson(json: lightThemeJsonMap),
+ ),
+ ),
+ prefsChangeNotifierProvider.overrideWithValue(_Prefs()),
+ localeServiceChangeNotifierProvider.overrideWithValue(locale),
+ ],
+ );
+ addTearDown(container.dispose);
+ await pump(
+ tester,
+ container,
+ const SalviumCreateStakeView(walletId: walletId),
+ );
+ final field = find.byType(TextField).first;
+ await tester.enterText(field, '1.25');
+ await tester.pump();
+ final preview = find.widgetWithText(PrimaryButton, 'Preview');
+ expect(tester.widget<PrimaryButton>(preview).enabled, true);
+ locale.change('de_DE');
+ await tester.pump();
+ final enabled = tester.widget<PrimaryButton>(preview).enabled;
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ expect(
+ enabled,
+ true,
+ reason: 'Relocalizing the stake must preserve the valid amount',
+ );
+ });
+ }
+}
### test/pages/send_view/amount_input_transition_test.dart
@@ -0,0 +1,262 @@
+import 'dart:io';
+
+import 'package:decimal/decimal.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:platform/platform.dart' as platform;
+import 'package:stackwallet/models/balance.dart';
+import 'package:stackwallet/models/isar/models/blockchain_data/address.dart';
+import 'package:stackwallet/models/isar/stack_theme.dart';
+import 'package:stackwallet/pages/send_view/send_view.dart';
+import 'package:stackwallet/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_send.dart';
+import 'package:stackwallet/providers/global/locale_provider.dart';
+import 'package:stackwallet/providers/global/prefs_provider.dart';
+import 'package:stackwallet/providers/global/price_provider.dart';
+import 'package:stackwallet/providers/global/wallets_provider.dart';
+import 'package:stackwallet/providers/ui/preview_tx_button_state_provider.dart';
+import 'package:stackwallet/services/locale_service.dart';
+import 'package:stackwallet/services/price_service.dart';
+import 'package:stackwallet/themes/coin_icon_provider.dart';
+import 'package:stackwallet/themes/stack_colors.dart';
+import 'package:stackwallet/themes/theme_providers.dart';
+import 'package:stackwallet/utilities/amount/amount.dart';
+import 'package:stackwallet/utilities/amount/amount_unit.dart';
+import 'package:stackwallet/utilities/stack_file_system.dart';
+import 'package:stackwallet/utilities/util.dart';
+import 'package:stackwallet/wallets/crypto_currency/crypto_currency.dart';
+import 'package:stackwallet/wallets/isar/models/wallet_info.dart';
+import 'package:stackwallet/wallets/isar/providers/wallet_info_provider.dart';
+import 'package:stackwallet/wallets/models/tx_data.dart';
+import 'package:stackwallet/widgets/desktop/primary_button.dart';
+
+import '../../sample_data/theme_json.dart';
+import '../../wallets/support/xelis_test_fakes.dart';
+
+class _Locale extends LocaleService {
+ String value = 'en_US';
+ @override
+ String get locale => value;
+ void change(String next) {
+ value = next;
+ notifyListeners();
+ }
+}
+
+class _Prefs extends ConfirmationPrefs {
+ @override
+ bool get enableCoinControl => false;
+ @override
+ bool get externalCalls => true;
+ AmountUnit selectedUnit = AmountUnit.normal;
+ @override
+ AmountUnit amountUnit(CryptoCurrency coin) => selectedUnit;
+ @override
+ int maxDecimals(CryptoCurrency coin) => coin.fractionDigits;
+ void changeUnit(AmountUnit next) {
+ selectedUnit = next;
+ notifyListeners();
+ }
+}
+
+class _Price extends PriceService {
+ _Price() : super('USD');
+ @override
+ ({Decimal value, double change24h})? getPrice(CryptoCurrency coin) =>
+ (value: Decimal.one, change24h: 0);
+}
+
+class _ValidXelis extends Xelis {
+ _ValidXelis() : super(CryptoCurrencyNetwork.test);
+ @override
+ bool validateAddress(String address) => address.isNotEmpty;
+}
+
+class _CaptureWallet extends TestWallet {
+ _CaptureWallet() : super(FakeNative());
+ final _coin = _ValidXelis();
+ @override
+ Xelis get cryptoCurrency => _coin;
+ late WalletInfo testInfo;
+ TxData? captured;
+ @override
+ WalletInfo get info => testInfo;
+ @override
+ Future<TxData> prepareSend({required TxData txData, String? assetId}) async {
+ captured = txData;
+ throw StateError('captured test transaction');
+ }
+}
+
+void main() {
+ const walletId = 'review-wallet';
+ Future<ProviderContainer> mount(
+ WidgetTester tester,
+ bool desktop,
+ _CaptureWallet wallet,
+ _Prefs prefs,
+ _Locale locale,
+ ) async {
+ final oldPlatform = Util.layoutPlatform;
+ final oldThemes = StackFileSystem.themesDir;
+ Util.layoutPlatform = platform.FakePlatform(
+ operatingSystem: desktop ? 'linux' : 'android',
+ );
+ StackFileSystem.themesDir = Directory('test/sample_data').absolute;
+ tester.view.physicalSize = const Size(1200, 1800);
+ tester.view.devicePixelRatio = 1;
+ addTearDown(() {
+ Util.layoutPlatform = oldPlatform;
+ StackFileSystem.themesDir = oldThemes;
+ tester.view.resetPhysicalSize();
+ tester.view.resetDevicePixelRatio();
+ });
+ final coin = wallet.cryptoCurrency;
+ final info = WalletInfo(
+ walletId: walletId,
+ name: 'Test wallet',
+ mainAddressType: AddressType.xelis,
+ coinName: coin.identifier,
+ );
+ wallet.testInfo = info;
+ final theme = StackTheme.fromJson(json: lightThemeJsonMap);
+ final amount = Amount(
+ rawValue: BigInt.from(1000000000),
+ fractionDigits: coin.fractionDigits,
+ );
+ final zero = Amount.zeroWith(fractionDigits: coin.fractionDigits);
+ final balance = Balance(
+ total: amount,
+ spendable: amount,
+ blockedTotal: zero,
+ pendingSpendable: zero,
+ );
+ final container = ProviderContainer(
+ overrides: [
+ pWallets.overrideWithValue(ConfirmationWallets(wallet)),
+ pWalletInfo(walletId).overrideWithValue(info),
+ pWalletCoin(walletId).overrideWithValue(coin),
+ pWalletName(walletId).overrideWithValue(info.name),
+ pWalletBalance(walletId).overrideWithValue(balance),
+ prefsChangeNotifierProvider.overrideWithValue(prefs),
+ localeServiceChangeNotifierProvider.overrideWithValue(locale),
+ priceAnd24hChangeNotifierProvider.overrideWithValue(_Price()),
+ themeProvider.overrideWithProvider(StateProvider((ref) => theme)),
+ coinIconProvider(coin).overrideWithValue(
+ File('test/sample_data/light/assets/dummy.svg').absolute.path,
+ ),
+ ],
+ );
+ addTearDown(container.dispose);
+ final child = desktop
+ ? const DesktopSend(walletId: walletId)
+ : SendView(walletId: walletId, coin: coin);
+ await tester.pumpWidget(
+ UncontrolledProviderScope(
+ container: container,
+ child: MaterialApp(
+ theme: ThemeData(
+ extensions: [StackColors.fromStackColorTheme(theme)],
+ ),
+ home: desktop
+ ? Scaffold(body: SingleChildScrollView(child: child))
+ : child,
+ ),
+ ),
+ );
+ await tester.pumpAndSettle();
+ expect(tester.takeException(), isNull);
+ addTearDown(() async {
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ });
+ return container;
+ }
+
+ for (final desktop in [false, true]) {
+ for (final unitFirst in [false, true]) {
+ testWidgets(
+ 'same frame locale and unit desktop=$desktop unitFirst=$unitFirst',
+ (tester) async {
+ final prefs = _Prefs();
+ final locale = _Locale();
+ final container = await mount(
+ tester,
+ desktop,
+ _CaptureWallet(),
+ prefs,
+ locale,
+ );
+ final field = find.byKey(
+ const Key('amountInputFieldCryptoTextFieldKey'),
+ );
+ await tester.enterText(field, '1.2501');
+ await tester.pump(const Duration(milliseconds: 600));
+ final expected = container.read(pSendAmount);
+ if (unitFirst) {
+ prefs.changeUnit(AmountUnit.milli);
+ locale.change('de_DE');
+ } else {
+ locale.change('de_DE');
+ prefs.changeUnit(AmountUnit.milli);
+ }
+ await tester.pump(const Duration(milliseconds: 600));
+ expect(container.read(pSendAmount), expected);
+ expect(tester.widget<TextField>(field).controller!.text, '1250,1');
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ },
+ );
+ }
+ testWidgets('fiat input clears send all desktop=$desktop', (tester) async {
+ final prefs = _Prefs();
+ final locale = _Locale();
+ final wallet = _CaptureWallet();
+ final container = await mount(tester, desktop, wallet, prefs, locale);
+ final sendAll = find.textContaining('Send all', findRichText: true);
+ if (sendAll.evaluate().isEmpty) {
+ expect(find.textContaining('Send all'), findsOneWidget);
+ }
+ final sendAllActual = sendAll.evaluate().isEmpty
+ ? find.textContaining('Send all')
+ : sendAll;
+ await tester.ensureVisible(sendAllActual);
+ await tester.tap(sendAllActual);
+ await tester.pump();
+ expect(container.read(pSendAmount)!.decimal, Decimal.fromInt(10));
+ final fiat = find.byKey(const Key('amountInputFieldFiatTextFieldKey'));
+ expect(fiat, findsOneWidget);
+ await tester.enterText(fiat, '1');
+ await tester.pump(const Duration(milliseconds: 600));
+ expect(container.read(pSendAmount)!.decimal, Decimal.one);
+ final address = find.byKey(const Key('sendViewAddressFieldKey'));
+ await tester.enterText(address, 'some-address');
+ await tester.pump();
+ // Trigger the current preview callback without relying on scroll position.
+ if (desktop) {
+ final preview = tester.widget<PrimaryButton>(
+ find.widgetWithText(PrimaryButton, 'Preview send'),
+ );
+ expect(preview.enabled, true);
+ preview.onPressed!();
+ } else {
+ final preview = tester.widget<TextButton>(
+ find.widgetWithText(TextButton, 'Preview'),
+ );
+ expect(preview.onPressed, isNotNull);
+ preview.onPressed!();
+ }
+ await tester.pump(const Duration(milliseconds: 150));
+ await tester.pump(const Duration(milliseconds: 2600));
+ expect(wallet.captured, isNotNull);
+ expect(wallet.captured!.recipients!.single.amount.decimal, Decimal.one);
+ expect(
+ wallet.captured!.xelisSendAll,
+ false,
+ reason: 'Editing the fiat amount must cancel send-all intent',
+ );
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ });
+ }
+}
### test/pages/send_view/frost_ms/recipient_test.dart
@@ -30,6 +30,18 @@ class _TestMonero extends Monero {
bool validateAddress(String address) => address.startsWith("address");
}
+class _TestLocaleService extends LocaleService {
+ String _locale = "en_US";
+
+ @override
+ String get locale => _locale;
+
+ void setLocale(String locale) {
+ _locale = locale;
+ notifyListeners();
+ }
+}
+
/// The mobile camera scanner, returning [rawContent].
class _FakeScanner implements BarcodeScannerInterface {
_FakeScanner(this.rawContent);
@@ -59,6 +71,7 @@ void main() {
late List<PaymentUriData> multiRecipientUris;
late _FakeScanner scanner;
late List<String> messages;
+ late _TestLocaleService localeService;
/// Lays widgets out for desktop or mobile on any host platform.
void useLayout({required bool desktop}) {
@@ -85,24 +98,17 @@ void main() {
clipboard = FakeClipboard();
multiRecipientUris = [];
messages = [];
+ localeService = _TestLocaleService();
container = ProviderContainer(
overrides: [
pAmountUnit.overrideWithProvider(
(_) => Provider((ref) => ref.watch(unit)),
),
- pAmountFormatter.overrideWithProvider(
- (coin) => Provider(
- (ref) => AmountFormatter(
- unit: ref.watch(pAmountUnit(coin)),
- locale: "en_US",
- coin: coin,
- maxDecimals: coin.fractionDigits,
- ),
- ),
- ),
- localeServiceChangeNotifierProvider.overrideWithProvider(
- ChangeNotifierProvider((_) => LocaleService()),
+ // Use the production formatter so locale/provider ordering is tested.
+ pMaxDecimals.overrideWithProvider(
+ (coin) => Provider((_) => coin.fractionDigits),
),
+ localeServiceChangeNotifierProvider.overrideWithValue(localeService),
pClipboard.overrideWithValue(clipboard),
pBarcodeScanner.overrideWithValue(scanner),
],
@@ -267,6 +273,52 @@ void main() {
expect(recipient()!.label, isNull);
});
+ for (final desktop in [false, true]) {
+ testWidgets("keeps the recipient amount across locale changes "
+ "on ${desktop ? 'desktop' : 'mobile'}", (tester) async {
+ useLayout(desktop: desktop);
+ await pumpRecipient(
+ tester,
+ initial: (
+ address: "address0",
+ amount: xmr("1.000000000001"),
+ label: "Alice",
+ ),
+ );
+
+ localeService.setLocale("de_DE");
+ await tester.pump();
+ await tester.pump();
+ expect(text(tester, amountField()), "1,000000000001");
+ expect(
+ recipient(),
+ (address: "address0", amount: xmr("1.000000000001"), label: "Alice"),
+ reason:
+ "Changing locale must preserve the stored amount, "
+ "not just its text",
+ );
+
+ await tester.enterText(amountField(), "2,000000000001");
+ await tester.pump();
+ expect(recipient()?.amount, xmr("2.000000000001"));
+
+ localeService.setLocale("en_US");
+ await tester.pump();
+ await tester.pump();
+ expect(text(tester, amountField()), "2.000000000001");
+ expect(recipient()?.amount, xmr("2.000000000001"));
+ expect(recipient()?.label, "Alice");
+
+ await tester.enterText(addressField(), "address1");
+ await tester.pump();
+ expect(recipient(), (
+ address: "address1",
+ amount: xmr("2.000000000001"),
+ label: null,
+ ));
+ });
+ }
+
testWidgets("fills the address, amount, and name from a pasted request", (
tester,
) async {
### test/pages/send_view/recipient_amount_context_test.dart
@@ -0,0 +1,117 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:platform/platform.dart' as platform;
+import 'package:stackwallet/models/isar/stack_theme.dart';
+import 'package:stackwallet/pages/send_view/frost_ms/recipient.dart';
+import 'package:stackwallet/providers/global/locale_provider.dart';
+import 'package:stackwallet/services/locale_service.dart';
+import 'package:stackwallet/themes/stack_colors.dart';
+import 'package:stackwallet/utilities/amount/amount.dart';
+import 'package:stackwallet/utilities/amount/amount_formatter.dart';
+import 'package:stackwallet/utilities/amount/amount_unit.dart';
+import 'package:stackwallet/utilities/util.dart';
+import 'package:stackwallet/wallets/crypto_currency/crypto_currency.dart';
+
+import '../../sample_data/theme_json.dart';
+
+class _TestMonero extends Monero {
+ _TestMonero() : super(CryptoCurrencyNetwork.main);
+ @override
+ bool validateAddress(String address) => address.startsWith("address");
+}
+
+class _Locale extends LocaleService {
+ String _locale = "en_US";
+ @override
+ String get locale => _locale;
+ void setLocale(String l) {
+ _locale = l;
+ notifyListeners();
+ }
+}
+
+void main() {
+ final coin = _TestMonero();
+ const RecipientId id = (walletId: "wallet", index: 1);
+ Amount xmr(String v) =>
+ Amount.tryParseCanonicalAmount(v, fractionDigits: coin.fractionDigits)!;
+
+ for (final unitFirst in [false, true]) {
+ testWidgets('recipient same-frame unit+locale unitFirst=$unitFirst', (
+ tester,
+ ) async {
+ final prev = Util.layoutPlatform;
+ Util.layoutPlatform = platform.FakePlatform(operatingSystem: "android");
+ addTearDown(() => Util.layoutPlatform = prev);
+ final unit = StateProvider((_) => AmountUnit.normal);
+ final locale = _Locale();
+ final container = ProviderContainer(
+ overrides: [
+ pAmountUnit.overrideWithProvider(
+ (_) => Provider((ref) => ref.watch(unit)),
+ ),
+ pMaxDecimals.overrideWithProvider(
+ (coin) => Provider((_) => coin.fractionDigits),
+ ),
+ localeServiceChangeNotifierProvider.overrideWithValue(locale),
+ ],
+ );
+ addTearDown(container.dispose);
+ container.read(pRecipient(id).notifier).state = (
+ address: "address0",
+ amount: xmr("1.2501"),
+ label: null,
+ );
+ await tester.pumpWidget(
+ UncontrolledProviderScope(
+ container: container,
+ child: MaterialApp(
+ theme: ThemeData(
+ extensions: [
+ StackColors.fromStackColorTheme(
+ StackTheme.fromJson(json: lightThemeJsonMap),
+ ),
+ ],
+ ),
+ home: Scaffold(
+ body: SingleChildScrollView(
+ child: Recipient(
+ walletId: id.walletId,
+ index: id.index,
+ displayNumber: 1,
+ coin: coin,
+ remove: () {},
+ addAnotherRecipientTapped: () {},
+ sendAllTapped: () => "",
+ ),
+ ),
+ ),
+ ),
+ ),
+ );
+ final amountField = find.byKey(
+ const Key("amountInputFieldCryptoTextFieldKey"),
+ );
+ final addressField = find.byKey(const Key("sendViewAddressFieldKey"));
+ String text() => tester.widget<TextField>(amountField).controller!.text;
+ expect(text(), "1.2501");
+
+ if (unitFirst) {
+ container.read(unit.notifier).state = AmountUnit.milli;
+ locale.setLocale("de_DE");
+ } else {
+ locale.setLocale("de_DE");
+ container.read(unit.notifier).state = AmountUnit.milli;
+ }
+ await tester.pump();
+ await tester.pump();
+ expect(text(), "1250,1");
+ expect(container.read(pRecipient(id))?.amount, xmr("1.2501"));
+
+ await tester.enterText(addressField, "address1");
+ await tester.pump();
+ expect(container.read(pRecipient(id))?.amount, xmr("1.2501"));
+ });
+ }
+}
### test/pages/send_view/token_amount_display_updates_test.dart
@@ -0,0 +1,271 @@
+import 'dart:io';
+
+import 'package:decimal/decimal.dart';
+import 'package:flutter/material.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:platform/platform.dart' as platform;
+import 'package:stackwallet/models/balance.dart';
+import 'package:stackwallet/models/isar/models/blockchain_data/address.dart';
+import 'package:stackwallet/models/isar/models/ethereum/eth_contract.dart';
+import 'package:stackwallet/models/isar/stack_theme.dart';
+import 'package:stackwallet/models/paymint/fee_object_model.dart';
+import 'package:stackwallet/pages/send_view/token_send_view.dart';
+import 'package:stackwallet/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_token_send.dart';
+import 'package:stackwallet/providers/global/locale_provider.dart';
+import 'package:stackwallet/providers/global/prefs_provider.dart';
+import 'package:stackwallet/providers/global/price_provider.dart';
+import 'package:stackwallet/providers/global/wallets_provider.dart';
+import 'package:stackwallet/services/locale_service.dart';
+import 'package:stackwallet/services/price_service.dart';
+import 'package:stackwallet/themes/coin_icon_provider.dart';
+import 'package:stackwallet/themes/stack_colors.dart';
+import 'package:stackwallet/themes/theme_providers.dart';
+import 'package:stackwallet/utilities/amount/amount.dart';
+import 'package:stackwallet/utilities/amount/amount_unit.dart';
+import 'package:stackwallet/utilities/default_eth_tokens.dart';
+import 'package:stackwallet/utilities/stack_file_system.dart';
+import 'package:stackwallet/utilities/util.dart';
+import 'package:stackwallet/wallets/crypto_currency/crypto_currency.dart';
+import 'package:stackwallet/wallets/isar/models/wallet_info.dart';
+import 'package:stackwallet/wallets/isar/providers/eth/current_token_wallet_provider.dart';
+import 'package:stackwallet/wallets/isar/providers/eth/token_balance_provider.dart';
+import 'package:stackwallet/wallets/isar/providers/wallet_info_provider.dart';
+import 'package:stackwallet/wallets/models/tx_data.dart';
+import 'package:stackwallet/wallets/wallet/impl/sub_wallets/eth_token_wallet.dart';
+import 'package:stackwallet/wallets/wallet/wallet.dart';
+import 'package:stackwallet/widgets/desktop/primary_button.dart';
+
+import '../../sample_data/theme_json.dart';
+import '../../wallets/support/xelis_test_fakes.dart';
+
+class _Locale extends LocaleService {
+ String value = 'en_US';
+ @override
+ String get locale => value;
+ void change(String next) {
+ value = next;
+ notifyListeners();
+ }
+}
+
+class _Prefs extends ConfirmationPrefs {
+ AmountUnit value = AmountUnit.normal;
+ @override
+ bool get enableCoinControl => false;
+ @override
+ bool get externalCalls => false;
+ @override
+ AmountUnit amountUnit(CryptoCurrency coin) => value;
+ @override
+ int maxDecimals(CryptoCurrency coin) => coin.fractionDigits;
+ void change(AmountUnit next) {
+ value = next;
+ notifyListeners();
+ }
+}
+
+class _Price extends PriceService {
+ _Price() : super('USD');
+ @override
+ ({Decimal value, double change24h})? getTokenPrice(String contractAddress) =>
+ (value: Decimal.one, change24h: 0);
+}
+
+EthFeeObject get _fees => EthFeeObject(
+ suggestBaseFee: BigInt.one,
+ numberOfBlocksFast: 1,
+ numberOfBlocksAverage: 1,
+ numberOfBlocksSlow: 1,
+ fast: BigInt.one,
+ medium: BigInt.one,
+ slow: BigInt.one,
+);
+
+class _ParentWallet extends Fake implements Wallet<Ethereum> {
+ _ParentWallet(this.info);
+ @override
+ final WalletInfo info;
+ @override
+ Ethereum get cryptoCurrency => info.coin as Ethereum;
+ @override
+ Future<FeeObject> get fees async => _fees;
+ @override
+ Future<Amount> estimateFeeFor(Amount amount, BigInt feeRate) async =>
+ Amount.zeroWith(fractionDigits: 18);
+}
+
+class _TokenWallet extends Fake implements EthTokenWallet {
+ _TokenWallet(this.tokenContract, this.info);
+ @override
+ final EthContract tokenContract;
+ @override
+ final WalletInfo info;
+ @override
+ Ethereum get cryptoCurrency => info.coin as Ethereum;
+ @override
+ Future<EthFeeObject> get fees async => _fees;
+ @override
+ Future<Amount> estimateFeeFor(Amount amount, BigInt feeRate) async =>
+ Amount.zeroWith(fractionDigits: 18);
+ TxData? captured;
+ @override
+ Future<TxData> prepareSend({required TxData txData, String? assetId}) async {
+ captured = txData;
+ throw StateError('capture');
+ }
+}
+
+void main() {
+ const walletId = 'token-r2';
+ for (final desktop in [false, true]) {
+ for (final decimals in [6, 8, 18]) {
+ for (final unitFirst in [false, true]) {
+ testWidgets(
+ 'token input transitions desktop=$desktop decimals=$decimals unitFirst=$unitFirst',
+ (tester) async {
+ final oldPlatform = Util.layoutPlatform;
+ final oldThemes = StackFileSystem.themesDir;
+ Util.layoutPlatform = platform.FakePlatform(
+ operatingSystem: desktop ? 'linux' : 'android',
+ );
+ StackFileSystem.themesDir = Directory('test/sample_data').absolute;
+ tester.view.physicalSize = const Size(1200, 1800);
+ tester.view.devicePixelRatio = 1;
+ addTearDown(() {
+ Util.layoutPlatform = oldPlatform;
+ StackFileSystem.themesDir = oldThemes;
+ tester.view.resetPhysicalSize();
+ tester.view.resetDevicePixelRatio();
+ });
+ final coin = Ethereum(CryptoCurrencyNetwork.main);
+ final contract = DefaultTokens.rsFiro.copyWith(decimals: decimals);
+ final info = WalletInfo(
+ walletId: walletId,
+ name: 'Token test',
+ mainAddressType: AddressType.ethereum,
+ coinName: coin.identifier,
+ );
+ final wallet = _ParentWallet(info);
+ final tokenWallet = _TokenWallet(contract, info);
+ final prefs = _Prefs();
+ final locale = _Locale();
+ final zero = Amount.zeroWith(fractionDigits: decimals);
+ final balance = Balance(
+ total: zero,
+ spendable: zero,
+ blockedTotal: zero,
+ pendingSpendable: zero,
+ );
+ final theme = StackTheme.fromJson(json: lightThemeJsonMap);
+ final container = ProviderContainer(
+ overrides: [
+ pWallets.overrideWithValue(ConfirmationWallets(wallet)),
+ pCurrentTokenWallet.overrideWithValue(tokenWallet),
+ pWalletInfo(walletId).overrideWithValue(info),
+ pWalletCoin(walletId).overrideWithValue(coin),
+ pWalletName(walletId).overrideWithValue(info.name),
+ pTokenBalance((
+ walletId: walletId,
+ contractAddress: contract.address,
+ )).overrideWithValue(balance),
+ prefsChangeNotifierProvider.overrideWithValue(prefs),
+ localeServiceChangeNotifierProvider.overrideWithValue(locale),
+ priceAnd24hChangeNotifierProvider.overrideWithValue(_Price()),
+ themeProvider.overrideWithProvider(
+ StateProvider((ref) => theme),
+ ),
+ coinIconProvider(coin).overrideWithValue(
+ File('test/sample_data/light/assets/dummy.svg').absolute.path,
+ ),
+ ],
+ );
+ addTearDown(container.dispose);
+ final child = desktop
+ ? const DesktopTokenSend(walletId: walletId)
+ : TokenSendView(
+ walletId: walletId,
+ coin: coin,
+ tokenContract: contract,
+ );
+ await tester.pumpWidget(
+ UncontrolledProviderScope(
+ container: container,
+ child: MaterialApp(
+ theme: ThemeData(
+ extensions: [StackColors.fromStackColorTheme(theme)],
+ ),
+ home: desktop
+ ? Scaffold(body: SingleChildScrollView(child: child))
+ : child,
+ ),
+ ),
+ );
+ addTearDown(() async {
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ });
+ await tester.pumpAndSettle();
+ expect(tester.takeException(), isNull);
+ final field = find.byKey(
+ const Key('amountInputFieldCryptoTextFieldKey'),
+ );
+ await tester.enterText(field, '1.250001');
+ await tester.pump(const Duration(milliseconds: 600));
+ if (unitFirst) {
+ prefs.change(AmountUnit.milli);
+ locale.change('de_DE');
+ } else {
+ locale.change('de_DE');
+ prefs.change(AmountUnit.milli);
+ }
+ await tester.pump(const Duration(milliseconds: 600));
+ expect(
+ tester.widget<TextField>(field).controller!.text,
+ '1250,001',
+ );
+ final address = find.byKey(
+ Key(
+ desktop
+ ? 'sendViewAddressFieldKey'
+ : 'tokenSendViewAddressFieldKey',
+ ),
+ );
+ await tester.enterText(
+ address,
+ '0x2744ea5ac9b11cb5e3cd63d3a88e858336aeddc2',
+ );
+ await tester.pump();
+ if (desktop) {
+ final preview = tester.widget<PrimaryButton>(
+ find.widgetWithText(PrimaryButton, 'Preview send'),
+ );
+ expect(preview.enabled, true);
+ preview.onPressed!();
+ } else {
+ final preview = tester.widget<TextButton>(
+ find.widgetWithText(TextButton, 'Preview'),
+ );
+ expect(preview.onPressed, isNotNull);
+ preview.onPressed!();
+ }
+ await tester.pump(const Duration(milliseconds: 150));
+ await tester.pump(const Duration(milliseconds: 2600));
+ expect(tokenWallet.captured, isNotNull);
+ final amount = tokenWallet.captured!.recipients!.single.amount;
+ expect(
+ amount,
+ Amount.tryParseCanonicalAmount(
+ '1.250001',
+ fractionDigits: decimals,
+ ),
+ );
+ expect(amount.fractionDigits, decimals);
+ await tester.pumpWidget(const SizedBox.shrink());
+ await tester.pumpAndSettle();
+ },
+ );
+ }
+ }
+ }
+}
### test/pages/wallet_view/transaction_views/transaction_search_filter_view_test.dart
@@ -1,24 +1,17 @@
import "package:flutter_test/flutter_test.dart";
import "package:stackwallet/pages/wallet_view/transaction_views/transaction_search_filter_view.dart";
-import "package:stackwallet/utilities/amount/amount_formatter.dart";
import "package:stackwallet/utilities/amount/amount_unit.dart";
import "package:stackwallet/wallets/crypto_currency/crypto_currency.dart";
void main() {
- AmountFormatter formatter(String locale) => AmountFormatter(
- unit: AmountUnit.normal,
- locale: locale,
- coin: Bitcoin(CryptoCurrencyNetwork.main),
- maxDecimals: 8,
- );
-
test("transaction filter distinguishes empty from malformed amounts", () {
for (final text in ["", "."]) {
expect(
parseTransactionFilterAmountInput(
text: text,
locale: "en_US",
- formatter: formatter("en_US"),
+ unit: AmountUnit.normal,
+ coin: Bitcoin(CryptoCurrencyNetwork.main),
),
(isValid: true, amount: null),
reason: text,
@@ -28,7 +21,8 @@ void main() {
final trailingSeparator = parseTransactionFilterAmountInput(
text: "1.",
locale: "en_US",
- formatter: formatter("en_US"),
+ unit: AmountUnit.normal,
+ coin: Bitcoin(CryptoCurrencyNetwork.main),
);
expect(trailingSeparator.isValid, isTrue);
expect(trailingSeparator.amount?.raw, BigInt.from(100000000));
@@ -38,7 +32,8 @@ void main() {
parseTransactionFilterAmountInput(
text: text,
locale: "en_US",
- formatter: formatter("en_US"),
+ unit: AmountUnit.normal,
+ coin: Bitcoin(CryptoCurrencyNetwork.main),
).isValid,
isFalse,
reason: text,
@@ -51,15 +46,17 @@ void main() {
parseTransactionFilterAmountInput(
text: ",",
locale: "de_DE",
- formatter: formatter("de_DE"),
+ unit: AmountUnit.normal,
+ coin: Bitcoin(CryptoCurrencyNetwork.main),
),
(isValid: true, amount: null),
);
expect(
parseTransactionFilterAmountInput(
text: "1,,",
locale: "de_DE",
- formatter: formatter("de_DE"),
+ unit: AmountUnit.normal,
+ coin: Bitcoin(CryptoCurrencyNetwork.main),
).isValid,
isFalse,
);
### test/utilities/amount/amount_unit_test.dart
@@ -4,6 +4,7 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:stackwallet/models/isar/models/solana/sol_contract.dart';
import 'package:stackwallet/utilities/amount/amount.dart';
import 'package:stackwallet/utilities/amount/amount_formatter.dart';
+import 'package:stackwallet/utilities/amount/amount_parser.dart';
import 'package:stackwallet/utilities/amount/amount_input_formatter.dart';
import 'package:stackwallet/utilities/amount/amount_unit.dart';
import 'package:stackwallet/utilities/util.dart';
@@ -217,7 +218,15 @@ void main() {
maxDecimals: 8,
);
- expect(formatter.tryParseEditable("5")?.decimal, Decimal.fromInt(5));
+ expect(
+ AmountParser.tryParseEditable(
+ "5",
+ locale: formatter.locale,
+ unit: formatter.unit,
+ coin: formatter.coin,
+ )?.decimal,
+ Decimal.fromInt(5),
+ );
for (final value in [
"+5",
@@ -226,15 +235,32 @@ void main() {
for (final codePoint in [0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x20])
"1${String.fromCharCode(codePoint)}234",
]) {
- expect(formatter.tryParseEditable(value), isNull, reason: value);
+ expect(
+ AmountParser.tryParseEditable(
+ value,
+ locale: formatter.locale,
+ unit: formatter.unit,
+ coin: formatter.coin,
+ ),
+ isNull,
+ reason: value,
+ );
expect(
Amount.tryParseFiatString(value, locale: "en_US"),
isNull,
reason: value,
);
}
- expect(formatter.tryParseEditable("0.000000001"), isNull);
+ expect(
+ AmountParser.tryParseEditable(
+ "0.000000001",
+ locale: formatter.locale,
+ unit: formatter.unit,
+ coin: formatter.coin,
+ ),
+ isNull,
+ );
expect(Amount.tryParseFiatString("1.001", locale: "en_US"), isNull);
expect(
@@ -790,7 +816,12 @@ void main() {
);
final text = formatter.formatEditable(amount);
expect(
- formatter.tryParseEditable(text),
+ AmountParser.tryParseEditable(
+ text,
+ locale: formatter.locale,
+ unit: formatter.unit,
+ coin: formatter.coin,
+ ),
amount,
reason: "$locale $unit $text",
);Why this scored 33/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.