AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 43 Monero

Drop vanished unconfirmed txs on electrs too

Public commit record

What the developer wrote

Authored by sneurlax

86/100 · Strong
Drop vanished unconfirmed txs on electrs too

updateTransactions re-fetches stored unconfirmed txs and deletes the
ones the server no longer has, but it recognised that only by ElectrumX's
exact wording ("daemon error: DaemonError({'code': -5, ..."). electrs
passes bitcoind's message through unwrapped, so a replaced or dropped tx
was never deleted and every later refresh failed: one RBF bump left a
wallet on an electrs server unable to sync. Match bitcoind's message
alone, as ElectrumXClient.request already does.

Related to #1411 (electrs servers). Covered by rbf_cpfp_test.dart against
electrs in the Bitcoin regtest tests (feat/regtest).
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a bug where Stack Wallet could not clean up old unconfirmed transactions when connected to electrs servers. The wallet checks whether a transaction still exists on the server; it previously only recognized ElectrumX/Fulcrum's specific error wording and ignored electrs' simpler error message. As a result, a replaced or dropped transaction stayed in the wallet and blocked future refreshes, leaving the wallet unable to sync. The fix makes the check look for the simpler message that all server types share.

Recommended action

No immediate security response required; this is a bug-fix commit. Users relying on electrs servers should update to include this fix to avoid wallet sync stalls after RBF bumps or dropped transactions. Review other backend-specific string matches in the codebase for similar portability issues.

Security signals we found

01

Error-message parsing used for transaction lifecycle decision

02

Wallet state desynchronization due to backend-specific error handling

03

RBF/replaced transaction cleanup failure

04

Fix references existing test coverage (rbf_cpfp_test.dart)

Risk score

Why this scored 43/100

Our methodology →
Potential impact 12/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 8/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.