AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 36 Monero

fix(openalias): keep the alias when a preview is repeated

Public commit record

What the developer wrote

Authored by sneurlax

62/100 · Adequate
fix(openalias): keep the alias when a preview is repeated
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug in Stack Wallet's send flow when using OpenAlias (human-readable addresses like alice@example.com that resolve to crypto addresses). Previously, after previewing a transaction, the app replaced the alias with the resolved crypto address in the input field. If the user went back and previewed again, the app would try to re-resolve the now-plain address as if it were an alias, or lose track of the original alias. The fix keeps the alias visible to the user while internally using the resolved address for the transaction, and caches the resolution so repeated previews don't trigger unnecessary or incorrect lookups. There is no direct evidence this was exploitable for theft, but address/alias confusion in a wallet send flow is a sensitive area.

Recommended action

Treat as a defensive correctness fix rather than an active vulnerability. Reviewers should verify that _openAlias is cleared appropriately on send completion and wallet switch, and that the cached resolution cannot be reused across different coins/wallets. Consider whether OpenAlias DNSSEC validation is enforced, since this change does not alter DNS trust assumptions.

Security signals we found

01

OpenAlias resolution state now cached and reused, reducing window for DNS/lookup spoofing or race conditions

02

UI no longer overwrites alias input with resolved address, preventing user confusion about what recipient was actually used

03

Transaction construction now consistently uses a separate resolved recipient address rather than the mutable text field

04

Potential for address/alias mismatch or stale resolution mitigated by keyed cache check (openAliasKey)

05

No explicit security advisory, CVE, or vendor security disclosure present in commit or references

Risk score

Why this scored 36/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.