fix: add missing QR scan button to desktop token send views
What changed, and why it matters
This commit simply adds a missing QR-code scan button to two desktop token-send screens in the Stack Wallet app. It is a user-interface fix, not a security patch. There is no indication it fixes a vulnerability.
No security action required; treat as a routine UI/UX fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change imports a QR-code icon widget and conditionally displays a TextFieldIconButton that invokes the existing scanQr() method when the send-to address field is empty. The same pattern is applied to desktop_sol_token_send.dart and desktop_token_send.dart. No logic changes to QR parsing, validation, or transaction construction are present.
Changed components
lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_sol_token_send.dartlib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_token_send.dartInspect captured patch +16 / −0
### lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_sol_token_send.dart
@@ -46,6 +46,7 @@ import '../../../../widgets/desktop/qr_code_scanner_dialog.dart';
import '../../../../widgets/desktop/secondary_button.dart';
import '../../../../widgets/icon_widgets/addressbook_icon.dart';
import '../../../../widgets/icon_widgets/clipboard_icon.dart';
+import '../../../../widgets/icon_widgets/qrcode_icon.dart';
import '../../../../widgets/icon_widgets/x_icon.dart';
import '../../../../widgets/stack_text_field.dart';
import '../../../../widgets/textfield_icon_button.dart';
@@ -1044,6 +1045,13 @@ class _DesktopSolTokenSendState extends ConsumerState<DesktopSolTokenSend> {
},
child: const AddressBookIcon(),
),
+ if (sendToController.text.isEmpty)
+ TextFieldIconButton(
+ semanticsLabel: "Scan QR Button. Opens Camera For Scanning QR Code.",
+ key: const Key("sendViewScanQrButtonKey"),
+ onTap: scanQr,
+ child: const QrCodeIcon(),
+ ),
],
),
),
### lib/pages_desktop_specific/my_stack_view/wallet_view/sub_widgets/desktop_token_send.dart
@@ -51,6 +51,7 @@ import '../../../../widgets/desktop/secondary_button.dart';
import '../../../../widgets/eth_fee_form.dart';
import '../../../../widgets/icon_widgets/addressbook_icon.dart';
import '../../../../widgets/icon_widgets/clipboard_icon.dart';
+import '../../../../widgets/icon_widgets/qrcode_icon.dart';
import '../../../../widgets/icon_widgets/x_icon.dart';
import '../../../../widgets/stack_text_field.dart';
import '../../../../widgets/textfield_icon_button.dart';
@@ -1042,6 +1043,13 @@ class _DesktopTokenSendState extends ConsumerState<DesktopTokenSend> {
},
child: const AddressBookIcon(),
),
+ if (sendToController.text.isEmpty)
+ TextFieldIconButton(
+ semanticsLabel: "Scan QR Button. Opens Camera For Scanning QR Code.",
+ key: const Key("sendViewScanQrButtonKey"),
+ onTap: scanQr,
+ child: const QrCodeIcon(),
+ ),
],
),
),Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.