bump frostdart, parameterize download_all.sh
What the developer wrote
Authored by Dan Miller
bump frostdart, parameterize download_all.sh
What changed, and why it matters
This commit is a build-script cleanup. It makes the pre-built crypto plugin download scripts aware of which app is being built (stack_wallet, stack_duo, or campfire) so that only the plugins needed for that app are downloaded. It also updates the frostdart plugin submodule to a newer version. There is no user-facing app change and no obvious security vulnerability introduced by the diff itself.
No security action required. If reviewing the frostdart bump for security relevance, inspect the submodule commit changelog and verify the downloaded prebuilt binaries match audited sources.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff parameterizes download_all.sh across Android, iOS, Linux, macOS, and Windows. Previously the scripts always downloaded flutter_libepiccash, flutter_libmwc, and frostdart. Now they accept an APP argument: flutter_libepiccash and flutter_libmwc are downloaded only for stack_wallet; frostdart is downloaded for stack_wallet and stack_duo. build_app.sh was simplified to call ./download_all.sh “$APP_NAMED_ID” instead of branching per app. The frostdart git submodule (crypto_plugins/frostdart) was bumped, but the actual submodule content is not shown in the diff.
Changed components
scripts/android/download_all.shscripts/ios/download_all.shscripts/linux/download_all.shscripts/macos/download_all.shscripts/windows/download_all.shscripts/build_app.shcrypto_plugins/frostdart (submodule bump)Inspect captured patch +47 / −31
diff --git a/scripts/android/download_all.sh b/scripts/android/download_all.sh
index 1db80d8..34c708c 100755
--- a/scripts/android/download_all.sh
+++ b/scripts/android/download_all.sh
@@ -2,16 +2,21 @@
set -x -e
+APP="${1:-stack_wallet}"
+
mkdir -p build
. ./config.sh
PLUGINS_DIR=../../crypto_plugins
-(cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/android && ./download.sh)
-
-(cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/android && ./download.sh)
+if [[ "$APP" = "stack_wallet" ]]; then
+ (cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/android && ./download.sh)
+ (cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/android && ./download.sh)
+fi
-(cd "${PLUGINS_DIR}"/frostdart/scripts/android && ./download.sh)
+if [[ "$APP" = "stack_wallet" || "$APP" = "stack_duo" ]]; then
+ (cd "${PLUGINS_DIR}"/frostdart/scripts/android && ./download.sh)
+fi
wait
echo "Done"
diff --git a/scripts/build_app.sh b/scripts/build_app.sh
index 893856e..71a5ec6 100755
--- a/scripts/build_app.sh
+++ b/scripts/build_app.sh
@@ -117,16 +117,7 @@ fi
if [ "$BUILD_CRYPTO_PLUGINS" -eq 0 ]; then
if [ "$DOWNLOAD_CRYPTO_PLUGINS" -eq 1 ]; then
- if [[ "$APP_NAMED_ID" = "stack_wallet" ]]; then
- ./download_all.sh
- elif [[ "$APP_NAMED_ID" = "stack_duo" ]]; then
- ./build_all_duo.sh
- elif [[ "$APP_NAMED_ID" = "campfire" ]]; then
- ./build_all_campfire.sh
- else
- echo "Invalid app id: ${APP_NAMED_ID}"
- exit 1
- fi
+ ./download_all.sh "$APP_NAMED_ID"
else
if [[ "$APP_NAMED_ID" = "stack_wallet" ]]; then
./build_all.sh
diff --git a/scripts/ios/download_all.sh b/scripts/ios/download_all.sh
index 30259dd..1e5866c 100755
--- a/scripts/ios/download_all.sh
+++ b/scripts/ios/download_all.sh
@@ -2,15 +2,20 @@
set -x -e
+APP="${1:-stack_wallet}"
+
mkdir -p build
PLUGINS_DIR=../../crypto_plugins
-(cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/ios && ./download.sh)
-
-(cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/ios && ./download.sh)
+if [[ "$APP" = "stack_wallet" ]]; then
+ (cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/ios && ./download.sh)
+ (cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/ios && ./download.sh)
+fi
-(cd "${PLUGINS_DIR}"/frostdart/scripts/ios && ./download.sh)
+if [[ "$APP" = "stack_wallet" || "$APP" = "stack_duo" ]]; then
+ (cd "${PLUGINS_DIR}"/frostdart/scripts/ios && ./download.sh)
+fi
wait
echo "Done"
diff --git a/scripts/linux/download_all.sh b/scripts/linux/download_all.sh
index 5e56389..1da22e4 100755
--- a/scripts/linux/download_all.sh
+++ b/scripts/linux/download_all.sh
@@ -2,14 +2,19 @@
set -x -e
+APP="${1:-stack_wallet}"
+
mkdir -p build
./build_secure_storage_deps.sh
-(cd ../../crypto_plugins/flutter_libepiccash/scripts/linux && ./download.sh)
-
-(cd ../../crypto_plugins/flutter_libmwc/scripts/linux && ./download.sh)
+if [[ "$APP" = "stack_wallet" ]]; then
+ (cd ../../crypto_plugins/flutter_libepiccash/scripts/linux && ./download.sh)
+ (cd ../../crypto_plugins/flutter_libmwc/scripts/linux && ./download.sh)
+fi
-(cd ../../crypto_plugins/frostdart/scripts/linux && ./download.sh)
+if [[ "$APP" = "stack_wallet" || "$APP" = "stack_duo" ]]; then
+ (cd ../../crypto_plugins/frostdart/scripts/linux && ./download.sh)
+fi
./build_secp256k1.sh
diff --git a/scripts/macos/download_all.sh b/scripts/macos/download_all.sh
index 4bbb400..36dce29 100755
--- a/scripts/macos/download_all.sh
+++ b/scripts/macos/download_all.sh
@@ -2,15 +2,20 @@
set -x -e
+APP="${1:-stack_wallet}"
+
mkdir -p build
PLUGINS_DIR=../../crypto_plugins
-(cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/macos && ./download.sh)
-
-(cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/macos && ./download.sh)
+if [[ "$APP" = "stack_wallet" ]]; then
+ (cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/macos && ./download.sh)
+ (cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/macos && ./download.sh)
+fi
-(cd "${PLUGINS_DIR}"/frostdart/scripts/macos && ./download.sh)
+if [[ "$APP" = "stack_wallet" || "$APP" = "stack_duo" ]]; then
+ (cd "${PLUGINS_DIR}"/frostdart/scripts/macos && ./download.sh)
+fi
wait
echo "Done"
diff --git a/scripts/windows/download_all.sh b/scripts/windows/download_all.sh
index 6bd3504..0585885 100755
--- a/scripts/windows/download_all.sh
+++ b/scripts/windows/download_all.sh
@@ -2,15 +2,20 @@
set -x -e
+APP="${1:-stack_wallet}"
+
mkdir -p build
PLUGINS_DIR=../../crypto_plugins
-(cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/windows && ./download.sh)
-
-(cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/windows && ./download.sh)
+if [[ "$APP" = "stack_wallet" ]]; then
+ (cd "${PLUGINS_DIR}"/flutter_libepiccash/scripts/windows && ./download.sh)
+ (cd "${PLUGINS_DIR}"/flutter_libmwc/scripts/windows && ./download.sh)
+fi
-(cd "${PLUGINS_DIR}"/frostdart/scripts/windows && ./download.sh)
+if [[ "$APP" = "stack_wallet" || "$APP" = "stack_duo" ]]; then
+ (cd "${PLUGINS_DIR}"/frostdart/scripts/windows && ./download.sh)
+fi
wait
echo "Done"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.