What the developer wrote
Authored by julian
fix: clean up
What changed, and why it matters
This commit is a minor code cleanup in the Stack Wallet app's ShopInBit feature. It removes a duplicate line of code and fixes the indentation of some UI widget code. There is no security-relevant change.
No security action needed. Treat as routine code cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff makes two non-functional changes in Dart UI code: (1) removes a duplicated final skipGuidelines = ShopInBitService.instance.loadGuidelinesAccepted(); assignment in shopinbit_step_2.dart, and (2) re-indents a block of widget code in desktop_shopinbit_view.dart without altering the widget structure or behavior. No logic, validation, cryptography, networking, or access-control code is modified.
Changed components
lib/pages/shopinbit/shopinbit_step_2.dartlib/pages_desktop_specific/more_view/sub_widgets/desktop_shopinbit_view.dartInspect captured patch +31 / −33
diff --git a/lib/pages/shopinbit/shopinbit_step_2.dart b/lib/pages/shopinbit/shopinbit_step_2.dart
index 01674db..9df909e 100644
--- a/lib/pages/shopinbit/shopinbit_step_2.dart
+++ b/lib/pages/shopinbit/shopinbit_step_2.dart
@@ -56,8 +56,6 @@ class _ShopInBitStep2State extends State<ShopInBitStep2> {
widget.model.category = _selected;
final skipGuidelines = ShopInBitService.instance.loadGuidelinesAccepted();
- final skipGuidelines = ShopInBitService.instance.loadGuidelinesAccepted();
-
if (Util.isDesktop) {
Navigator.of(context, rootNavigator: true).pop();
if (skipGuidelines) {
diff --git a/lib/pages_desktop_specific/more_view/sub_widgets/desktop_shopinbit_view.dart b/lib/pages_desktop_specific/more_view/sub_widgets/desktop_shopinbit_view.dart
index 5f25e98..d698379 100644
--- a/lib/pages_desktop_specific/more_view/sub_widgets/desktop_shopinbit_view.dart
+++ b/lib/pages_desktop_specific/more_view/sub_widgets/desktop_shopinbit_view.dart
@@ -169,37 +169,37 @@ class _DesktopServicesViewState extends ConsumerState<DesktopShopInBitView> {
),
],
),
- ),
- const Spacer(),
- Row(
- mainAxisAlignment: MainAxisAlignment.center,
- children: [
- SecondaryButton(
- width: 200,
- buttonHeight: ButtonHeight.l,
- label: "Cancel",
- onPressed: () {
- Navigator.of(dialogContext, rootNavigator: true).pop();
- },
- ),
- const SizedBox(width: 20),
- PrimaryButton(
- width: 200,
- buttonHeight: ButtonHeight.l,
- label: "Continue",
- onPressed: () async {
- Navigator.of(dialogContext, rootNavigator: true).pop();
- await showDialog<void>(
- context: context,
- barrierDismissible: false,
- builder: (_) => ShopInBitStep1(model: model),
- );
- if (mounted) setState(() {});
- },
- ),
- ],
- ),
- ],
+ const Spacer(),
+ Row(
+ mainAxisAlignment: MainAxisAlignment.center,
+ children: [
+ SecondaryButton(
+ width: 200,
+ buttonHeight: ButtonHeight.l,
+ label: "Cancel",
+ onPressed: () {
+ Navigator.of(dialogContext, rootNavigator: true).pop();
+ },
+ ),
+ const SizedBox(width: 20),
+ PrimaryButton(
+ width: 200,
+ buttonHeight: ButtonHeight.l,
+ label: "Continue",
+ onPressed: () async {
+ Navigator.of(dialogContext, rootNavigator: true).pop();
+ await showDialog<void>(
+ context: context,
+ barrierDismissible: false,
+ builder: (_) => ShopInBitStep1(model: model),
+ );
+ if (mounted) setState(() {});
+ },
+ ),
+ ],
+ ),
+ ],
+ ),
),
),
);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.